Skip to content

Conversation

thunderbiscuit
Copy link
Member

@thunderbiscuit thunderbiscuit commented Sep 3, 2025

This PR brings similar tests to what we have on bdk-jvm.

It's just the beginning, but it's a clean up of what we had before. It removes all "live" tests that used Signet. This ensures that what we have here can run in the CI on every PR without being fickle.

I plan on adding a ton more! But for now this is a simple refactor of the tests we have.

This should go in before #821 and #825, as I'll add tests for those once this is in.

@ItoroD
Copy link
Collaborator

ItoroD commented Sep 3, 2025

ACK c0a6d00

Copy link
Collaborator

@reez reez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK c0a6d00

@thunderbiscuit
Copy link
Member Author

Thanks guys!

@thunderbiscuit thunderbiscuit merged commit c0a6d00 into bitcoindevkit:master Sep 3, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants