Clean up android instrumented tests

bdk-android/lib/src/androidTest/kotlin/org/bitcoindevkit/Constants.kt

@@ -0,0 +1,38 @@
+package org.bitcoindevkit
+
+// Test networks
+const val TEST_EXTENDED_PRIVKEY = "tprv8ZgxMBicQKsPf2qfrEygW6fdYseJDDrVnDv26PH5BHdvSuG6ecCbHqLVof9yZcMoM31z9ur3tTYbSnr1WBqbGX97CbXcmp5H6qeMpyvx35B"
+const val BIP84_TEST_RECEIVE_PATH = "84h/1h/0h/0"
+const val BIP84_TEST_CHANGE_PATH = "84h/1h/0h/1"
+const val BIP86_TEST_RECEIVE_PATH = "86h/1h/0h/0"
+const val BIP86_TEST_CHANGE_PATH = "86h/1h/0h/1"
+
+// Mainnet
+const val MAINNET_EXTENDED_PRIVKEY = "xprv9s21ZrQH143K3LRcTnWpaCSYb75ic2rGuSgicmJhSVQSbfaKgPXfa8PhnYszgdcyWLoc8n1E2iHUnskjgGTAyCEpJYv7fqKxUcRNaVngA1V"
+const val BIP84_MAINNET_RECEIVE_PATH = "84h/0h/0h/1"
+const val BIP86_MAINNET_RECEIVE_PATH = "86h/0h/0h/1"
+
+val BIP84_DESCRIPTOR: Descriptor = Descriptor(
+    "wpkh($TEST_EXTENDED_PRIVKEY/$BIP84_TEST_RECEIVE_PATH/*)",
+    Network.TESTNET
+)
+val BIP84_CHANGE_DESCRIPTOR: Descriptor = Descriptor(
+    "wpkh($TEST_EXTENDED_PRIVKEY/$BIP84_TEST_CHANGE_PATH/*)",
+    Network.TESTNET
+)
+val BIP86_DESCRIPTOR: Descriptor = Descriptor(
+    "tr($TEST_EXTENDED_PRIVKEY/$BIP86_TEST_RECEIVE_PATH/*)",
+    Network.TESTNET
+)
+val BIP86_CHANGE_DESCRIPTOR: Descriptor = Descriptor(
+    "tr($TEST_EXTENDED_PRIVKEY/$BIP86_TEST_CHANGE_PATH/*)",
+    Network.TESTNET
+)
+val NON_EXTENDED_DESCRIPTOR_0: Descriptor = Descriptor(
+    descriptor = "wpkh($TEST_EXTENDED_PRIVKEY/$BIP84_TEST_RECEIVE_PATH/0)",
+    network = Network.TESTNET
+)
+val NON_EXTENDED_DESCRIPTOR_1: Descriptor = Descriptor(
+    descriptor = "wpkh($TEST_EXTENDED_PRIVKEY/$BIP84_TEST_RECEIVE_PATH/1)",
+    network = Network.TESTNET
+)

bdk-android/lib/src/androidTest/kotlin/org/bitcoindevkit/CreatingWalletTest.kt

@@ -0,0 +1,58 @@
+package org.bitcoindevkit
+
+import kotlin.test.Test
+import kotlin.test.assertFails
+import androidx.test.ext.junit.runners.AndroidJUnit4
+import org.junit.runner.RunWith
+
+@RunWith(AndroidJUnit4::class)
+class CreatingWalletTest {
+    private val conn: Persister = Persister.newInMemory()
+
+    // Create a WPKH wallet.
+    @Test
+    fun createWPKHWallet() {
+        Wallet(
+            descriptor = BIP84_DESCRIPTOR,
+            changeDescriptor = BIP84_CHANGE_DESCRIPTOR,
+            network = Network.TESTNET,
+            persister = conn
+        )
+    }
+
+    // Create a TR wallet.
+    @Test
+    fun createTRWallet() {
+        Wallet(
+            descriptor = BIP86_DESCRIPTOR,
+            changeDescriptor = BIP86_CHANGE_DESCRIPTOR,
+            network = Network.TESTNET,
+            persister = conn
+        )
+    }
+
+    // Create a wallet with a non-extended descriptor.
+    @Test
+    fun createWalletWithNonExtendedDescriptor() {
+        Wallet(
+            descriptor = NON_EXTENDED_DESCRIPTOR_0,
+            changeDescriptor = NON_EXTENDED_DESCRIPTOR_1,
+            network = Network.TESTNET,
+            persister = conn
+        )
+    }
+
+    // Descriptors do not match provided network.
+    @Test
+    fun failsIfDescriptorsDontMatchNetwork() {
+        // The descriptors provided are for Testnet 3, but the wallet attempts to build for Mainnet
+        assertFails {
+            Wallet(
+                descriptor = NON_EXTENDED_DESCRIPTOR_0,
+                changeDescriptor = NON_EXTENDED_DESCRIPTOR_1,
+                network = Network.BITCOIN,
+                persister = conn
+            )
+        }
+    }
+}

bdk-android/lib/src/androidTest/kotlin/org/bitcoindevkit/DescriptorTest.kt

@@ -0,0 +1,50 @@
+package org.bitcoindevkit
+
+import kotlin.test.Test
+import androidx.test.ext.junit.runners.AndroidJUnit4
+import org.junit.runner.RunWith
+import kotlin.test.assertFails
+
+@RunWith(AndroidJUnit4::class)
+class DescriptorTest {
+    // Create extended WPKH descriptors for all networks.
+    @Test
+    fun createExtendedWPKHDescriptors() {
+        Descriptor("wpkh($TEST_EXTENDED_PRIVKEY/$BIP84_TEST_RECEIVE_PATH/*)", Network.REGTEST)
+        Descriptor("wpkh($TEST_EXTENDED_PRIVKEY/$BIP84_TEST_RECEIVE_PATH/*)", Network.TESTNET)
+        Descriptor("wpkh($TEST_EXTENDED_PRIVKEY/$BIP84_TEST_RECEIVE_PATH/*)", Network.TESTNET4)
+        Descriptor("wpkh($TEST_EXTENDED_PRIVKEY/$BIP84_TEST_RECEIVE_PATH/*)", Network.SIGNET)
+        Descriptor("wpkh($MAINNET_EXTENDED_PRIVKEY/$BIP84_MAINNET_RECEIVE_PATH/*)", Network.BITCOIN)
+    }
+
+    // Create extended TR descriptors for all networks.
+    @Test
+    fun createExtendedTRDescriptors() {
+        Descriptor("tr($TEST_EXTENDED_PRIVKEY/$BIP86_TEST_RECEIVE_PATH/*)", Network.REGTEST)
+        Descriptor("tr($TEST_EXTENDED_PRIVKEY/$BIP86_TEST_RECEIVE_PATH/*)", Network.TESTNET)
+        Descriptor("tr($TEST_EXTENDED_PRIVKEY/$BIP86_TEST_RECEIVE_PATH/*)", Network.TESTNET4)
+        Descriptor("tr($TEST_EXTENDED_PRIVKEY/$BIP86_TEST_RECEIVE_PATH/*)", Network.SIGNET)
+        Descriptor("tr($MAINNET_EXTENDED_PRIVKEY/$BIP86_MAINNET_RECEIVE_PATH/*)", Network.BITCOIN)
+    }
+
+    // Create non-extended descriptors for all networks.
+    @Test
+    fun createNonExtendedDescriptors() {
+        Descriptor("tr($TEST_EXTENDED_PRIVKEY/$BIP86_TEST_RECEIVE_PATH/0)", Network.REGTEST)
+        Descriptor("tr($TEST_EXTENDED_PRIVKEY/$BIP86_TEST_RECEIVE_PATH/0)", Network.TESTNET)
+        Descriptor("tr($TEST_EXTENDED_PRIVKEY/$BIP86_TEST_RECEIVE_PATH/0)", Network.TESTNET4)
+        Descriptor("tr($TEST_EXTENDED_PRIVKEY/$BIP86_TEST_RECEIVE_PATH/0)", Network.SIGNET)
+        Descriptor("tr($MAINNET_EXTENDED_PRIVKEY/$BIP86_MAINNET_RECEIVE_PATH/0)", Network.BITCOIN)
+    }
+
+    // Cannot create addr() descriptor.
+    @Test
+    fun cannotCreateAddrDescriptor() {
+        assertFails {
+            val descriptor: Descriptor = Descriptor(
+                "addr(tb1qhjys9wxlfykmte7ftryptx975uqgd6kcm6a7z4)",
+                Network.TESTNET
+            )
+        }
+    }
+}

bdk-android/lib/src/androidTest/kotlin/org/bitcoindevkit/OfflineDescriptorTest.kt → bdk-android/lib/src/androidTest/kotlin/org/bitcoindevkit/MnemonicTest.kt

@@ -1,14 +1,15 @@
 package org.bitcoindevkit
 
-import kotlin.test.Test
-import kotlin.test.assertEquals
 import androidx.test.ext.junit.runners.AndroidJUnit4
 import org.junit.runner.RunWith
+import kotlin.test.Test
+import kotlin.test.assertEquals
 
 @RunWith(AndroidJUnit4::class)
-class OfflineDescriptorTest {
+class MnemonicTest {
+    // Mnemonics create valid descriptors.
     @Test
-    fun testDescriptorBip86() {
+    fun mnemonicsCreateValidDescriptors() {
         val mnemonic: Mnemonic = Mnemonic.fromString("space echo position wrist orient erupt relief museum myself grain wisdom tumble")
         val descriptorSecretKey: DescriptorSecretKey = DescriptorSecretKey(Network.TESTNET, mnemonic, null)
         val descriptor: Descriptor = Descriptor.newBip86(descriptorSecretKey, KeychainKind.EXTERNAL, Network.TESTNET)