Closed
Conversation
bitfaster
commented
May 26, 2024
Owner
Author
|
Superseded by #621 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When updating a large struct, instead of updating in place, we can instead create a new node. Since nodes are not updated, no tearing can occur.
Time based expiry is a special case that is handled as follows:
INodePolicy.Clonemethod creates the replacement node to insert into the dictionary. ForExpireAfterPolicythis avoids calling expiry calculator on create, and we set current expiry to match old node. We also set GetNextInTimeOrder == self, this is a hack so thatExpireAfterPolicy.OnWriteknows the node was not created and is currently detached from theTimerWheel.ExpireAfterPolicy.OnWrite, check if next == self to schedule/reschedule. Schedule will just overwrite next to a valid node.TODO: