Mitigate LFU struct tearing using SeqLock#621
Merged
Conversation
Owner
Author
|
Get bench difference is noise: Before
After
|
Owner
Author
This was referenced Sep 15, 2024
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Repeat of #593, but for LFU. The lock counter fits inside node padding when the position enum is reduced from a 32 to 16 bit integer (see #590).
This is preferred to the approach outlined in #596, since we avoid allocating a new node and complicating time-based expiry logic. Nodes now contain a 32bit counter which fits inside the padding for the common case (64bit platform, key and value are 64bit objects).
Revisit: