Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: add core_nt Kraken 2 DB to the list of allowed databases #228

Merged
merged 2 commits into from
Jan 18, 2025

Conversation

misialq
Copy link
Contributor

@misialq misialq commented Jan 9, 2025

Closes #223.

@misialq misialq requested a review from VinzentRisch January 9, 2025 10:16
Copy link

codecov bot commented Jan 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.50%. Comparing base (b6d068a) to head (101e4ec).
Report is 12 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #228      +/-   ##
==========================================
- Coverage   95.60%   95.50%   -0.10%     
==========================================
  Files          34       34              
  Lines        1956     1980      +24     
  Branches      226      231       +5     
==========================================
+ Hits         1870     1891      +21     
- Misses         48       49       +1     
- Partials       38       40       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@misialq
Copy link
Contributor Author

misialq commented Jan 17, 2025

Any news on this one @VinzentRisch?

@VinzentRisch
Copy link
Contributor

Good morning Michal
Im sorry, Ive still been running tests for busco. But Im gonna do this today.

@misialq
Copy link
Contributor Author

misialq commented Jan 18, 2025

Merging after having tested successfully.

@misialq misialq merged commit 9a69cb6 into bokulich-lab:main Jan 18, 2025
9 checks passed
@misialq misialq deleted the issue-223 branch January 18, 2025 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ENH: allow download of the core_nt Kraken 2 database by the build-kraken-db action
2 participants