Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spelling #1481

Open
wants to merge 55 commits into
base: master
Choose a base branch
from
Open

Spelling #1481

wants to merge 55 commits into from

Conversation

jsoref
Copy link

@jsoref jsoref commented Mar 18, 2025

This PR corrects misspellings identified by the check-spelling action

The misspellings have been reported at https://github.com/jsoref/bottle/actions/runs/13933473106#summary-38996078358

The action reports that the changes in this PR would make it mostly happy: https://github.com/jsoref/bottle/actions/runs/13933473421#summary-38996078884

jsoref added 12 commits March 18, 2025 16:33
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
@@ -65,7 +65,7 @@ def _cli_patch(cli_args): # pragma: no coverage
_cli_patch(sys.argv)

###############################################################################
# Imports and Helpers used everywhere else #####################################
# Imports and Helpers used everywhere else ####################################
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't really a spelling change. I noticed it when I looked at the file (I'm considering using this project for a task...)

@@ -394,7 +394,7 @@ msgid "Current value of the 'Content-Length' header."
msgstr ""

#: ../../../bottle.py:docstring of bottle.FileUpload.get_header:1
msgid "Return the value of a header within the mulripart part."
msgid "Return the value of a header within the multipart part."
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I usually avoid touching localizations/pot files, but for this project, I decided to include the changes. It's trivial for me to drop changes to files, I just need to know which...

@@ -480,7 +480,7 @@ msgid "Current value of the 'Content-Length' header."
msgstr ""

#: ../../../bottle.pydocstring of bottle.FileUpload.get_header:1
msgid "Return the value of a header within the mulripart part."
msgid "Return the value of a header within the multipart part."
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My logic for updating translations is that the translator has either picked a translation or hasn't gotten around to it, and in either case fixing a typo isn't material.

If there's a sign that the translation was misguided based on the typo, then I wouldn't update a key.

@@ -125,7 +125,7 @@ msgid ""
" in at least the two latest minor releases and announced in all available "
"channels (mailinglist, twitter, github). Non-critical bugs or features are "
"not guaranteed to be backported. This may change in the future, through."
msgstr "Die Bottle Versionsnummer ist in drei Teile unterteilt (**major.minor.revision**). Diese werden *nicht* dazu genutzt um neue Funktionen zu bewerben, sondern um wichtige bug-fixes und/oder Änderungen an der API zu indizieren. Kritische Fehler werden in den letzten zwei stabilen Veröffentlichungen behoben und über alle Kanäle mitgeteilt (Mailinglisten, Twitter, Github). Nicht kritische Fehler oder Features werden garantiert zurückgestellt. Dies wird sich eventuell in der Zukunft ändern. "
msgstr "Die Bottle Versionsnummer ist in drei Teile unterteilt (**major.minor.revision**). Diese werden *nicht* dazu genutzt um neue Funktionen zu bewerben, sondern um wichtige bug-fixes und/oder Änderungen an der API zu indizieren. Kritische Fehler werden in den letzten zwei stabilen Veröffentlichungen behoben und über alle Kanäle mitgeteilt (Mailinglisten, Twitter, GitHub). Nicht kritische Fehler oder Features werden garantiert zurückgestellt. Dies wird sich eventuell in der Zukunft ändern. "
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is different. I believe the correct thing is for someone to go into transifex and fix the translation, but I don't have the resources to do that for random projects.

@@ -101,7 +101,7 @@ msgstr "{{}}中的Python语句会在渲染的时候被执行,可访问传递

#: ../../stpl.rst:62
msgid "Embedded python code"
msgstr "嵌入Pyhton代码"
msgstr "嵌入Python代码"
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As with the German translation, this is a typo in the translation and I don't have the resources to send feedback otherwise.

Also note that while I've made these changes here, if I were to return at a later date, I wouldn't notice typos in the translations as I've added them to an exclusion list.

Comment on lines +545 to +546
:attr:`Request.POST <BaseRequest.POST>` Form fields and file uploads combined
:attr:`Request.forms <BaseRequest.forms>` Form fields
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Notable. Sometimes web app frameworks deal w/ ORM (Object Relational Model) things... Based on context, I decided this was actually a typo. Initially I was going to skip it since I'm so used to orm in frameworks like this...

jsoref added 17 commits March 18, 2025 17:21
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
jsoref added 26 commits March 18, 2025 17:21
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant