Skip to content

Commit

Permalink
Build: fix linux build (#641)
Browse files Browse the repository at this point in the history
Fixes #640: Linux build was failing due to icon. It doesn't seem to work
with `ics` or `ico` formats, or at least not the ones which are used for
Mac/Windows.
To mitigate, set a png icon.

Note that for some reason the icon does not seem to actually apply:

![image](https://github.com/user-attachments/assets/8be0db2d-8459-47fe-a712-e5db72761635)
I thought it might be due to the png dimensions, but I tried setting a
512x512 png instead and the result was the same.

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **New Features**
- Updated the Linux application build with a fresh icon for enhanced
visual branding.
- **Improvements**
- Expanded the testing matrix to include Windows as an operating system
for running tests.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

---------

Co-authored-by: Baruch Odem <[email protected]>
  • Loading branch information
whatuserever and baruchiro authored Feb 11, 2025
1 parent dd8eebb commit 05b6b16
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions electron-builder.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ files:

linux:
target: deb
icon: packages/renderer/src/assets/logos/logoFishOnly.png

publish:
- provider: github
Expand Down

0 comments on commit 05b6b16

Please sign in to comment.