-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Ubuntu GitHub test action #643
Conversation
WalkthroughThe pull request modifies the GitHub Actions workflow by updating the operating system specified in the job matrix from Changes
Sequence Diagram(s)sequenceDiagram
participant GitHub as GitHub Actions
participant Runner as CI Runner
participant OS as Operating System
GitHub->>Runner: Trigger workflow
Runner->>OS: Detect OS version
alt OS is ubuntu-22.04
OS-->>Runner: ubuntu-22.04 confirmed
Runner->>Runner: Execute xvfb-run command
else
Runner->>Runner: Skip xvfb-run command
end
Runner->>Runner: Execute yarn test:e2e command
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (3)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
@whatuserever thank you!! It is still not working.
|
Hmm I'm not sure it's worth merging this PR if it's not solving the issue 🤔 |
I think you didn't understand me. Can you contact me on Discord? |
🎉 This PR is included in version 2.7.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
The
ubuntu-latest
tag was changed to point to Ubuntu 24.04 and has caused regressions. See microsoft/playwright#34251 and electron/electron#42510 for more details.TL;DR:
Update
The command above fixed the
Process failed to launch
error, but instead produced aTimeout 30000ms exceeded
error. For now, setting tests to run on ubuntu-22.04 as that seems to work at the moment.Summary by CodeRabbit
Summary by CodeRabbit