Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Ubuntu GitHub test action #643

Merged
merged 3 commits into from
Feb 11, 2025

Conversation

whatuserever
Copy link
Contributor

@whatuserever whatuserever commented Feb 9, 2025

The ubuntu-latest tag was changed to point to Ubuntu 24.04 and has caused regressions. See microsoft/playwright#34251 and electron/electron#42510 for more details.
TL;DR:

The solution is to lift the restrictions that Ubuntu 24.04 implements in the AppImages.

sudo sysctl -w kernel.apparmor_restrict_unprivileged_userns=0

Update

The command above fixed the Process failed to launch error, but instead produced a Timeout 30000ms exceeded error. For now, setting tests to run on ubuntu-22.04 as that seems to work at the moment.

Summary by CodeRabbit

Summary by CodeRabbit

  • Chores
    • Enhanced the automated testing workflow by updating the operating system to Ubuntu 22.04, improving the reliability of our testing process.

Copy link

coderabbitai bot commented Feb 9, 2025

Walkthrough

The pull request modifies the GitHub Actions workflow by updating the operating system specified in the job matrix from ubuntu-latest to ubuntu-22.04. It introduces conditional statements for the xvfb-run and yarn test:e2e commands, ensuring they execute based on the OS version. A comment indicates an intention to revert to the latest version once an issue with Electron is resolved. No changes were made to any exported or public entities.

Changes

Files Change Summary
.github/workflows/tests.yml Updated the OS in the job matrix to ubuntu-22.04, added conditions for xvfb-run and yarn test:e2e commands based on the OS version.

Sequence Diagram(s)

sequenceDiagram
    participant GitHub as GitHub Actions
    participant Runner as CI Runner
    participant OS as Operating System

    GitHub->>Runner: Trigger workflow
    Runner->>OS: Detect OS version
    alt OS is ubuntu-22.04
        OS-->>Runner: ubuntu-22.04 confirmed
        Runner->>Runner: Execute xvfb-run command
    else
        Runner->>Runner: Skip xvfb-run command
    end
    Runner->>Runner: Execute yarn test:e2e command
Loading

Poem

Hopping through code with a joyful zest,
I update the workflow to give Ubuntu its best.
Conditional steps in the CI night,
Testing flows smoother, everything feels right.
I’m a happy rabbit, leaping with delight,
Celebrating change under the CI light! 🐰🌟


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3cbcfac and 0c34fce.

📒 Files selected for processing (1)
  • .github/workflows/tests.yml (2 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • .github/workflows/tests.yml
⏰ Context from checks skipped due to timeout of 90000ms (3)
  • GitHub Check: build (windows-latest)
  • GitHub Check: tests (ubuntu-22.04)
  • GitHub Check: build (macos-13)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@baruchiro
Copy link
Collaborator

@whatuserever thank you!!

It is still not working.

  1. It is OK for me to unite both PRs (this and Build: fix linux build #641) since they are both fixing the Linux pipelines.
  2. If there is a bug on Electron that supports Ubuntu 24.04, it is OK for me to test it on the previous Ubuntu version.

@whatuserever
Copy link
Contributor Author

Hmm I'm not sure it's worth merging this PR if it's not solving the issue 🤔

@baruchiro
Copy link
Collaborator

I think you didn't understand me. Can you contact me on Discord?

@baruchiro baruchiro merged commit dd8eebb into brafdlog:master Feb 11, 2025
9 checks passed
Copy link
Contributor

🎉 This PR is included in version 2.7.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants