add dedicated feedback page

[zzhaobraze]

Add a dedicated feedback page
/docs/feedback/

[josh-mccrowell-braze]

Thanks for this, Z! Going to shop around for feedback.

[josh-mccrowell-braze]

Suggested change

	<textarea id="feedback_comment" placeholder="I couldn’t find any information about this error message"></textarea><br />
	<textarea id="feedback_comment" placeholder=""I couldn’t find any information about this error message""></textarea><br />

Is it possible to add quotation marks so that the placeholder text looks more like an example?

[zzhaobraze]

try now once the vercel update

[bre-fitzgerald]

Hey @zzhaobraze! This looks great, thanks so much for putting this together! One big thing—the first field "How useful do you find Braze docs?" is an h3, but this should be a label similar to the "Share your feedback" field.

In that same vein, I have a few concerns about the accessibility of this form with the current implementation.

• The gray unhighlighted version of the stars looks very light. Can we explore other options for accessibility? Previously I think it filled in and bolded the outline of the star. That would be preferred. Right now we are only denoting selection through color, which is not accessible.
• The form elements (the rating stars and textarea) lack proper semantic grouping with <form> and associated <fieldset>/<legend> for better structure and clarity.
• Interactive elements like the rating stars should be implemented with proper semantics like <button> or <input type="radio">, rather than styled <li> elements for better screen reader support and keyboard navigation.

Is this something we can incorporate into the revision? I want to make sure we're putting out a form that everyone can interact with! 💪 Let me know how I can support.

[zzhaobraze]

Hey @zzhaobraze! This looks great, thanks so much for putting this together! One big thing—the first field "How useful do you find Braze docs?" is an h3, but this should be a label similar to the "Share your feedback" field.

In that same vein, I have a few concerns about the accessibility of this form with the current implementation.

• The gray unhighlighted version of the stars looks very light. Can we explore other options for accessibility? Previously I think it filled in and bolded the outline of the star. That would be preferred. Right now we are only denoting selection through color, which is not accessible.
• The form elements (the rating stars and textarea) lack proper semantic grouping with <form> and associated <fieldset>/<legend> for better structure and clarity.
• Interactive elements like the rating stars should be implemented with proper semantics like <button> or <input type="radio">, rather than styled <li> elements for better screen reader support and keyboard navigation.

Is this something we can incorporate into the revision? I want to make sure we're putting out a form that everyone can interact with! 💪 Let me know how I can support.

I have made some ui changes but changing it stars to button or input would require a complete rework of the stars.

[josh-mccrowell-braze]

Hey Z! The rework is great, appreciate the extra fixes. I just chatted with @bre-fitzgerald, and we agree that it's worth the extra time to make sure this is fully accessible.

I understand this wasn't in the initial request. What's the best way to proceed?

One thing we could do is:

• Merge this PR (so the ticket doesn't get stale
• Open another GE ticket to make the stars selectable using the keyboard
• Hold off on "launching" this feature until the new GE ticket is worked, so the page is more ADA compliant at launch.

Let me know your thoughts. Thanks!

[zzhaobraze]

Hey Z! The rework is great, appreciate the extra fixes. I just chatted with @bre-fitzgerald, and we agree that it's worth the extra time to make sure this is fully accessible.

I understand this wasn't in the initial request. What's the best way to proceed?

One thing we could do is:

• Merge this PR (so the ticket doesn't get stale
• Open another GE ticket to make the stars selectable using the keyboard
• Hold off on "launching" this feature until the new GE ticket is worked, so the page is more ADA compliant at launch.

Let me know your thoughts. Thanks!

i would just merge this PR if everything is fine and convert the stars as a todo

[josh-mccrowell-braze]

Cool, I'll merge. Do you want me to open a new ticket for the star conversion?