Use u128 for payment amounts #216
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielgranhao
force-pushed
the
daniel-breez-sdk-token-support
branch
3 times, most recently
from
ba0a2df to
f5749cc
Compare
danielgranhao
force-pushed
the
daniel-custom-u128-type
branch
from
a2b6199 to
197e635
Compare
danielgranhao
force-pushed
the
daniel-breez-sdk-token-support
branch
4 times, most recently
from
a538481 to
598f73a
Compare
dangeross
force-pushed
the
daniel-breez-sdk-token-support
branch
from
27dbbe3 to
92dc1cb
Compare
dangeross
force-pushed
the
daniel-custom-u128-type
branch
2 times, most recently
from
0df0e80 to
95db261
Compare
danielgranhao
force-pushed
the
daniel-breez-sdk-token-support
branch
2 times, most recently
from
9182f6b to
9c70b27
Compare
danielgranhao
force-pushed
the
daniel-custom-u128-type
branch
2 times, most recently
from
4f729b4 to
a6eb7d7
Compare
danielgranhao
force-pushed
the
daniel-custom-u128-type
branch
from
a6eb7d7 to
e1a8ab0
Compare
dangeross
reviewed
Oct 8, 2025
|
|
||
| [custom_types.common_u128] | ||
| type_name = "BigInteger" | ||
| imports = [ "com.ionspin.kotlin.bignum.integer.BigInteger" ] |
There was a problem hiding this comment.
Is there an issue using java.math.BigInteger in kotlin multiplatform?
There was a problem hiding this comment.
IIUC it isn't available on native Kotlin (only in JVM envs) so we can't use it in multiplatform kotlin
Co-authored-by: Ross Savage <[email protected]>
dangeross
approved these changes
Oct 9, 2025
There was a problem hiding this comment.
Nice, should help with testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This proposes the use of UniFFI custom types for exposing u128 to our bindings.
TODO: