feat: add docs links to feature page headers#495
Open
Felarof (felarof99) wants to merge 1 commit intomainfrom
Open
feat: add docs links to feature page headers#495Felarof (felarof99) wants to merge 1 commit intomainfrom
Felarof (felarof99) wants to merge 1 commit intomainfrom
Conversation
Add HelpCircle icon with tooltip linking to docs.browseros.com for each feature page: Skills, Connect Apps, Memory, Soul, LLM Providers, LLM Chat Hub, and MCP Server. Follows the existing pattern from Workflows and Scheduled Tasks headers. Also centralizes the MCP Server docs URL into productUrls.ts instead of being hardcoded in the component. Co-Authored-By: Claude Opus 4.6 <[email protected]>
Contributor
Greptile SummaryThis PR applies a consistent "help link" pattern — a Key changes:
Confidence Score: 5/5
Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[User hovers HelpCircle icon] --> B[Tooltip appears\n'Learn more about ...']
A --> C[User clicks icon]
C --> D[Opens docs.browseros.com\nin new tab]
subgraph Headers updated
H1[SkillsPage / SkillsHeader]
H2[ConnectMCP]
H3[MemoryHeader]
H4[SoulHeader]
H5[LlmProvidersHeader]
H6[LlmHubHeader]
H7[MCPServerHeader\nrefactor only]
end
subgraph productUrls.ts
U1[skillsHelpUrl]
U2[connectAppsHelpUrl]
U3[memoryHelpUrl]
U4[soulHelpUrl]
U5[bringYourOwnLlmHelpUrl]
U6[llmChatHubHelpUrl]
U7[mcpClientsHelpUrl]
end
H1 --> U1
H2 --> U2
H3 --> U3
H4 --> U4
H5 --> U5
H6 --> U6
H7 --> U7
Prompt To Fix All With AIThis is a comment left during a code review.
Path: apps/agent/entrypoints/app/soul/SoulHeader.tsx
Line: 33
Comment:
**Tooltip copy exposes internal file-name detail**
The tooltip text "Learn more about SOUL.md" leaks an implementation detail (the name of a config file) into user-facing UI copy. Every other header uses plain feature names ("Learn more about memory", "Learn more about skills", etc.). Consider aligning with that pattern:
```suggestion
<TooltipContent>Learn more about Agent Soul</TooltipContent>
```
How can I resolve this? If you propose a fix, please make it concise.
---
This is a comment left during a code review.
Path: apps/agent/entrypoints/app/connect-mcp/ConnectMCP.tsx
Line: 242
Comment:
**Tooltip text doesn't match the heading**
The heading says "Connected Apps" (with a "d") but the tooltip reads "Learn more about Connect Apps". It also diverges from `LlmHubHeader` which omits the "LLM" prefix. For consistency, consider matching the exact heading text:
```suggestion
<TooltipContent>Learn more about Connected Apps</TooltipContent>
```
How can I resolve this? If you propose a fix, please make it concise.
---
This is a comment left during a code review.
Path: apps/agent/entrypoints/app/llm-hub/LlmHubHeader.tsx
Line: 33
Comment:
**Tooltip text truncates the heading**
The heading is "LLM Chat & Hub" but the tooltip reads "Learn more about Chat & Hub", dropping the "LLM" prefix. Consider matching the full feature name for consistency:
```suggestion
<TooltipContent>Learn more about LLM Chat & Hub</TooltipContent>
```
How can I resolve this? If you propose a fix, please make it concise.
---
This is a comment left during a code review.
Path: apps/agent/entrypoints/app/skills/SkillsPage.tsx
Line: 196-203
Comment:
**Icon-only links are missing `aria-label`**
The `<a>` element contains only a `HelpCircle` icon with no visible text. Screen readers will announce this as an unlabelled link. Adding `aria-label` makes the purpose clear to assistive technology. The same applies to the equivalent links added in `LlmProvidersHeader.tsx`, `ConnectMCP.tsx`, `LlmHubHeader.tsx`, `MemoryHeader.tsx`, and `SoulHeader.tsx`.
```suggestion
<a
href={skillsHelpUrl}
target="_blank"
rel="noopener noreferrer"
aria-label="Learn more about skills"
className="rounded-full p-1 text-muted-foreground transition-colors hover:bg-muted hover:text-foreground"
>
<HelpCircle className="h-4 w-4" />
</a>
```
How can I resolve this? If you propose a fix, please make it concise.Last reviewed commit: defcce8 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
productUrls.ts(replaces hardcoded URL in MCPServerHeader)Feature → Docs mapping
/features/skills/features/connect-mcps/features/memory/features/soul/features/bring-your-own-llm/features/llm-chat-hub/features/use-with-claude-codeTest plan
🤖 Generated with Claude Code