refactor(overlays): address S7059 async constructors in topic storage managers#104
Open
refactor(overlays): address S7059 async constructors in topic storage managers#104
Conversation
… managers Replace fire-and-forget async index creation in constructors with the `.ready: Promise<void>` pattern, extracting index setup into private async methods and parallelising independent createIndex calls via Promise.all. Covers all 14 affected storage managers across @bsv/overlay-topics and @bsv/btms-backend. Refs #38 #45. Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
createIndexcalls in 14 storage manager constructors with the.ready: Promise<void>pattern (S7059 fix)createIndices()/createSearchableIndex()method whose returned promise is assigned tothis.readycreateIndexcalls viaPromise.allin multi-index managers (Identity: 9 indices, KVStore: 5, BTMS: 3, TokenDemo: 2)Affected files across
@bsv/overlay-topicsand@bsv/btms-backend:IdentityStorageManager,KVStoreStorageManager,BTMSStorageManager(×2),DIDStorageManager,AppsStorageManager,TokenDemoStorage,AnyStorage,DesktopIntegrityStorage,FractionalizeStorage,HelloWorldStorage,MonsterBattleStorage,SlackThreadsStorage,SupplyChainStorageRefs #38 #45.
Test plan
pnpm --filter @bsv/overlay-topics run build— passes (21 suites, 232 passed, 1 skipped)pnpm --filter @bsv/overlay-topics run test— passespnpm --filter @bsv/btms-backend run build— passespnpm --filter @bsv/btms-backend run test— passes (43 tests)🤖 Generated with Claude Code