refactor(overlays): address S7059 async constructors in topic storage managers

packages/overlays/btms-backend/src/lookup-services/BTMSStorageManager.ts

@@ -7,27 +7,26 @@
  */
 export class BTMSStorageManager {
   private readonly records: Collection<BTMSRecord>
+  private indexInit?: Promise<void>
 
   /**
    * @param db A connected MongoDB database handle.
    */
   constructor (private readonly db: Db) {
     this.records = db.collection<BTMSRecord>('btmsRecords')
+  }
 
-    // Create index on assetId for efficient lookups
-    this.records
-      .createIndex({ assetId: 1 })
-      .catch(console.error)
-
-    // Create index on ownerKey for efficient lookups
-    this.records
-      .createIndex({ ownerKey: 1 })
-      .catch(console.error)
-
-    // Create compound index for txid and outputIndex (unique identifier)
-    this.records
-      .createIndex({ txid: 1, outputIndex: 1 }, { unique: true })
-      .catch(console.error)
+  private ensureIndexes (): Promise<void> {
+    if (this.indexInit === undefined) {
+      this.indexInit = (async () => {
+        await Promise.all([
+          this.records.createIndex({ assetId: 1 }),
+          this.records.createIndex({ ownerKey: 1 }),
+          this.records.createIndex({ txid: 1, outputIndex: 1 }, { unique: true })
+        ])
+      })()
+    }
+    return this.indexInit
   }
 
   /**
@@ -41,6 +40,7 @@
     ownerKey: PubKeyHex,
     metadata?: string
   ): Promise<void> {
+    await this.ensureIndexes()
     const record: BTMSRecord = {
       txid,
       outputIndex,
@@ -57,6 +57,7 @@
    * Remove a BTMS record identified by its UTXO.
    */
   async deleteRecord (txid: string, outputIndex: number): Promise<void> {
+    await this.ensureIndexes()
     await this.records.deleteOne({ txid, outputIndex })
   }
 
@@ -72,6 +73,7 @@
     skip: number = 0,
     sortOrder: 'asc' | 'desc' = 'desc'
   ): Promise<BTMSRecord[]> {
+    await this.ensureIndexes()
     const query: Record<string, unknown> = {}
 
     if (filters.assetId) {
@@ -93,13 +95,15 @@
     skip: number = 0,
     sortOrder: 'asc' | 'desc' = 'desc'
   ): Promise<BTMSRecord[]> {
+    await this.ensureIndexes()
     return await this.findRecordWithQuery({}, limit, skip, sortOrder)
   }
 
   /**
    * Find a specific record by txid and outputIndex.
    */
   async findByTxidOutputIndex (txid: string, outputIndex: number): Promise<BTMSRecord | null> {
+    await this.ensureIndexes()
     return await this.records.findOne({ txid, outputIndex })
   }
 

packages/overlays/topics/src/any/AnyStorage.ts

@@ -4,17 +4,23 @@
 // Implements a Lookup StorageEngine for Any
 export class AnyStorage {
   private readonly records: Collection<AnyRecord>
+  private indexInit?: Promise<void>
 
   constructor(private readonly db: Db) {
     this.records = db.collection<AnyRecord>('anyRecords')
-    this.createSearchableIndex()
   }
 
-  private async createSearchableIndex(): Promise<void> {
-    await this.records.createIndex({ txid: 1 }, { name: 'txidIndex' })
+  private ensureIndexes(): Promise<void> {
+    if (this.indexInit === undefined) {
+      this.indexInit = (async () => {
+        await this.records.createIndex({ txid: 1 }, { name: 'txidIndex' })
+      })()
+    }
+    return this.indexInit
   }
 
   async storeRecord(txid: string, outputIndex: number): Promise<void> {
+    await this.ensureIndexes()
     await this.records.insertOne({
       txid,
       outputIndex,
@@ -23,14 +29,17 @@
   }
 
   async spendRecord(txid: string, outputIndex: number, spendingTxid: string): Promise<void> {
+    await this.ensureIndexes()
     await this.records.updateOne({ txid, outputIndex }, { $set: { spendingTxid } })
   }
 
   async deleteRecord(txid: string, outputIndex: number): Promise<void> {
+    await this.ensureIndexes()
     await this.records.deleteOne({ txid, outputIndex })
   }
 
   async findByTxid(txid: string): Promise<UTXOReference | null> {
+    await this.ensureIndexes()
     if (!txid) return null
     return this.records.findOne(
       { txid },
@@ -45,6 +54,7 @@
     endDate?: Date,
     sortOrder: 'asc' | 'desc' = 'desc'
   ): Promise<UTXOReference[]> {
+    await this.ensureIndexes()
     const query: any = {}
     if (startDate || endDate) {
       query.createdAt = {}

packages/overlays/topics/src/apps/AppsStorageManager.ts

@@ -4,55 +4,73 @@
 
 export class AppsStorageManager {
   private readonly records: Collection<AppCatalogRecord>
+  private indexInit?: Promise<void>
 
   constructor(private readonly db: Db) {
     this.records = db.collection<AppCatalogRecord>('appsCatalogRecords')
-    this.records.createIndex({
-      'metadata.name': 'text',
-      'metadata.description': 'text',
-      'metadata.tags': 'text',
-      'metadata.domain': 'text'
-    }).catch(console.error)
+  }
+
+  private ensureIndexes(): Promise<void> {
+    if (this.indexInit === undefined) {
+      this.indexInit = (async () => {
+        await this.records.createIndex({
+          'metadata.name': 'text',
+          'metadata.description': 'text',
+          'metadata.tags': 'text',
+          'metadata.domain': 'text'
+        })
+      })()
+    }
+    return this.indexInit
   }
 
   async storeRecord(txid: string, outputIndex: number, metadata: PublishedAppMetadata): Promise<void> {
+    await this.ensureIndexes()
     await this.records.insertOne({ txid, outputIndex, metadata, createdAt: new Date() })
   }
 
   async deleteRecord(txid: string, outputIndex: number): Promise<void> {
+    await this.ensureIndexes()
     await this.records.deleteOne({ txid, outputIndex })
   }
 
   async findByDomain(domain: string, limit = 50, skip = 0, sortOrder: 'asc' | 'desc' = 'desc'): Promise<LookupFormula> {
+    await this.ensureIndexes()
     return this.findRecordWithQuery({ 'metadata.domain': domain }, limit, skip, sortOrder)
   }
 
   async findByPublisher(publisher: string, limit = 50, skip = 0, sortOrder: 'asc' | 'desc' = 'desc'): Promise<LookupFormula> {
+    await this.ensureIndexes()
     return this.findRecordWithQuery({ 'metadata.publisher': publisher }, limit, skip, sortOrder)
   }
 
   async findByOutpoint(outpoint: string): Promise<LookupFormula> {
+    await this.ensureIndexes()
     const [txid, indexStr] = outpoint.split('.')
     const outputIndex = Number(indexStr)
     if (!txid || Number.isNaN(outputIndex)) throw new Error('Invalid outpoint format')
     return this.findRecordWithQuery({ txid, outputIndex }, 1, 0, 'desc')
   }
 
   async findByNameFuzzy(partialName: string, limit = 50, skip = 0, sortOrder: 'asc' | 'desc' = 'desc'): Promise<LookupFormula> {
+    await this.ensureIndexes()
     const escaped = partialName.replaceAll(/[.*+?^${}()|[\]\\]/g, String.raw`\$&`)
     const regex = new RegExp(escaped, 'i')
     return this.findRecordWithQuery({ 'metadata.name': { $regex: regex } }, limit, skip, sortOrder)
   }
 
   async findByTags(tags: string[], limit = 50, skip = 0, sortOrder: 'asc' | 'desc' = 'desc'): Promise<LookupFormula> {
+    await this.ensureIndexes()
     return this.findRecordWithQuery({ 'metadata.tags': { $in: tags } }, limit, skip, sortOrder)
   }
 
   async findByCategory(category: string, limit = 50, skip = 0, sortOrder: 'asc' | 'desc' = 'desc'): Promise<LookupFormula> {
+    await this.ensureIndexes()
     return this.findRecordWithQuery({ 'metadata.category': category }, limit, skip, sortOrder)
   }
 
   async findAllApps(limit = 50, skip = 0, sortOrder: 'asc' | 'desc' = 'desc'): Promise<LookupFormula> {
+    await this.ensureIndexes()
     return this.findRecordWithQuery({}, limit, skip, sortOrder)
   }
 

packages/overlays/topics/src/btms/BTMSStorageManager.ts

@@ -7,27 +7,26 @@
  */
 export class BTMSStorageManager {
   private readonly records: Collection<BTMSRecord>
+  private indexInit?: Promise<void>
 
   /**
    * @param db A connected MongoDB database handle.
    */
   constructor (private readonly db: Db) {
     this.records = db.collection<BTMSRecord>('btmsRecords')
+  }
 
-    // Create index on assetId for efficient lookups
-    this.records
-      .createIndex({ assetId: 1 })
-      .catch(console.error)
-
-    // Create index on ownerKey for efficient lookups
-    this.records
-      .createIndex({ ownerKey: 1 })
-      .catch(console.error)
-
-    // Create compound index for txid and outputIndex (unique identifier)
-    this.records
-      .createIndex({ txid: 1, outputIndex: 1 }, { unique: true })
-      .catch(console.error)
+  private ensureIndexes (): Promise<void> {
+    if (this.indexInit === undefined) {
+      this.indexInit = (async () => {
+        await Promise.all([
+          this.records.createIndex({ assetId: 1 }),
+          this.records.createIndex({ ownerKey: 1 }),
+          this.records.createIndex({ txid: 1, outputIndex: 1 }, { unique: true })
+        ])
+      })()
+    }
+    return this.indexInit
   }
 
   /**
@@ -41,6 +40,7 @@
     ownerKey: PubKeyHex,
     metadata?: string
   ): Promise<void> {
+    await this.ensureIndexes()
     const record: BTMSRecord = {
       txid,
       outputIndex,
@@ -57,6 +57,7 @@
    * Remove a BTMS record identified by its UTXO.
    */
   async deleteRecord (txid: string, outputIndex: number): Promise<void> {
+    await this.ensureIndexes()
     await this.records.deleteOne({ txid, outputIndex })
   }
 
@@ -72,6 +73,7 @@
     skip: number = 0,
     sortOrder: 'asc' | 'desc' = 'desc'
   ): Promise<BTMSRecord[]> {
+    await this.ensureIndexes()
     const query: Record<string, unknown> = {}
 
     if (filters.assetId) {
@@ -93,13 +95,15 @@
     skip: number = 0,
     sortOrder: 'asc' | 'desc' = 'desc'
   ): Promise<BTMSRecord[]> {
+    await this.ensureIndexes()
     return await this.findRecordWithQuery({}, limit, skip, sortOrder)
   }
 
   /**
    * Find a specific record by txid and outputIndex.
    */
   async findByTxidOutputIndex (txid: string, outputIndex: number): Promise<BTMSRecord | null> {
+    await this.ensureIndexes()
     return await this.records.findOne({ txid, outputIndex })
   }
 

packages/overlays/topics/src/desktopintegrity/DesktopIntegrityStorage.ts

@@ -3,25 +3,33 @@
 
 export class DesktopIntegrityStorage {
   private readonly records: Collection<DesktopIntegrityRecord>
+  private indexInit?: Promise<void>
 
   constructor(private readonly db: Db) {
     this.records = db.collection<DesktopIntegrityRecord>('desktopIntegrityRecords')
-    this.createSearchableIndex()
   }
 
-  private async createSearchableIndex(): Promise<void> {
-    await this.records.createIndex({ fileHash: 1 }, { name: 'fileHashIndex' })
+  private ensureIndexes(): Promise<void> {
+    if (this.indexInit === undefined) {
+      this.indexInit = (async () => {
+        await this.records.createIndex({ fileHash: 1 }, { name: 'fileHashIndex' })
+      })()
+    }
+    return this.indexInit
   }
 
   async storeRecord(txid: string, outputIndex: number, fileHash: string): Promise<void> {
+    await this.ensureIndexes()
     await this.records.insertOne({ txid, outputIndex, fileHash, createdAt: new Date() })
   }
 
   async deleteRecord(txid: string, outputIndex: number): Promise<void> {
+    await this.ensureIndexes()
     await this.records.deleteOne({ txid, outputIndex })
   }
 
   async findByFileHash(fileHash: string, limit = 50, skip = 0, sortOrder: 'asc' | 'desc' = 'desc'): Promise<UTXOReference[]> {
+    await this.ensureIndexes()
     if (!fileHash) return []
     const direction = sortOrder === 'asc' ? 1 : -1
     const results = await this.records.find({ fileHash })
@@ -34,6 +42,7 @@
   }
 
   async findByTxid(txid: string, limit = 50, skip = 0, sortOrder: 'asc' | 'desc' = 'desc'): Promise<UTXOReference[]> {
+    await this.ensureIndexes()
     if (!txid) return []
     const direction = sortOrder === 'asc' ? 1 : -1
     const results = await this.records.find({ txid })
@@ -46,6 +55,7 @@
   }
 
   async findAll(limit = 50, skip = 0, startDate?: Date, endDate?: Date, sortOrder: 'asc' | 'desc' = 'desc'): Promise<UTXOReference[]> {
+    await this.ensureIndexes()
     const query: any = {}
     if (startDate || endDate) {
       query.createdAt = {}

packages/overlays/topics/src/did/DIDStorageManager.ts

@@ -5,25 +5,38 @@
 
 export class DIDStorageManager {
   private readonly records: Collection<DIDRecord>
+  private indexInit?: Promise<void>
 
   constructor(private readonly db: Db) {
     this.records = db.collection<DIDRecord>('didRecords')
-    this.records.createIndex({ searchableAttributes: 'text' }).catch((e) => console.error(e))
+  }
+
+  private ensureIndexes(): Promise<void> {
+    if (this.indexInit === undefined) {
+      this.indexInit = (async () => {
+        await this.records.createIndex({ searchableAttributes: 'text' })
+      })()
+    }
+    return this.indexInit
   }
 
   async storeRecord(txid: string, outputIndex: number, serialNumber: Base64String): Promise<void> {
+    await this.ensureIndexes()
     await this.records.insertOne({ txid, outputIndex, serialNumber, createdAt: new Date() })
   }
 
   async deleteRecord(txid: string, outputIndex: number): Promise<void> {
+    await this.ensureIndexes()
     await this.records.deleteOne({ txid, outputIndex })
   }
 
   async findByCertificateSerialNumber(serialNumber: Base64String): Promise<LookupFormula> {
+    await this.ensureIndexes()
     return await this.findRecordWithQuery({ serialNumber })
   }
 
   async findByOutpoint(outpoint: string): Promise<LookupFormula> {
+    await this.ensureIndexes()
     const [txid, outputIndexStr] = outpoint.split('.')
     const outputIndex = Number.parseInt(outputIndexStr, 10)
     if (!txid || Number.isNaN(outputIndex)) {