Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Fix release workflow #419

Closed
wants to merge 1 commit into from
Closed

chore: Fix release workflow #419

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 11 additions & 10 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,18 +42,23 @@ jobs:

- uses: oxidize-rb/actions/setup-ruby-and-rust@v1
with:
ruby-version: "3.3"
ruby-version: "3.3.5"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this should be necessary, but I don't know if it hurst either.

bundler-cache: true
cargo-cache: true
cargo-vendor: true
cache-version: v1-${{ matrix.ruby-platform }}

- uses: oxidize-rb/cross-gem-action@main
- uses: oxidize-rb/actions/cross-gem@v1
id: cross-gem
with:
version: latest
platform: ${{ matrix.ruby-platform }}
ruby-versions: ${{ join(fromJSON(needs.ci-data.outputs.result).stable-ruby-versions, ', ') }}

- uses: actions/upload-artifact@v4
with:
name: cross-gem-${{ matrix.platform }}
path: ${{ steps.cross-gem.outputs.gem-path }}

- name: Smoke gem install
if: matrix.ruby-platform == 'x86_64-linux' # GitHub actions architecture
run: |
Expand All @@ -71,18 +76,14 @@ jobs:

- uses: oxidize-rb/actions/setup-ruby-and-rust@v1
with:
ruby-version: "3.3"
ruby-version: "3.3.5"
bundler-cache: true
cargo-cache: true
cache-version: v1

# It seems that v4 is not compatible with how artifacts are uploaded by
# oxidize-rb/cross-gem-action. So this must stay as v3 until the issue
# below is fixed.
# See https://github.com/oxidize-rb/actions/issues/27, for more details.
- uses: actions/download-artifact@v3
- uses: actions/download-artifact@v4
with:
name: cross-gem
pattern: cross-gem-*

- name: Package source gem
run: bundle exec rake pkg:ruby
Expand Down
Loading