chore: Fix release workflow #419
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit attempts to address #418, which is currently blocking release. This change pretty much includes all the suggestions in the linked issue. Additionally, this change makes use of @actions/download-artifact@v4. Given that the new cross-gem action gives us control over how to upload the gem artifacts, download-artifact should now be compatible. It's also worth noting that download-artifact@v3 was deprecated on Nov 30th 2024 https://github.com/actions/download-artifact?tab=readme-ov-file#actionsdownload-artifact
saulecabrera
force-pushed
the
fix-release-workflow
branch
from
99397c6 to
9013904
Compare
jbourassa
reviewed
Jan 13, 2025
| @@ -42,18 +42,23 @@ jobs: | |||
|
|
|||
| - uses: oxidize-rb/actions/setup-ruby-and-rust@v1 | |||
| with: | |||
| ruby-version: "3.3" | |||
| ruby-version: "3.3.5" | |||
There was a problem hiding this comment.
I don't think this should be necessary, but I don't know if it hurst either.
Oh I totally missed that, in that case, I don't think there's anything fundamentally different in this version that would cause it to succeed. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit attempts to address
#418, which is currently blocking release. This change pretty much includes all the suggestions in the linked issue.
Additionally, this change makes use of @actions/download-artifact@v4. Given that the new cross-gem action gives us control over how to upload the gem artifacts, download-artifact should now be compatible. It's also worth noting that download-artifact@v3 was deprecated on Nov 30th 2024 https://github.com/actions/download-artifact?tab=readme-ov-file#actionsdownload-artifact