Refactor and generalize particle modeling #414
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbreue16
force-pushed
the
jb/dev
branch
2 times, most recently
from
ceb97b1 to
5f5e6fd
Compare
jbreue16
force-pushed
the
jb/dev
branch
2 times, most recently
from
bb857cd to
a55d1b3
Compare
This was referenced Jun 8, 2025
jbreue16
changed the title
jbreue16
force-pushed
the
jb/dev
branch
2 times, most recently
from
839af4e to
c9153ca
Compare
jbreue16
force-pushed
the
jb/dev
branch
2 times, most recently
from
a3b5747 to
2c3ddde
Compare
This commit adds binding and reactions to particle operator, outsourcing that functionality from the GRM_DG
Always recompute Jacobian in 1D unit if wantJac Fix linear solve of inlet Jacobian block in 1D column unit Add compression to AD Jacobian Implement function to check analytic Jacobian against AD during simulation Add exception for NPARTYPE = 0 but particle group exists
… class to derived class
This commit removes the GRM_DG and LRMP_DG unit operation implementations, which became part of the generalized COLUMN_MODEL_1D
…cleDiffusionOperator
19 tasks
Remove obsolete newStaticJac in 1Dunit
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This collection of PRs modularizes the particle model implementation and incorporates them into generalized unit operations.
TODO
unit_typespecification (which will still require the new particle interface exceptparticle_type)