Skip to content

Add FV particle diffusion operator #465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add FV particle diffusion operator #465

wants to merge 2 commits into from

Conversation

@jbreue16
Copy link
Contributor

@jbreue16 jbreue16 commented Aug 7, 2025 •
edited
Loading

todo

  • copy FV particle discretization from GRM_FV to new ParticleDiffusionOperatorFV and adapt to ParticleDiffusionOperatorBase interface
  • enable ParticleDiffusionOperatorFV in GeneralRateParticle
  • flip particle state
  • tests
    • num.ref: LRMP DG == GRM bulk DG par FV with nparcell = 1
    • GRM SMA LWE numref comparison with pure DG solution
    • GRM linear with surfDiff numRef
    • GRM linear with surfDiff Jacobian test
  • Warning for nParCell = 1, wrong use of model
  • sidequest todos: things that came up while working on this
    • tests infra: add a generalized discretization setter to allow mixed discretizations in tests
    • Reset Jacobian to zero every wantJac residual call
    • sensitivities?

@jbreue16 jbreue16 force-pushed the feature/dg2d branch 2 times, most recently from 2a5a005 to 762bc3a Compare August 8, 2025 12:40
jbreue16 added a commit that referenced this pull request Aug 8, 2025
@jbreue16
Add FV particle diffusion operator (#465)
ace16d2
jbreue16 added a commit that referenced this pull request Aug 8, 2025
@jbreue16
Add FV particle diffusion operator (#465)
38a3607
@jbreue16 jbreue16 force-pushed the feature/dg2d branch 14 times, most recently from c34f907 to 5899a91 Compare August 14, 2025 14:59
@jbreue16 jbreue16 mentioned this pull request Aug 14, 2025
Merged
12 tasks
@jbreue16 jbreue16 force-pushed the feature/dg2d branch 3 times, most recently from 4917d31 to 8b068a4 Compare August 18, 2025 20:18
jbreue16 added a commit that referenced this pull request Aug 19, 2025
@jbreue16
Add FV particle diffusion operator (#465)
036dc07 
Also makes field `SPATIAL_METHOD` in particle discretization mandatory
jbreue16 added a commit that referenced this pull request Aug 19, 2025
@jbreue16
Add FV particle diffusion operator (#465)
0a9a2d5 
Also makes field `SPATIAL_METHOD` in particle discretization mandatory
jbreue16 added a commit that referenced this pull request Aug 19, 2025
@jbreue16
Add FV particle diffusion operator (#465)
ea61fa8 
Also makes field `SPATIAL_METHOD` in particle discretization mandatory
@jbreue16 jbreue16 force-pushed the jb/dev branch 4 times, most recently from 143ff67 to 6191c90 Compare August 25, 2025 16:34
@jbreue16 jbreue16 mentioned this pull request Aug 25, 2025
Open
19 tasks
jbreue16 added a commit that referenced this pull request Aug 26, 2025
@jbreue16
Add FV particle diffusion operator (#465)
394d1a1 
Also makes field `SPATIAL_METHOD` in particle discretization mandatory
@jbreue16 jbreue16 force-pushed the jb/dev branch 3 times, most recently from 31930b9 to da9a50c Compare August 26, 2025 16:22
jbreue16 added a commit that referenced this pull request Aug 29, 2025
@jbreue16
Add FV particle diffusion operator (#465)
9587c1d 
Also makes field `SPATIAL_METHOD` in particle discretization mandatory
@jbreue16 jbreue16 self-assigned this Aug 29, 2025
@jbreue16 jbreue16 changed the base branch from jb/dev to master August 29, 2025 09:08
jbreue16 added a commit that referenced this pull request Aug 29, 2025
@jbreue16
Add FV particle diffusion operator (#465)
b9227d1 
Also makes field `SPATIAL_METHOD` in particle discretization mandatory
jbreue16 added a commit that referenced this pull request Aug 29, 2025
@jbreue16
Add FV particle diffusion operator (#465)
57809e4 
Also makes field `SPATIAL_METHOD` in particle discretization mandatory
@jbreue16 jbreue16 force-pushed the feature/dg2d branch 2 times, most recently from 57809e4 to 639b47c Compare August 29, 2025 14:02
@jbreue16
Add FV particle diffusion operator (#465)
639b47c 
Also makes field `SPATIAL_METHOD` in particle discretization mandatory
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@jbreue16 jbreue16

Labels

enhancement feature request numerics

Projects

CADET Repositories
Status: Todo

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jbreue16