[WIP] feat: expressjs framework #784
Conversation
yanksyoon
force-pushed
the
feat/expressjs-framework
branch
from
056fbc1 to
8afa87e
Compare
github-actions
bot
added
the
documentation
| You can use this key to specify any dependencies required for your ExpressJS | ||
| application. In the following example we use it to specify ``libpq-dev``: | ||
|
|
||
| .. code-block:: yaml | ||
| parts: | ||
| expressjs-framework/dependencies: | ||
| stage-packages: | ||
| # list required packages or slices for your ExpressJS application below. | ||
| - libpq-dev | ||
There was a problem hiding this comment.
There is a bug with installing any runtime dependencies (conflicting lib directory). See Matrix thread: https://matrix.to/#/!NPPCseDHKRvSBMUEXN:ubuntu.com/$upouJFvo8bjWS08ZNTe9yDtELNuVPh4qbs-ue3vEbbM?via=ubuntu.com&via=matrix.org
| - app/static | ||
| Some files/directories, if they exist, are included by default. These include: | ||
| ``<rock name>``, ``app.js``, ``migrate``, ``migrate.sh``, ``migrate.py``, |
There was a problem hiding this comment.
check migrate related files.
docs/tutorial/code/expressjs/app.js
Outdated
There was a problem hiding this comment.
This file is autogenerated by express-generator with the addition of the timeRouter for tutorial's sake.
There was a problem hiding this comment.
Generated by express-generator
There was a problem hiding this comment.
Generated by express-generator
There was a problem hiding this comment.
Generated by express-generator
There was a problem hiding this comment.
Add link to documentation on libs that are required on charm integrations (e.g. pg)
There was a problem hiding this comment.
Hi, I took a brief look at what's in the tutorial so far, and I left two comments.
I have some other comments that I excluded because they will affect all of the tutorials. I'd rather keep the set of tutorials consistent for now and update them all in one go.
Adds support for ExpressJS framework.
Key Decisions
bareand24.04only. Drop support for 22.04 (jammy)??operator commonly used in JS projects. This means that the projects initialized withexpress-generatortooling (assumed to be the case) would not work.expressjs-framework/install-app > stage-packagespart.expressjs-framework/runtimeexists to cater to apt packages, since slices and apt packages cannot be used together by design. See [wishlist] separate stage-packages and stage-slices #785.libdirectory of apt/slice installs. Remove the offering until the issue is resolved. See different contents or permissions error #790.npm-include-nodeandnpm-node-versionfields.app/directory.apppath (e.g. .env files)