Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] feat: expressjs framework #784
base: main
Are you sure you want to change the base?
[WIP] feat: expressjs framework #784
Changes from 36 commits
1bf14da
5d5b8ba
8afa87e
a887f00
be56040
91e87e9
9d9be67
cb84f17
0af6e6a
eacf0a1
dc787d0
98fbdd9
d7c51cd
b7a21a5
9233492
acc3c05
b6b9ca2
a1b5209
9a69970
f55e87b
544434b
6ba9c5a
82bbf94
582811b
650cab0
a25ea2a
dc3b61b
6e68078
024ea8e
685d9be
b900591
cea6fe4
b20ebea
a504403
f6d31a2
2a46cab
63b914d
c8d9ce5
c319aa2
a3c080a
dee32bf
24ae419
908581a
a5423c6
f33666f
37fa47c
c1c8e28
02675c7
c3af5c2
fd934b9
e3ea01b
3589757
752ce93
c145919
a90e80b
81c4abb
eca73e3
da5b5fe
4128d2d
0531361
b62355e
9c2dfb9
7f9aeb7
2ca47b2
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a bug with installing any runtime dependencies (conflicting lib directory). See Matrix thread: https://matrix.to/#/!NPPCseDHKRvSBMUEXN:ubuntu.com/$upouJFvo8bjWS08ZNTe9yDtELNuVPh4qbs-ue3vEbbM?via=ubuntu.com&via=matrix.org
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
check migrate related files.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file is autogenerated by
express-generator
with the addition of thetimeRouter
for tutorial's sake.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file is autogenerated by
express-generator
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we remove this? It should get auto generated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's change this to inject the new things that are required in the existing file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's have files with the snippets and include that in the tutorial and tell them to open the file with a code editor. Here, we will need to copy the contents into the existing file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps call the files
time_app_require.js
andtime_app_route.js
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've kept the file names
time.js
to match the route filenames of other frameworks and called the app filetime_app.js
. Would this approach sound reasonable?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Simple time route tutorial file.