-
Notifications
You must be signed in to change notification settings - Fork 244
RFC/WIP: Introduce capnp-json for JSON code compatible with c++ default capnproto implementation #600
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
puremourning
wants to merge
28
commits into
capnproto:master
Choose a base branch
from
puremourning:json-codec
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+5,821
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #600 +/- ##
==========================================
- Coverage 51.64% 50.98% -0.66%
==========================================
Files 69 76 +7
Lines 33735 34838 +1103
==========================================
+ Hits 17422 17762 +340
- Misses 16313 17076 +763 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
We simply write synchronously to a std::io::Write. The codec supports all types that the C++ codec supports, along with the flatten, hex and base64 annotations. It does not support discriminated unions yet. It supports only encode, no decode. It's not fast, efficient, or especially good.
…t schema from c++ repo
190c1f6 to
a3d6558
Compare
…bility with the c++ implementation... and fix the resulting bugs found
…rs with a discriminator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #68, I'm sharing this very rough cut of JSON codec support for input.
Some assumptions I made, which influenced the implementation, but could be changed depending on your view:
What's supported:
flatten,discriminator,namebase64,hexandarray of numbersencodings forDatafields.The best doc on the actual encoding is the json.capnp which is taken directly from upstream. We don't use all of it, but I kept it unmodified anyway.
What's not supported, and what deviates from the upstream implementation: