Skip to content

Conversation

@AlwaysNur
Copy link
Member

@AlwaysNur AlwaysNur commented Dec 9, 2025

kinda wip atm

@AlwaysNur AlwaysNur requested a review from uncenter as a code owner December 9, 2025 03:08
@AlwaysNur AlwaysNur added the 4.topic: libraries Relating to the standard library and/or library modules label Dec 9, 2025
@AlwaysNur AlwaysNur mentioned this pull request Dec 9, 2025
7 tasks
@AlwaysNur AlwaysNur added the 0.kind: meta Repository-wide issues label Dec 9, 2025
@nuexq
Copy link
Member

nuexq commented Dec 10, 2025

can you add --mui-palette-header-default variable?

@nuexq
Copy link
Member

nuexq commented Dec 10, 2025

and I don't think --mui-palette-background-default and --mui-palette-background-paper should be the same?

@AlwaysNur
Copy link
Member Author

AlwaysNur commented Dec 10, 2025

and I don't think --mui-palette-background-default and --mui-palette-background-paper should be the same?

I have been testing this on the Docker hub website, which has them the same.

But feel free to override it in the userstyle!

@AlwaysNur AlwaysNur requested a review from nuexq December 10, 2025 20:11
@AlwaysNur
Copy link
Member Author

Also, sorry I won't be available for a the next few days :0

@nuexq
Copy link
Member

nuexq commented Dec 10, 2025

can you add --mui-palette-header-default variable?

It seems it just got added to noogle.dev but its not a mui variable

@nuexq
Copy link
Member

nuexq commented Dec 14, 2025

I have a request to add a helper function similar to #__mui.override that accepts a name and a value. the function should generate two CSS variables:

  • --mui-palette-@{name}-main: @value.
  • --mui-palette-@{name}-mainChannel: .rgbify(@value) [].

Note: the mainChannel value should be a raw rgb wihtout commas.

@AlwaysNur
Copy link
Member Author

I have a request to add a helper function similar to #__mui.override that accepts a name and a value. the function should generate two CSS variables:

  • --mui-palette-@{name}-main: @value.
  • --mui-palette-@{name}-mainChannel: .rgbify(@value) [].

Note: the mainChannel value should be a raw rgb wihtout commas.

Okey, will get to this tmrw.

@AlwaysNur
Copy link
Member Author

@nuexq done

@WalkQuackBack WalkQuackBack added the 1.importance: on-roadmap Planned on the roadmap label Dec 27, 2025
Comment on lines +230 to +240
--mui-palette-@{name}-grey-50: @overlay1;
--mui-palette-@{name}-grey-100: @surface1;
--mui-palette-@{name}-grey-200: lighten(@surface2, 25%);
--mui-palette-@{name}-grey-300: lighten(@surface2, 15%);
--mui-palette-@{name}-grey-400: lighten(@surface2, 5%);
--mui-palette-@{name}-grey-500: @surface2;
--mui-palette-@{name}-grey-600: @text;
--mui-palette-@{name}-grey-700: @overlay1;
--mui-palette-@{name}-grey-800: darken(@surface2, 25%);
--mui-palette-@{name}-grey-900: @overlay1;
--mui-palette-@{name}-grey-950: darken(@surface2, 45%);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This scale doesn't really make sense to me. Why are we just modifying surface2? Let's use crust, mantle, base, surface0, surface1, surface2, overlay0, overlay1, overlay2, subtext0, subtext1, and text for these shades if possible. It is usually okay for two adjacent shades like grey-400 and grey-500 to have the same color too fwiw.

Comment on lines +109 to +118
--mui-palette-grey-50: #fafafa;
--mui-palette-grey-100: #f5f5f5;
--mui-palette-grey-200: #eeeeee;
--mui-palette-grey-300: #e0e0e0;
--mui-palette-grey-400: #bdbdbd;
--mui-palette-grey-500: #9e9e9e;
--mui-palette-grey-600: #757575;
--mui-palette-grey-700: #616161;
--mui-palette-grey-800: @surface0;
--mui-palette-grey-900: #212121;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is just one of these shades themed and why is there a separate util for this on lines 230-240?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some websites use --mui-palette-websitename-grey then there's the default --mui-palette-grey.

@uncenter uncenter added the 2.status: changes-requested Changes requested by reviewers must be attended to by author before further review label Dec 28, 2025
@WalkQuackBack WalkQuackBack removed the 0.kind: meta Repository-wide issues label Dec 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1.importance: on-roadmap Planned on the roadmap 2.status: changes-requested Changes requested by reviewers must be attended to by author before further review 4.topic: libraries Relating to the standard library and/or library modules

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants