-
-
Notifications
You must be signed in to change notification settings - Fork 255
feat: mui lib #2020
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: mui lib #2020
Conversation
|
can you add |
|
and I don't think |
I have been testing this on the Docker hub website, which has them the same. But feel free to override it in the userstyle! |
|
Also, sorry I won't be available for a the next few days :0 |
It seems it just got added to noogle.dev but its not a mui variable |
|
I have a request to add a helper function similar to
Note: the |
Okey, will get to this tmrw. |
|
@nuexq done |
| --mui-palette-@{name}-grey-50: @overlay1; | ||
| --mui-palette-@{name}-grey-100: @surface1; | ||
| --mui-palette-@{name}-grey-200: lighten(@surface2, 25%); | ||
| --mui-palette-@{name}-grey-300: lighten(@surface2, 15%); | ||
| --mui-palette-@{name}-grey-400: lighten(@surface2, 5%); | ||
| --mui-palette-@{name}-grey-500: @surface2; | ||
| --mui-palette-@{name}-grey-600: @text; | ||
| --mui-palette-@{name}-grey-700: @overlay1; | ||
| --mui-palette-@{name}-grey-800: darken(@surface2, 25%); | ||
| --mui-palette-@{name}-grey-900: @overlay1; | ||
| --mui-palette-@{name}-grey-950: darken(@surface2, 45%); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This scale doesn't really make sense to me. Why are we just modifying surface2? Let's use crust, mantle, base, surface0, surface1, surface2, overlay0, overlay1, overlay2, subtext0, subtext1, and text for these shades if possible. It is usually okay for two adjacent shades like grey-400 and grey-500 to have the same color too fwiw.
| --mui-palette-grey-50: #fafafa; | ||
| --mui-palette-grey-100: #f5f5f5; | ||
| --mui-palette-grey-200: #eeeeee; | ||
| --mui-palette-grey-300: #e0e0e0; | ||
| --mui-palette-grey-400: #bdbdbd; | ||
| --mui-palette-grey-500: #9e9e9e; | ||
| --mui-palette-grey-600: #757575; | ||
| --mui-palette-grey-700: #616161; | ||
| --mui-palette-grey-800: @surface0; | ||
| --mui-palette-grey-900: #212121; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is just one of these shades themed and why is there a separate util for this on lines 230-240?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some websites use --mui-palette-websitename-grey then there's the default --mui-palette-grey.
kinda wip atm