Skip to content

Conversation

@anselmbradford
Copy link
Member

@anselmbradford anselmbradford commented Apr 24, 2024

Some follow up to #1919

Changes

  • Update modifier name to correct BEM naming.
  • Remove unused content-l_col__before-divider
  • Update @heading variables to use dashes.

Testing

  1. PR checks should pass. Check the block helper text in the PR preview. It should wrap to its own line https://cfpb.github.io/design-system/components/helper-text#block-helper-text

@netlify
Copy link

netlify bot commented Apr 24, 2024

Thanks for the improvements! Browse a preview of your changes using the link below.

Name Link
🔨 Latest commit 0c6008d
🔍 Latest deploy log https://app.netlify.com/sites/cfpb-design-system/deploys/66294f3260225a0008985382
😎 Deploy Preview https://deploy-preview-1963--cfpb-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@contolini contolini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anselmbradford anselmbradford merged commit b4501db into main Apr 24, 2024
@anselmbradford anselmbradford deleted the ans_bem_fixes branch April 24, 2024 18:55
@anselmbradford anselmbradford added the lerna-changelog/bug lerna label. DO NOT MODIFY label Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lerna-changelog/bug lerna label. DO NOT MODIFY

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants