Skip to content

BEM fixes #1963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 24, 2024
Merged

BEM fixes #1963

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions docs/pages/fieldsets.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ variation_groups:
<legend class="a-legend">

Basic legend
<small class="a-label__helper a-label__helper__block">Use block helper text for instructions</small>
<small class="a-label__helper a-label__helper--block">Use block helper text for instructions</small>
</legend>
<div class="o-form__group">
<fieldset class="o-form__fieldset">
Expand All @@ -46,7 +46,7 @@ variation_groups:
<legend class="a-legend">

Basic legend
<small class="a-label__helper a-label__helper__block">Use block helper text for instructions</small>
<small class="a-label__helper a-label__helper--block">Use block helper text for instructions</small>
</legend>
<div class="o-form__group">
<fieldset class="o-form__fieldset">
Expand Down Expand Up @@ -74,7 +74,7 @@ variation_groups:
<legend class="a-legend">

Basic legend
<small class="a-label__helper a-label__helper__block">Use block helper text for instructions</small>
<small class="a-label__helper a-label__helper--block">Use block helper text for instructions</small>
</legend>
<div class="o-form__group">
<fieldset class="o-form__fieldset">
Expand Down Expand Up @@ -104,7 +104,7 @@ variation_groups:
<legend class="a-legend">

Basic legend
<small class="a-label__helper a-label__helper__block">Use block helper text for instructions</small>
<small class="a-label__helper a-label__helper--block">Use block helper text for instructions</small>
</legend>

<div class="m-form-field m-form-field--radio m-form-field--lg-target">
Expand Down
2 changes: 1 addition & 1 deletion docs/pages/helper-text.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ variation_groups:
<label class="a-label a-label--heading" for="helper-block-example">

Label
<small class="a-label__helper a-label__helper__block">Use block helper text for instructions</small>
<small class="a-label__helper a-label__helper--block">Use block helper text for instructions</small>
</label>


Expand Down
2 changes: 1 addition & 1 deletion docs/pages/heroes.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,7 @@ variation_groups:
variation_implementation: >+
#### Bleeding illustrations

When using an illustration that bleeds top to bottom at larger screen sizes, add the `__bleeding` modifier to the hero and add an additional `m-hero_bleeding-image` as a sibling to `m-hero__image`.
When using an illustration that bleeds top to bottom at larger screen sizes, add the `--bleeding` modifier to the hero and add an additional `m-hero__bleeding-image` as a sibling to `m-hero__image`.


#### Customizing illustrations
Expand Down
4 changes: 2 additions & 2 deletions docs/pages/variables.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -290,8 +290,8 @@ variation_groups:
// Headings

// .a-heading__icon
@heading__icon: var(--black);
@heading__icon__hover: @link-text-hover;
@heading-icon: var(--black);
@heading-icon-hover: @link-text-hover;

// Headers

Expand Down
4 changes: 2 additions & 2 deletions packages/cfpb-forms/usage.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,13 +153,13 @@ Appears with labels and label headings.

<label class="a-label a-label--heading">
A label heading
<small class="a-label__helper a-label__helper__block">Helper text</small>
<small class="a-label__helper a-label__helper--block">Helper text</small>
</label>

```html
<label class="a-label a-label--heading">
A label heading
<small class="a-label__helper a-label__helper__block">Helper text</small>
<small class="a-label__helper a-label__helper--block">Helper text</small>
</label>
```

Expand Down
14 changes: 7 additions & 7 deletions packages/cfpb-layout/usage.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -612,7 +612,7 @@ overlapping since they will span the height of the entire `.content-l` element.
<br>
Half-width column (spans 6/12 columns)
</div>
<div class="content-l__col content-l__col-1-2 content-l__col__before-divider">
<div class="content-l__col content-l__col-1-2">
<img src="https://dummyimage.com/600x320/addc91/101820" alt="Placeholder image">
<br>
Half-width column (spans 6/12 columns)
Expand All @@ -623,10 +623,10 @@ overlapping since they will span the height of the entire `.content-l` element.
<div class="content-l__col content-l__col-1-3">
Third-width column (spans 4/12 columns)
</div>
<div class="content-l__col content-l__col-1-3 content-l__col__before-divider">
<div class="content-l__col content-l__col-1-3">
Third-width column (spans 4/12 columns)
</div>
<div class="content-l__col content-l__col-1-3 content-l__col__before-divider">
<div class="content-l__col content-l__col-1-3">
Third-width column (spans 4/12 columns)
</div>
</div>
Expand All @@ -638,24 +638,24 @@ overlapping since they will span the height of the entire `.content-l` element.
<br>
Half-width column (spans 6/12 columns)
</div>
<div class="content-l__col content-l__col-1-2 content-l__col__before-divider">
<div class="content-l__col content-l__col-1-2">
<img src="https://dummyimage.com/600x320/addc91/101820" alt="Placeholder image">
<br>
Half-width column (spans 6/12 columns)
</div>
</div>
<br>
<!-- Starting a new .content-l so that the dividers from
.content-l__col.content-l__col-1-2.content-l__col__before-divider
.content-l__col.content-l__col-1-2
won't overlap the .content-l__col-1-3 columns. -->
<div class="content-l">
<div class="content-l__col content-l__col-1-3">
Third-width column (spans 4/12 columns)
</div>
<div class="content-l__col content-l__col-1-3 content-l__col__before-divider">
<div class="content-l__col content-l__col-1-3">
Third-width column (spans 4/12 columns)
</div>
<div class="content-l__col content-l__col-1-3 content-l__col__before-divider">
<div class="content-l__col content-l__col-1-3">
Third-width column (spans 4/12 columns)
</div>
</div>
Expand Down
4 changes: 2 additions & 2 deletions packages/cfpb-typography/src/atoms/headings.less
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
.a-heading__icon {
.heading-4();

color: @heading__icon;
color: @heading-icon;

a& {
.u-link--colors( @heading__icon, @heading__icon__hover );
.u-link--colors( @heading-icon, @heading-icon-hover );

border-width: 0;
}
Expand Down
4 changes: 2 additions & 2 deletions packages/cfpb-typography/src/cfpb-typography.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,8 @@
// Headings

// .a-heading__icon
@heading__icon: var(--black);
@heading__icon__hover: @link-text-hover;
@heading-icon: var(--black);
@heading-icon-hover: @link-text-hover;

// Headers

Expand Down
4 changes: 2 additions & 2 deletions packages/cfpb-typography/usage.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,8 +57,8 @@ Color variables referenced in comments are from [@cfpb/cfpb-core's brand-colors.
// Headings

// .a-heading__icon
@heading__icon: var(--black);
@heading__icon__hover: @link-text-hover;
@heading-icon: var(--black);
@heading-icon-hover: @link-text-hover;

// Headers

Expand Down