Fix issue 1811 -- Version 2

[kphillisjr]

This implements the changes required to fix issue #1811. There is only two changes and this ensures that ch runs correctly after on Linux/OSX.

Also, this pull request is branched off of another pull request ( see: #2111 )

NOTE: The only change between this version and the other is that the DynamicProfileStorage change is only applied to xplat.

[msftclas]

Hi @kphillisjr, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!

The agreement was validated by Microsoft and real humans are currently evaluating your PR.

TTYL, MSBOT;

[obastemur]

@kphillisjr could you please point me the part that fixes #1811 ? In other words, why we are doing these changes?

[kphillisjr]

The commit two commits specific to issue #1811 are 75182f3 and b45d0b5. However the rest of the commits are for the earlier pull request (#2111) which is in regards to issue #1616.

EDIT: It took longer to better explain the changes since I thought I had a decent explanation to begin with. In general the current solution for issue #1811 is a byproduct of attempting to fully resolve issue #1616. Currently I have the Following fixed in regards to issue #1616 by this pull request...

• Simplify CMake Emdedding of Shared Libraries( 68beb62, f956ed2, andhttps://github.com/Fix issue 1811 -- Version 2 #2124/commits/7d49290aa8f83bad4437f08dceaac37bdb1a327d ) - all of these Commits are part of pull Cmake Automatic Configuration #2111, and is intended to improve the situation outlined by issue Feature Request: Enable ChakraCore embedding using CMake. #1616. In general one should be able to properly build ChakraCore using add_subdirectory since there is cases where individuals do not wish to use the System library for ChakraCore. All that is left in this is to Simplify Static Library Creation, and copy the ChakraCore headers to a better location post build.

• Fix issue xplat: Make shared library usage requirements more reasonable #1811 ( 75182f3 ) - This fixes the shared library dependencies on xplat by making it to where you do not need to call DllMain. However this introduced a bug in ch running debug builds.

• Fix issue caused by the fix of issue xplat: Make shared library usage requirements more reasonable #1811 ( b45d0b5) - The Issue that developed was that the shared debug build was broken by the above fix. This applies a trivial preprocessor solution that just removes the assert that lead to the failure in the first place. Without this patch the shared debug library for xplat would be broken.

What is left to Fix for issue #1616 is as follows...

• Simplify static linking of ChakraCore using CMake.
• Automatically Copy ChakraCore Headers to a better Location that will help prevent excessive header exposure outside the ChakraCore environment.
• Improve automatic Detection of libunwind on xplat.
• Improve automatic Detection of libuuid on xplat
• Add option to disable building of optional ChakraCore elements - This is currently GCStress, and ch on xplat.
• Implement support of building ChakraCore using CMake and MSVC.

[obastemur]

@kphillisjr I do really appreciate the overall effort.

Simplify static linking of ChakraCore using CMake.
Automatically Copy ChakraCore Headers to a better Location that will help prevent excessive header exposure outside the ChakraCore environment.

From these two, we could use a solution like this; After build is done, copy header files to BuildLinux/<BUILD_TYPE>/include folder.

Feel free to send a single commit PR only doing this. You may even create a Github issue on this particular issue and send a PR separately fixing that issue.

Improve automatic Detection of libunwind on xplat.
Improve automatic Detection of libuuid on xplat

We already removed our dependency to libunwind. We may approach libuuid in a similar manner. So, we better skip this.

Add option to disable building of optional ChakraCore elements - This is currently GCStress, and ch on xplat.

IMO; We may need to skip this (too) for now as it kinda complicates the number of build arguments.

Implement support of building ChakraCore using CMake and MSVC.

We have so many differences between Windows and Xplat builds. IMO msbuild works really good with Visual Studio sln files. If we could have a batch file similar to build.sh on Windows, that could be nice to have. We could use msbuild with that batch file. I was planning to contribute this as a weekend fun but if you are into doing so, go ahead!

something like;

build.bat /--test-build/--debug/--release/ --arch=x86/amd64/ARM 

Actually we could combine batch file and sh file and have a single file instead of build.bat and build.sh separately. There are couple of ways to trigger either Windows or Bash specific command set under the same file. This one is not that critical, once we have the build.bat is contributed, I can also combine them later.

Thanks again.

[obastemur]

#2575 (comment)