Improve code repetition #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Trace, Console no longer singletons since Trace and Console are thread-safe by default * Responsibility for formatting stack traces moved to ILogFormatter * Added an ILog method for stack traces with contextual messages so they will be written together * Marked writers as excluded from coverage since they're largely untestable * Updated readme with latest
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Substantial amounts of code repetition were present in various
ILogtypes provided by the package. This change provides oneLogtype implementingILogand moves responsibility for directing messages to different outputs to theILogWritertypes (Console,Trace, andFile), reducing code repetition. Additionally, responsibility for formatting stack trace messages is moved toILogFormatter. Tests and readme are adjusted accordingly.Additionally, the
ILogWriterimplementations are marked as excluded from code coverage, as they are, for the most part: