-
Notifications
You must be signed in to change notification settings - Fork 5
V9.0.7/service pack #124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
V9.0.7/service pack #124
Changes from all commits
69c43b7
459099a
4c89db7
bb717b5
9dccefe
227ec0c
16b039a
76a6bfe
adebabb
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -84,7 +84,7 @@ jobs: | |
| restore-cache-key: ${{ needs.prepare_linux.outputs.restore-cache-key }} | ||
|
|
||
| test_linux: | ||
| name: call-test | ||
| name: call-test-linux | ||
| needs: [build, prepare_test, prepare_linux] | ||
| strategy: | ||
| fail-fast: false | ||
|
|
@@ -99,7 +99,7 @@ jobs: | |
| restore-cache-key: ${{ needs.prepare_linux.outputs.restore-cache-key }} | ||
|
|
||
| test_windows: | ||
| name: call-test | ||
| name: call-test-windows | ||
| needs: [build, prepare_test] | ||
| strategy: | ||
| fail-fast: false | ||
|
|
@@ -178,7 +178,7 @@ jobs: | |
| sonarcloud: | ||
| name: call-sonarcloud | ||
| needs: [build, test_linux, test_windows, integration_test] | ||
| uses: codebeltnet/jobs-sonarcloud/.github/workflows/default.yml@v1 | ||
| uses: codebeltnet/jobs-sonarcloud/.github/workflows/default.yml@v2 | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 💡 Verification agent 🧩 Analysis chainWorkflow version upgrade may introduce breaking changes. The upgrade from 🏁 Script executed: #!/bin/bash
# Description: Check for any breaking changes or new requirements in the SonarCloud workflow v2
# Search for any documentation or changelog references to v2 breaking changes
rg -i "breaking|deprecated|removed" --type md -A 5 -B 5 | grep -i "sonar\|v2"Length of output: 221 🏁 Script executed: #!/bin/bash
# Clone the SonarCloud jobs repository and diff the v1 vs v2 default workflows
set -e
# Clean up any previous runs
rm -rf sonar-jobs default_v1.yml default_v2.yml
# Clone the repo
git clone https://github.com/codebeltnet/jobs-sonarcloud.git sonar-jobs
cd sonar-jobs
# Fetch tags and capture v1 workflow
git fetch --tags
git checkout v1
cp .github/workflows/default.yml ../default_v1.yml
# Capture v2 workflow
git checkout v2
cp .github/workflows/default.yml ../default_v2.yml
cd ..
# Show the diff (exit code 0 or 1 is okay)
diff -u default_v1.yml default_v2.yml || trueLength of output: 3527 Validate and Adapt SonarCloud Workflow Upgrade to v2 Several inputs and defaults have changed in the v2 workflow—please update your pipeline invocation accordingly:
Locations to update in .github/workflows/pipelines.yml (around line 181): uses: codebeltnet/jobs-sonarcloud/.github/workflows/default.yml@v2
with:
# add or rename inputs here:
include-preview: true # if needed
host: ${{ inputs.host }} # optional override
parameters: ${{ inputs.parameters }} # include your sources/tests flagsPlease review these changes and test your workflow to confirm nothing breaks. 🤖 Prompt for AI Agents |
||
| with: | ||
| organization: geekle | ||
| projectKey: Cuemon | ||
|
|
@@ -198,7 +198,9 @@ jobs: | |
| codeql: | ||
| name: call-codeql | ||
| needs: [build, test_linux, test_windows, integration_test] | ||
| uses: codebeltnet/jobs-codeql/.github/workflows/default.yml@v1 | ||
| uses: codebeltnet/jobs-codeql/.github/workflows/default.yml@v2 | ||
| with: | ||
| timeout-minutes: 30 | ||
| permissions: | ||
| security-events: write | ||
|
|
||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Avoid pulling the same NGINX image twice – reuse the
basestageThe
basestage already fetchesnginx:${NGINX_VERSION}and strips the default html directory. Thefinalstage re-pulls the identical image, duplicating layers and network I/O. You can reuse the cleaned image by derivingfinaldirectly frombase:This keeps the layer cache tight and speeds up builds, especially in CI.
Also applies to: 13-14
🤖 Prompt for AI Agents