V9.0.7/service pack #124
V9.0.7/service pack #124
Conversation
…*** sake, Microsoft: dotnet/SqlClient#3115)
…oduced with .NET 10)
WalkthroughThis update replaces all usages of the deprecated System.Data.SqlClient package with Microsoft.Data.SqlClient, updates and reorganizes several NuGet package dependencies by target framework, and adds new release notes for version 9.0.7. It also parameterizes the nginx version in the DocFX Dockerfile and refines CI workflow job naming and workflow versions. Changes
Sequence Diagram(s)sequenceDiagram
participant App
participant Cuemon.Data.SqlClient
participant Microsoft.Data.SqlClient
App->>Cuemon.Data.SqlClient: Use SqlDataManager/SqlInOperator
Cuemon.Data.SqlClient->>Microsoft.Data.SqlClient: Execute SQL operations
Microsoft.Data.SqlClient-->>Cuemon.Data.SqlClient: Return results/exceptions
Cuemon.Data.SqlClient-->>App: Provide data or errors
Possibly related PRs
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 6
🔭 Outside diff range comments (1)
src/Cuemon.Data.SqlClient/Cuemon.Data.SqlClient.csproj (1)
8-19: Update package description and lock package version
Microsoft.Data.SqlClientis now the primary dependency, yet the<Description>text still references System.Data.SqlClient.- No version is pinned for
Microsoft.Data.SqlClient; leaving it floating can introduce breaking changes on the next major release.- <Description>The Cuemon.Data.SqlClient namespace contains types that provide ways for developers to work with Microsoft SQL Server integrations. The namespace is an addition to the System.Data.SqlClient namespace.</Description> + <Description>The Cuemon.Data.SqlClient namespace contains helpers for Microsoft SQL Server integrations, building on the official Microsoft.Data.SqlClient library.</Description> @@ - <PackageReference Include="Microsoft.Data.SqlClient" /> + <!-- Keep central-package-management if used; otherwise pin an explicit version --> + <PackageReference Include="Microsoft.Data.SqlClient" Version="5.2.0" />If the repo relies on
Directory.Packages.propsfor versioning, addVersion=""there instead and keep this entry version-less.
♻️ Duplicate comments (11)
.nuget/Cuemon.Extensions.Threading/PackageReleaseNotes.txt (1)
1-6: Same Oxford-comma / tone refinements as noted earlier
See previous comment for the suggested wording tweaks; applying them here keeps all release-note files uniform..nuget/Cuemon.Extensions.DependencyInjection/PackageReleaseNotes.txt (1)
1-6: Replicate the earlier release-note polish
Apply the Oxford comma and replace “latest and greatest” phrasing for consistency..nuget/Cuemon.Extensions.Data/PackageReleaseNotes.txt (1)
1-6: Mirror the grammatical corrections raised in the first file
Ensures uniform quality across all package release notes..nuget/Cuemon.Extensions.Data.Integrity/PackageReleaseNotes.txt (1)
1-6: Apply the same minor copy-editing fixes
Refer to the initial comment for exact wording changes..nuget/Cuemon.Extensions.AspNetCore.Xml/PackageReleaseNotes.txt (1)
5-5: Same copy-edit as noted in Cuemon.Core release notesSee the wording/grammar suggestion provided for
.nuget/Cuemon.Core/PackageReleaseNotes.txt..nuget/Cuemon.Data.SqlClient/PackageReleaseNotes.txt (1)
2-5: Same copy-edit as noted in Cuemon.Core release notesSee the wording/grammar suggestion provided for
.nuget/Cuemon.Core/PackageReleaseNotes.txt..nuget/Cuemon.Core.App/PackageReleaseNotes.txt (1)
2-5: Same copy-edit as noted in Cuemon.Core release notesSee the wording/grammar suggestion provided for
.nuget/Cuemon.Core/PackageReleaseNotes.txt..nuget/Cuemon.AspNetCore/PackageReleaseNotes.txt (1)
5-5: Same copy-edit as noted in Cuemon.Core release notesSee the wording/grammar suggestion provided for
.nuget/Cuemon.Core/PackageReleaseNotes.txt..nuget/Cuemon.Resilience/PackageReleaseNotes.txt (1)
1-6: Same style/grammar tweaks as suggested for the first release-notes file
Apply the same Oxford-comma and wording adjustments here for consistency..nuget/Cuemon.Extensions.Diagnostics/PackageReleaseNotes.txt (1)
1-6: Repeat of release-notes wording issue
Mirror the earlier revision to keep wording and tone uniform across packages..nuget/Cuemon.Extensions.Net/PackageReleaseNotes.txt (1)
1-6: Repeat of release-notes wording issue
Apply the same stylistic fix here as well.
🧹 Nitpick comments (43)
src/Cuemon.Extensions.DependencyInjection/ServiceProviderExtensions.cs (1)
18-18: Clarify XML-doc exception messageThe placeholder
{providerType.FullName}will be rendered verbatim in generated documentation, which may confuse consumers. Consider rewriting the summary to describe the condition rather than the runtime value.-/// <exception cref="NotSupportedException">This method does not support {providerType.FullName}.</exception> +/// <exception cref="NotSupportedException"> +/// Thrown when the underlying <paramref name="provider"/> implementation is not supported by the current reflection-based discovery logic. +/// </exception>.docfx/Dockerfile.docfx (1)
1-1: Great to see NGINX version parameterized – consider documenting the build-arg in README/CI
IntroducingARG NGINX_VERSIONimproves maintainability. A tiny follow-up nit: add a note in the README or build workflow so consumers know they can override this value (e.g.,docker build --build-arg NGINX_VERSION=1.29.1-alpine).testenvironments.json (1)
10-13: Consider parameterizing the image tagHard-coding the full version string makes bulk upgrades noisy.
A small template mechanism (e.g.,${{ env.TESTRUNNER_TAG }}in workflows or a JSON include) would reduce churn and simplify mass version bumps.test/Cuemon.Core.Tests/Threading/AwaiterTest.cs (1)
120-120: Timeout increase is justified for CI environments.The timeout increase from 50ms to 5 seconds is reasonable for CI environments, though it makes the test slower. The comment clearly explains the rationale for this change.
Consider if there are ways to make this configurable or use environment-specific timeouts to keep local test runs fast while accommodating slower CI environments.
.nuget/Cuemon.Extensions.AspNetCore/PackageReleaseNotes.txt (1)
1-6: Tone & grammar: avoid marketing-like “latest and greatest”Release notes typically adopt a concise, neutral wording.
Consider replacing the phrase and trimming superfluous words.-# ALM -- CHANGED Dependencies to latest and greatest with respect to TFMs +# ALM +- UPDATED dependencies to the latest versions for all supported TFMs.nuget/Cuemon.AspNetCore.App/PackageReleaseNotes.txt (1)
1-6: Consistent wording across packagesOther Cuemon packages use “UPDATED dependencies …”.
Recommend aligning this file for consistency:-# ALM -- CHANGED Dependencies to latest and greatest with respect to TFMs +# ALM +- UPDATED dependencies to the latest versions for all supported TFMs.nuget/Cuemon.Extensions.AspNetCore.Mvc.Formatters.Xml/PackageReleaseNotes.txt (1)
1-6: Nit: neutral phrasing & minor copy-editSame wording improvement as in sibling packages.
-# ALM -- CHANGED Dependencies to latest and greatest with respect to TFMs +# ALM +- UPDATED dependencies to the latest versions for all supported TFMs.nuget/Cuemon.Extensions.AspNetCore.Mvc.RazorPages/PackageReleaseNotes.txt (1)
1-6: Uniform change log styleFor a clean changelog, apply the standard wording used elsewhere:
-# ALM -- CHANGED Dependencies to latest and greatest with respect to TFMs +# ALM +- UPDATED dependencies to the latest versions for all supported TFMs.nuget/Cuemon.Extensions.Xml/PackageReleaseNotes.txt (1)
1-6: Minor language polishAdopt the same neutral, consistent wording:
-# ALM -- CHANGED Dependencies to latest and greatest with respect to TFMs +# ALM +- UPDATED dependencies to the latest versions for all supported TFMsAlso consider adding an Oxford comma for clarity in line 2:
-Availability: .NET 9, .NET 8 and .NET Standard 2.0 +Availability: .NET 9, .NET 8, and .NET Standard 2.0.nuget/Cuemon.Data.Integrity/PackageReleaseNotes.txt (1)
1-6: Grammar & style touch-ups will improve professionalismMinor editorial nits:
- Add the Oxford comma for consistency in list formatting.
- Trim the marketing-like “latest and greatest” phrasing; it reads informal in release notes.
-Availability: .NET 9, .NET 8 and .NET Standard 2.0 +Availability: .NET 9, .NET 8, and .NET Standard 2.0 - - CHANGED Dependencies to latest and greatest with respect to TFMs +- CHANGED Dependencies to the latest versions for all supported TFMs.nuget/Cuemon.Extensions.Text/PackageReleaseNotes.txt (1)
1-5: Tighten wording and apply serial-comma on availability lineMinor stylistic touches improve readability and match the phrasing used across other OSS release notes:
-Version 9.0.7 -Availability: .NET 9, .NET 8 and .NET Standard 2.0 +Version 9.0.7 +Availability: .NET 9, .NET 8, and .NET Standard 2.0 @@ -# ALM -- CHANGED Dependencies to latest and greatest with respect to TFMs +# ALM +- UPDATED dependencies to the latest versions for their respective TFMs.nuget/Cuemon.Extensions.IO/PackageReleaseNotes.txt (1)
1-5: Consistency/grammar nits identical to previous fileSame tweaks for serial-comma and concise wording:
-Availability: .NET 9, .NET 8, .NET Standard 2.1 and .NET Standard 2.0 +Availability: .NET 9, .NET 8, .NET Standard 2.1, and .NET Standard 2.0 @@ -- CHANGED Dependencies to latest and greatest with respect to TFMs +- UPDATED dependencies to the latest versions for their respective TFMs.nuget/Cuemon.IO/PackageReleaseNotes.txt (1)
1-5: Release-note polishRepeating the polishing pass:
-Availability: .NET 9, .NET 8, .NET Standard 2.1 and .NET Standard 2.0 +Availability: .NET 9, .NET 8, .NET Standard 2.1, and .NET Standard 2.0 @@ -- CHANGED Dependencies to latest and greatest with respect to TFMs +- UPDATED dependencies to the latest versions for their respective TFMs.nuget/Cuemon.Extensions.AspNetCore.Authentication/PackageReleaseNotes.txt (1)
1-5: Tidy up wording and invisible spacing
Minor polish helps downstream readers and keeps changelogs searchable.-Version 9.0.7 -Availability: .NET 9 and .NET 8 - -# ALM -- CHANGED Dependencies to latest and greatest with respect to TFMs +Version 9.0.7 +Availability: .NET 9 and .NET 8 + +# ALM +- CHANGED Dependencies to the latest versions for each TFMThere are also non-breaking spaces on blank lines – consider replacing them with regular line feeds.
.nuget/Cuemon.Extensions.AspNetCore.Text.Json/PackageReleaseNotes.txt (1)
1-5: Apply the same wording/whitespace cleanup as in the other release notes-Version 9.0.7 -Availability: .NET 9 and .NET 8 - -# ALM -- CHANGED Dependencies to latest and greatest with respect to TFMs +Version 9.0.7 +Availability: .NET 9 and .NET 8 + +# ALM +- CHANGED Dependencies to the latest versions for each TFM.nuget/Cuemon.Extensions.AspNetCore.Mvc/PackageReleaseNotes.txt (1)
5-5: Re-phrase the ALM bullet for clarity and concisenessThe wording “latest and greatest with respect to TFMs” is slightly verbose and informal for release notes. A crisper formulation improves readability:
- - CHANGED Dependencies to latest and greatest with respect to TFMs + - UPDATED dependencies to the latest versions for all supported TFMs.nuget/Cuemon.AspNetCore.Mvc/PackageReleaseNotes.txt (1)
5-5: Use a more concise bullet descriptionSame nit as in the other release-note files; recommended wording:
- - CHANGED Dependencies to latest and greatest with respect to TFMs + - UPDATED dependencies to the latest versions for all supported TFMs.nuget/Cuemon.AspNetCore.Razor.TagHelpers/PackageReleaseNotes.txt (1)
5-5: Tighten up phrasing of the dependency-update noteSuggest the following tweak:
- - CHANGED Dependencies to latest and greatest with respect to TFMs + - UPDATED dependencies to the latest versions for all supported TFMs.nuget/Cuemon.Net/PackageReleaseNotes.txt (2)
2-2: Add the serial comma for a three-item listFor consistency with common style guides, insert a comma before “and”:
- Availability: .NET 9, .NET 8 and .NET Standard 2.0 + Availability: .NET 9, .NET 8, and .NET Standard 2.0
5-5: Streamline the ALM bullet wording- - CHANGED Dependencies to latest and greatest with respect to TFMs + - UPDATED dependencies to the latest versions for all supported TFMs.nuget/Cuemon.Runtime.Caching/PackageReleaseNotes.txt (2)
2-2: Prefer serial comma in availability list- Availability: .NET 9, .NET 8 and .NET Standard 2.0 + Availability: .NET 9, .NET 8, and .NET Standard 2.0
5-5: Consistent, concise wording for dependency update- - CHANGED Dependencies to latest and greatest with respect to TFMs + - UPDATED dependencies to the latest versions for all supported TFMs.nuget/Cuemon.Extensions.Core/PackageReleaseNotes.txt (1)
2-5: Polish wording & punctuation for a more professional release noteSmall editorial tweaks improve readability and keep the tone consistent across packages:
-Availability: .NET 9, .NET 8 and .NET Standard 2.0 +Availability: .NET 9, .NET 8, and .NET Standard 2.0 # Oxford comma -# ALM -- CHANGED Dependencies to latest and greatest with respect to TFMs +# ALM +- UPDATED dependencies to the latest versions aligned with supported TFMs(Optional) Consider dropping the initial BOM to avoid odd characters in some editors.
.nuget/Cuemon.Xml/PackageReleaseNotes.txt (1)
2-5: Match release-note tone & fix minor grammarSame wording/punctuation issues as other files; suggested diff keeps all packages uniform:
-Availability: .NET 9, .NET 8 and .NET Standard 2.0 +Availability: .NET 9, .NET 8, and .NET Standard 2.0 -- CHANGED Dependencies to latest and greatest with respect to TFMs +- UPDATED dependencies to the latest versions aligned with supported TFMs.nuget/Cuemon.Extensions.Collections.Generic/PackageReleaseNotes.txt (1)
2-5: Consistent punctuation & less colloquial wordingApply the same edits here for consistency:
-Availability: .NET 9, .NET 8 and .NET Standard 2.0 +Availability: .NET 9, .NET 8, and .NET Standard 2.0 -- CHANGED Dependencies to latest and greatest with respect to TFMs +- UPDATED dependencies to the latest versions aligned with supported TFMs.nuget/Cuemon.Extensions.Hosting/PackageReleaseNotes.txt (1)
2-5: Unify style with other release-note filesRecommend the same minimal edits:
-Availability: .NET 9, .NET 8 and .NET Standard 2.0 +Availability: .NET 9, .NET 8, and .NET Standard 2.0 -- CHANGED Dependencies to latest and greatest with respect to TFMs +- UPDATED dependencies to the latest versions aligned with supported TFMs.nuget/Cuemon.Security.Cryptography/PackageReleaseNotes.txt (1)
2-5: Minor editorial tidy-upBring this file in line with the others:
-Availability: .NET 9, .NET 8 and .NET Standard 2.0 +Availability: .NET 9, .NET 8, and .NET Standard 2.0 -- CHANGED Dependencies to latest and greatest with respect to TFMs +- UPDATED dependencies to the latest versions aligned with supported TFMs.nuget/Cuemon.Core/PackageReleaseNotes.txt (1)
2-5: Polish wording and grammar for clarity and consistencyA tiny copy-edit will make the entry read more naturally and align with common technical-writing conventions (Oxford comma + avoid “with respect to”).
-Availability: .NET 9, .NET 8 and .NET Standard 2.0 +Availability: .NET 9, .NET 8, and .NET Standard 2.0 - - CHANGED Dependencies to latest and greatest with respect to TFMs + - UPDATED dependencies to the latest versions for each supported TFM.nuget/Cuemon.Extensions.Collections.Specialized/PackageReleaseNotes.txt (1)
1-6: Polish release-notes phrasing and punctuation for professionalismThe wording and punctuation of the new entry reads a little informal and is missing the Oxford comma. Consider tightening it up:
-Version 9.0.7 -Availability: .NET 9, .NET 8 and .NET Standard 2.0 - -# ALM -- CHANGED Dependencies to latest and greatest with respect to TFMs +Version 9.0.7 +Availability: .NET 9, .NET 8, and .NET Standard 2.0 + +# ALM +- CHANGED Updated dependencies to the latest versions for all supported TFMssrc/Cuemon.Data.SqlClient/SqlDataManager.cs (2)
4-15: Update XML-doc<see>to a resolvable symbolThe summary still points to
<see cref="SqlClient"/>, which no longer resolves after the switch toMicrosoft.Data.SqlClientand may generate XML-doc warnings.-/// The SqlDataManager is the primary class of the <see cref="SqlClient"/> namespace … +/// The <see cref="SqlDataManager"/> class is the primary entry point of the <c>Cuemon.Data.SqlClient</c> namespace …
129-134: Duplicate validation ofCommandTypeinExecuteIdentityDecimal
Validator.ThrowIfInvalidState(statement.Type != CommandType.Text);is immediately followed by the same check with an exception. One of them is redundant.-Validator.ThrowIfInvalidState(statement.Type != CommandType.Text); -if (statement.Type != CommandType.Text) { throw new ArgumentException("This method only supports CommandType.Text specifications.", nameof(statement)); } +// Keep a single, explicit guard clause +if (statement.Type != CommandType.Text) +{ + throw new ArgumentException("This method only supports CommandType.Text specifications.", nameof(statement)); +}.nuget/Cuemon.AspNetCore.Authentication/PackageReleaseNotes.txt (1)
1-6: Polish wording & trim whitespace for a cleaner changelogSmall editorial tweaks improve readability and remove jargon:
-Availability: .NET 9 and .NET 8 - -# ALM -- CHANGED Dependencies to latest and greatest with respect to TFMs +# Availability +.NET 9, .NET 8 + +# ALM +- CHANGED Dependencies to the latest versions for all supported TFMsThe changes:
- Use a heading + bullet list pattern that is already used further down the file.
- Drop “latest and greatest” (informal) and “with respect to” (wordy).
- Remove superfluous trailing spaces on blank lines.
.nuget/Cuemon.Extensions.AspNetCore.Mvc.Formatters.Text.Json/PackageReleaseNotes.txt (1)
1-6: Consistency & style nitsSame editorial clean-up as other release-note files:
-Availability: .NET 9 and .NET 8 +# Availability +.NET 9, .NET 8 ... -- CHANGED Dependencies to latest and greatest with respect to TFMs +- CHANGED Dependencies to the latest versions for all supported TFMsKeeps tone professional and aligns format across packages.
.nuget/Cuemon.Threading/PackageReleaseNotes.txt (1)
1-6: Add Oxford comma & drop colloquialisms-Availability: .NET 9, .NET 8 and .NET Standard 2.0 +# Availability +.NET 9, .NET 8, and .NET Standard 2.0 ... -- CHANGED Dependencies to latest and greatest with respect to TFMs +- CHANGED Dependencies to the latest versions for all supported TFMsAdds the missing comma before the “and” and clarifies the ALM bullet.
.nuget/Cuemon.Extensions.Text.Json/PackageReleaseNotes.txt (1)
1-6: Minor style tweaks-Availability: .NET 9, .NET 8 and .NET Standard 2.0 +# Availability +.NET 9, .NET 8, and .NET Standard 2.0 ... -- CHANGED Dependencies to latest and greatest with respect to TFMs +- CHANGED Dependencies to the latest versions for all supported TFMsImproves grammar and removes informal wording.
.nuget/Cuemon.Diagnostics/PackageReleaseNotes.txt (1)
1-6: Grammar/clarity pass-Availability: .NET 9, .NET 8 and .NET Standard 2.0 +# Availability +.NET 9, .NET 8, and .NET Standard 2.0 ... -- CHANGED Dependencies to latest and greatest with respect to TFMs +- CHANGED Dependencies to the latest versions for all supported TFMsEnsures consistent punctuation and a concise ALM description.
.nuget/Cuemon.Extensions.Runtime.Caching/PackageReleaseNotes.txt (2)
2-2: Add Oxford comma for clarity.The “and” before the last item can be mis-read without the serial comma.
-Availability: .NET 9, .NET 8 and .NET Standard 2.0 +Availability: .NET 9, .NET 8, and .NET Standard 2.0
5-5: Tighten wording and keep voice consistent.Consider switching to the active “UPDATED” verb and dropping the filler phrase “with respect to”.
-- CHANGED Dependencies to latest and greatest with respect to TFMs +- UPDATED dependencies to the latest versions for all target frameworks (TFMs).nuget/Cuemon.Extensions.Reflection/PackageReleaseNotes.txt (2)
2-2: Insert serial comma.Same style issue as in other release-note files.
-Availability: .NET 9, .NET 8 and .NET Standard 2.0 +Availability: .NET 9, .NET 8, and .NET Standard 2.0
5-5: Prefer concise, active phrasing.-- CHANGED Dependencies to latest and greatest with respect to TFMs +- UPDATED dependencies to the latest versions for all target frameworks (TFMs).nuget/Cuemon.Data/PackageReleaseNotes.txt (2)
2-2: Apply the serial comma for consistency.-Availability: .NET 9, .NET 8 and .NET Standard 2.0 +Availability: .NET 9, .NET 8, and .NET Standard 2.0
5-6: Streamline wording and use a consistent verb.-- CHANGED Dependencies to latest and greatest with respect to TFMs -- CHANGED System.Data.SqlClient to Microsoft.Data.SqlClient since the former is officially deprecated +- UPDATED dependencies to the latest versions for all target frameworks (TFMs) +- REPLACED System.Data.SqlClient with Microsoft.Data.SqlClient due to official deprecationCHANGELOG.md (1)
11-15: Polish wording for clarity & consistencyMinor editorial tweaks to improve readability and align with the tone used in earlier entries.
-This is a service update that focuses on package dependencies and a few bug fixes. +Service-pack focusing on dependency upgrades and minor bug fixes. -- `System.Data.SqlClient` to `Microsoft.Data.SqlClient` since the former is officially deprecated in `Cuemon.Data` assembly +- Replaced the deprecated `System.Data.SqlClient` package with `Microsoft.Data.SqlClient` in the `Cuemon.Data` assembly.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (55)
.docfx/Dockerfile.docfx(2 hunks).github/workflows/pipelines.yml(4 hunks).nuget/Cuemon.AspNetCore.App/PackageReleaseNotes.txt(1 hunks).nuget/Cuemon.AspNetCore.Authentication/PackageReleaseNotes.txt(1 hunks).nuget/Cuemon.AspNetCore.Mvc/PackageReleaseNotes.txt(1 hunks).nuget/Cuemon.AspNetCore.Razor.TagHelpers/PackageReleaseNotes.txt(1 hunks).nuget/Cuemon.AspNetCore/PackageReleaseNotes.txt(1 hunks).nuget/Cuemon.Core.App/PackageReleaseNotes.txt(1 hunks).nuget/Cuemon.Core/PackageReleaseNotes.txt(1 hunks).nuget/Cuemon.Data.Integrity/PackageReleaseNotes.txt(1 hunks).nuget/Cuemon.Data.SqlClient/PackageReleaseNotes.txt(1 hunks).nuget/Cuemon.Data/PackageReleaseNotes.txt(1 hunks).nuget/Cuemon.Diagnostics/PackageReleaseNotes.txt(1 hunks).nuget/Cuemon.Extensions.AspNetCore.Authentication/PackageReleaseNotes.txt(1 hunks).nuget/Cuemon.Extensions.AspNetCore.Mvc.Formatters.Text.Json/PackageReleaseNotes.txt(1 hunks).nuget/Cuemon.Extensions.AspNetCore.Mvc.Formatters.Xml/PackageReleaseNotes.txt(1 hunks).nuget/Cuemon.Extensions.AspNetCore.Mvc.RazorPages/PackageReleaseNotes.txt(1 hunks).nuget/Cuemon.Extensions.AspNetCore.Mvc/PackageReleaseNotes.txt(1 hunks).nuget/Cuemon.Extensions.AspNetCore.Text.Json/PackageReleaseNotes.txt(1 hunks).nuget/Cuemon.Extensions.AspNetCore.Xml/PackageReleaseNotes.txt(1 hunks).nuget/Cuemon.Extensions.AspNetCore/PackageReleaseNotes.txt(1 hunks).nuget/Cuemon.Extensions.Collections.Generic/PackageReleaseNotes.txt(1 hunks).nuget/Cuemon.Extensions.Collections.Specialized/PackageReleaseNotes.txt(1 hunks).nuget/Cuemon.Extensions.Core/PackageReleaseNotes.txt(1 hunks).nuget/Cuemon.Extensions.Data.Integrity/PackageReleaseNotes.txt(1 hunks).nuget/Cuemon.Extensions.Data/PackageReleaseNotes.txt(1 hunks).nuget/Cuemon.Extensions.DependencyInjection/PackageReleaseNotes.txt(1 hunks).nuget/Cuemon.Extensions.Diagnostics/PackageReleaseNotes.txt(1 hunks).nuget/Cuemon.Extensions.Hosting/PackageReleaseNotes.txt(1 hunks).nuget/Cuemon.Extensions.IO/PackageReleaseNotes.txt(1 hunks).nuget/Cuemon.Extensions.Net/PackageReleaseNotes.txt(1 hunks).nuget/Cuemon.Extensions.Reflection/PackageReleaseNotes.txt(1 hunks).nuget/Cuemon.Extensions.Runtime.Caching/PackageReleaseNotes.txt(1 hunks).nuget/Cuemon.Extensions.Text.Json/PackageReleaseNotes.txt(1 hunks).nuget/Cuemon.Extensions.Text/PackageReleaseNotes.txt(1 hunks).nuget/Cuemon.Extensions.Threading/PackageReleaseNotes.txt(1 hunks).nuget/Cuemon.Extensions.Xml/PackageReleaseNotes.txt(1 hunks).nuget/Cuemon.IO/PackageReleaseNotes.txt(1 hunks).nuget/Cuemon.Net/PackageReleaseNotes.txt(1 hunks).nuget/Cuemon.Resilience/PackageReleaseNotes.txt(1 hunks).nuget/Cuemon.Runtime.Caching/PackageReleaseNotes.txt(1 hunks).nuget/Cuemon.Security.Cryptography/PackageReleaseNotes.txt(1 hunks).nuget/Cuemon.Threading/PackageReleaseNotes.txt(1 hunks).nuget/Cuemon.Xml/PackageReleaseNotes.txt(1 hunks)CHANGELOG.md(1 hunks)Directory.Packages.props(2 hunks)src/Cuemon.Data.SqlClient/Cuemon.Data.SqlClient.csproj(1 hunks)src/Cuemon.Data.SqlClient/SqlDataManager.cs(1 hunks)src/Cuemon.Data.SqlClient/SqlInOperator.cs(1 hunks)src/Cuemon.Extensions.DependencyInjection/ServiceProviderExtensions.cs(1 hunks)src/Cuemon.Extensions.Text.Json/Cuemon.Extensions.Text.Json.csproj(1 hunks)test/Cuemon.Core.Tests/Threading/AwaiterTest.cs(1 hunks)test/Cuemon.Data.SqlClient.Tests/SqlDataManagerTest.cs(1 hunks)test/Cuemon.Data.SqlClient.Tests/SqlDatabaseDependencyTest.cs(1 hunks)testenvironments.json(1 hunks)
🧰 Additional context used
🪛 LanguageTool
.nuget/Cuemon.AspNetCore.Mvc/PackageReleaseNotes.txt
[grammar] ~2-~2: Use proper spacing conventions.
Context: ...on 9.0.7 Availability: .NET 9 and .NET 8 # ALM - CHANGED Dependencies to latest an...
(QB_NEW_EN_OTHER_ERROR_IDS_000007)
[style] ~5-~5: ‘with respect to’ might be wordy. Consider a shorter alternative.
Context: ...GED Dependencies to latest and greatest with respect to TFMs Version 9.0.6 Availability: .NET...
(EN_WORDINESS_PREMIUM_WITH_RESPECT_TO)
.nuget/Cuemon.Diagnostics/PackageReleaseNotes.txt
[grammar] ~2-~2: Correctly pair commas and coordinating conjunctions.
Context: ...ersion 9.0.7 Availability: .NET 9, .NET 8 and .NET Standard 2.0 # ALM - CHANGED...
(QB_NEW_EN_OTHER_ERROR_IDS_000073)
[grammar] ~2-~2: Use proper spacing conventions.
Context: ...ty: .NET 9, .NET 8 and .NET Standard 2.0 # ALM - CHANGED Dependencies to latest an...
(QB_NEW_EN_OTHER_ERROR_IDS_000007)
[style] ~5-~5: ‘with respect to’ might be wordy. Consider a shorter alternative.
Context: ...GED Dependencies to latest and greatest with respect to TFMs Version 9.0.6 Availability: .NET...
(EN_WORDINESS_PREMIUM_WITH_RESPECT_TO)
.nuget/Cuemon.Xml/PackageReleaseNotes.txt
[grammar] ~2-~2: Correctly pair commas and coordinating conjunctions.
Context: ...ersion 9.0.7 Availability: .NET 9, .NET 8 and .NET Standard 2.0 # ALM - CHANGED...
(QB_NEW_EN_OTHER_ERROR_IDS_000073)
[grammar] ~2-~2: Use proper spacing conventions.
Context: ...ty: .NET 9, .NET 8 and .NET Standard 2.0 # ALM - CHANGED Dependencies to latest an...
(QB_NEW_EN_OTHER_ERROR_IDS_000007)
[style] ~5-~5: ‘with respect to’ might be wordy. Consider a shorter alternative.
Context: ...GED Dependencies to latest and greatest with respect to TFMs Version 9.0.6 Availability: .NET...
(EN_WORDINESS_PREMIUM_WITH_RESPECT_TO)
.nuget/Cuemon.Extensions.AspNetCore.Text.Json/PackageReleaseNotes.txt
[grammar] ~2-~2: Use proper spacing conventions.
Context: ...on 9.0.7 Availability: .NET 9 and .NET 8 # ALM - CHANGED Dependencies to latest an...
(QB_NEW_EN_OTHER_ERROR_IDS_000007)
[style] ~5-~5: ‘with respect to’ might be wordy. Consider a shorter alternative.
Context: ...GED Dependencies to latest and greatest with respect to TFMs Version 9.0.6 Availability: .NET...
(EN_WORDINESS_PREMIUM_WITH_RESPECT_TO)
.nuget/Cuemon.AspNetCore.App/PackageReleaseNotes.txt
[grammar] ~2-~2: Use proper spacing conventions.
Context: ...on 9.0.7 Availability: .NET 9 and .NET 8 # ALM - CHANGED Dependencies to latest an...
(QB_NEW_EN_OTHER_ERROR_IDS_000007)
[style] ~5-~5: ‘with respect to’ might be wordy. Consider a shorter alternative.
Context: ...GED Dependencies to latest and greatest with respect to TFMs Version 9.0.6 Availability: .NET...
(EN_WORDINESS_PREMIUM_WITH_RESPECT_TO)
.nuget/Cuemon.Runtime.Caching/PackageReleaseNotes.txt
[grammar] ~2-~2: Correctly pair commas and coordinating conjunctions.
Context: ...ersion 9.0.7 Availability: .NET 9, .NET 8 and .NET Standard 2.0 # ALM - CHANGED...
(QB_NEW_EN_OTHER_ERROR_IDS_000073)
[grammar] ~2-~2: Use proper spacing conventions.
Context: ...ty: .NET 9, .NET 8 and .NET Standard 2.0 # ALM - CHANGED Dependencies to latest an...
(QB_NEW_EN_OTHER_ERROR_IDS_000007)
[style] ~5-~5: ‘with respect to’ might be wordy. Consider a shorter alternative.
Context: ...GED Dependencies to latest and greatest with respect to TFMs Version 9.0.6 Availability: .NET...
(EN_WORDINESS_PREMIUM_WITH_RESPECT_TO)
.nuget/Cuemon.Extensions.Diagnostics/PackageReleaseNotes.txt
[grammar] ~2-~2: Correctly pair commas and coordinating conjunctions.
Context: ...ersion 9.0.7 Availability: .NET 9, .NET 8 and .NET Standard 2.0 # ALM - CHANGED...
(QB_NEW_EN_OTHER_ERROR_IDS_000073)
[grammar] ~2-~2: Use proper spacing conventions.
Context: ...ty: .NET 9, .NET 8 and .NET Standard 2.0 # ALM - CHANGED Dependencies to latest an...
(QB_NEW_EN_OTHER_ERROR_IDS_000007)
[style] ~5-~5: ‘with respect to’ might be wordy. Consider a shorter alternative.
Context: ...GED Dependencies to latest and greatest with respect to TFMs Version 9.0.6 Availability: .NET...
(EN_WORDINESS_PREMIUM_WITH_RESPECT_TO)
.nuget/Cuemon.Extensions.Data.Integrity/PackageReleaseNotes.txt
[grammar] ~2-~2: Correctly pair commas and coordinating conjunctions.
Context: ...ersion 9.0.7 Availability: .NET 9, .NET 8 and .NET Standard 2.0 # ALM - CHANGED...
(QB_NEW_EN_OTHER_ERROR_IDS_000073)
[grammar] ~2-~2: Use proper spacing conventions.
Context: ...ty: .NET 9, .NET 8 and .NET Standard 2.0 # ALM - CHANGED Dependencies to latest an...
(QB_NEW_EN_OTHER_ERROR_IDS_000007)
[style] ~5-~5: ‘with respect to’ might be wordy. Consider a shorter alternative.
Context: ...GED Dependencies to latest and greatest with respect to TFMs Version 9.0.6 Availability: .NET...
(EN_WORDINESS_PREMIUM_WITH_RESPECT_TO)
.nuget/Cuemon.Extensions.Runtime.Caching/PackageReleaseNotes.txt
[grammar] ~2-~2: Correctly pair commas and coordinating conjunctions.
Context: ...ersion 9.0.7 Availability: .NET 9, .NET 8 and .NET Standard 2.0 # ALM - CHANGED...
(QB_NEW_EN_OTHER_ERROR_IDS_000073)
[grammar] ~2-~2: Use proper spacing conventions.
Context: ...ty: .NET 9, .NET 8 and .NET Standard 2.0 # ALM - CHANGED Dependencies to latest an...
(QB_NEW_EN_OTHER_ERROR_IDS_000007)
[style] ~5-~5: ‘with respect to’ might be wordy. Consider a shorter alternative.
Context: ...GED Dependencies to latest and greatest with respect to TFMs Version 9.0.6 Availability: .NET...
(EN_WORDINESS_PREMIUM_WITH_RESPECT_TO)
.nuget/Cuemon.Extensions.AspNetCore.Mvc.RazorPages/PackageReleaseNotes.txt
[grammar] ~2-~2: Use proper spacing conventions.
Context: ...on 9.0.7 Availability: .NET 9 and .NET 8 # ALM - CHANGED Dependencies to latest an...
(QB_NEW_EN_OTHER_ERROR_IDS_000007)
[style] ~5-~5: ‘with respect to’ might be wordy. Consider a shorter alternative.
Context: ...GED Dependencies to latest and greatest with respect to TFMs Version 9.0.6 Availability: .NET...
(EN_WORDINESS_PREMIUM_WITH_RESPECT_TO)
.nuget/Cuemon.Extensions.AspNetCore.Mvc/PackageReleaseNotes.txt
[grammar] ~2-~2: Use proper spacing conventions.
Context: ...on 9.0.7 Availability: .NET 9 and .NET 8 # ALM - CHANGED Dependencies to latest an...
(QB_NEW_EN_OTHER_ERROR_IDS_000007)
[style] ~5-~5: ‘with respect to’ might be wordy. Consider a shorter alternative.
Context: ...GED Dependencies to latest and greatest with respect to TFMs Version 9.0.6 Availability: .NET...
(EN_WORDINESS_PREMIUM_WITH_RESPECT_TO)
.nuget/Cuemon.AspNetCore/PackageReleaseNotes.txt
[grammar] ~2-~2: Use proper spacing conventions.
Context: ...on 9.0.7 Availability: .NET 9 and .NET 8 # ALM - CHANGED Dependencies to latest an...
(QB_NEW_EN_OTHER_ERROR_IDS_000007)
[style] ~5-~5: ‘with respect to’ might be wordy. Consider a shorter alternative.
Context: ...GED Dependencies to latest and greatest with respect to TFMs Version 9.0.6 Availability: .NET...
(EN_WORDINESS_PREMIUM_WITH_RESPECT_TO)
.nuget/Cuemon.Extensions.Collections.Generic/PackageReleaseNotes.txt
[grammar] ~2-~2: Correctly pair commas and coordinating conjunctions.
Context: ...ersion 9.0.7 Availability: .NET 9, .NET 8 and .NET Standard 2.0 # ALM - CHANGED...
(QB_NEW_EN_OTHER_ERROR_IDS_000073)
[grammar] ~2-~2: Use proper spacing conventions.
Context: ...ty: .NET 9, .NET 8 and .NET Standard 2.0 # ALM - CHANGED Dependencies to latest an...
(QB_NEW_EN_OTHER_ERROR_IDS_000007)
[style] ~5-~5: ‘with respect to’ might be wordy. Consider a shorter alternative.
Context: ...GED Dependencies to latest and greatest with respect to TFMs Version 9.0.6 Availability: .NET...
(EN_WORDINESS_PREMIUM_WITH_RESPECT_TO)
.nuget/Cuemon.Threading/PackageReleaseNotes.txt
[grammar] ~2-~2: Correctly pair commas and coordinating conjunctions.
Context: ...ersion 9.0.7 Availability: .NET 9, .NET 8 and .NET Standard 2.0 # ALM - CHANGED...
(QB_NEW_EN_OTHER_ERROR_IDS_000073)
[grammar] ~2-~2: Use proper spacing conventions.
Context: ...ty: .NET 9, .NET 8 and .NET Standard 2.0 # ALM - CHANGED Dependencies to latest an...
(QB_NEW_EN_OTHER_ERROR_IDS_000007)
[style] ~5-~5: ‘with respect to’ might be wordy. Consider a shorter alternative.
Context: ...GED Dependencies to latest and greatest with respect to TFMs Version 9.0.6 Availability: .NET...
(EN_WORDINESS_PREMIUM_WITH_RESPECT_TO)
.nuget/Cuemon.Extensions.Hosting/PackageReleaseNotes.txt
[grammar] ~2-~2: Correctly pair commas and coordinating conjunctions.
Context: ...ersion 9.0.7 Availability: .NET 9, .NET 8 and .NET Standard 2.0 # ALM - CHANGED...
(QB_NEW_EN_OTHER_ERROR_IDS_000073)
[grammar] ~2-~2: Use proper spacing conventions.
Context: ...ty: .NET 9, .NET 8 and .NET Standard 2.0 # ALM - CHANGED Dependencies to latest an...
(QB_NEW_EN_OTHER_ERROR_IDS_000007)
[style] ~5-~5: ‘with respect to’ might be wordy. Consider a shorter alternative.
Context: ...GED Dependencies to latest and greatest with respect to TFMs Version 9.0.6 Availability: .NET...
(EN_WORDINESS_PREMIUM_WITH_RESPECT_TO)
.nuget/Cuemon.Core.App/PackageReleaseNotes.txt
[grammar] ~2-~2: Correctly pair commas and coordinating conjunctions.
Context: ...ersion 9.0.7 Availability: .NET 9, .NET 8 and .NET Standard 2.0 # ALM - CHANGED...
(QB_NEW_EN_OTHER_ERROR_IDS_000073)
[grammar] ~2-~2: Use proper spacing conventions.
Context: ...ty: .NET 9, .NET 8 and .NET Standard 2.0 # ALM - CHANGED Dependencies to latest an...
(QB_NEW_EN_OTHER_ERROR_IDS_000007)
[style] ~5-~5: ‘with respect to’ might be wordy. Consider a shorter alternative.
Context: ...GED Dependencies to latest and greatest with respect to TFMs Version 9.0.6 Availability: .NET...
(EN_WORDINESS_PREMIUM_WITH_RESPECT_TO)
.nuget/Cuemon.Extensions.Core/PackageReleaseNotes.txt
[grammar] ~2-~2: Correctly pair commas and coordinating conjunctions.
Context: ...ersion 9.0.7 Availability: .NET 9, .NET 8 and .NET Standard 2.0 # ALM - CHANGED...
(QB_NEW_EN_OTHER_ERROR_IDS_000073)
[grammar] ~2-~2: Use proper spacing conventions.
Context: ...ty: .NET 9, .NET 8 and .NET Standard 2.0 # ALM - CHANGED Dependencies to latest an...
(QB_NEW_EN_OTHER_ERROR_IDS_000007)
[style] ~5-~5: ‘with respect to’ might be wordy. Consider a shorter alternative.
Context: ...GED Dependencies to latest and greatest with respect to TFMs Version 9.0.6 Availability: .NET...
(EN_WORDINESS_PREMIUM_WITH_RESPECT_TO)
.nuget/Cuemon.Resilience/PackageReleaseNotes.txt
[grammar] ~2-~2: Correctly pair commas and coordinating conjunctions.
Context: ...ersion 9.0.7 Availability: .NET 9, .NET 8 and .NET Standard 2.0 # ALM - CHANGED...
(QB_NEW_EN_OTHER_ERROR_IDS_000073)
[grammar] ~2-~2: Use proper spacing conventions.
Context: ...ty: .NET 9, .NET 8 and .NET Standard 2.0 # ALM - CHANGED Dependencies to latest an...
(QB_NEW_EN_OTHER_ERROR_IDS_000007)
[style] ~5-~5: ‘with respect to’ might be wordy. Consider a shorter alternative.
Context: ...GED Dependencies to latest and greatest with respect to TFMs Version 9.0.6 Availability: .NET...
(EN_WORDINESS_PREMIUM_WITH_RESPECT_TO)
.nuget/Cuemon.Net/PackageReleaseNotes.txt
[grammar] ~2-~2: Correctly pair commas and coordinating conjunctions.
Context: ...ersion 9.0.7 Availability: .NET 9, .NET 8 and .NET Standard 2.0 # ALM - CHANGED...
(QB_NEW_EN_OTHER_ERROR_IDS_000073)
[grammar] ~2-~2: Use proper spacing conventions.
Context: ...ty: .NET 9, .NET 8 and .NET Standard 2.0 # ALM - CHANGED Dependencies to latest an...
(QB_NEW_EN_OTHER_ERROR_IDS_000007)
[style] ~5-~5: ‘with respect to’ might be wordy. Consider a shorter alternative.
Context: ...GED Dependencies to latest and greatest with respect to TFMs Version 9.0.6 Availability: .NET...
(EN_WORDINESS_PREMIUM_WITH_RESPECT_TO)
.nuget/Cuemon.Extensions.Collections.Specialized/PackageReleaseNotes.txt
[grammar] ~2-~2: Correctly pair commas and coordinating conjunctions.
Context: ...ersion 9.0.7 Availability: .NET 9, .NET 8 and .NET Standard 2.0 # ALM - CHANGED...
(QB_NEW_EN_OTHER_ERROR_IDS_000073)
[grammar] ~2-~2: Use proper spacing conventions.
Context: ...ty: .NET 9, .NET 8 and .NET Standard 2.0 # ALM - CHANGED Dependencies to latest an...
(QB_NEW_EN_OTHER_ERROR_IDS_000007)
[style] ~5-~5: ‘with respect to’ might be wordy. Consider a shorter alternative.
Context: ...GED Dependencies to latest and greatest with respect to TFMs Version 9.0.6 Availability: .NET...
(EN_WORDINESS_PREMIUM_WITH_RESPECT_TO)
.nuget/Cuemon.Extensions.AspNetCore.Authentication/PackageReleaseNotes.txt
[grammar] ~2-~2: Use proper spacing conventions.
Context: ...on 9.0.7 Availability: .NET 9 and .NET 8 # ALM - CHANGED Dependencies to latest an...
(QB_NEW_EN_OTHER_ERROR_IDS_000007)
[style] ~5-~5: ‘with respect to’ might be wordy. Consider a shorter alternative.
Context: ...GED Dependencies to latest and greatest with respect to TFMs Version 9.0.6 Availability: .NET...
(EN_WORDINESS_PREMIUM_WITH_RESPECT_TO)
.nuget/Cuemon.AspNetCore.Razor.TagHelpers/PackageReleaseNotes.txt
[grammar] ~2-~2: Use proper spacing conventions.
Context: ...on 9.0.7 Availability: .NET 9 and .NET 8 # ALM - CHANGED Dependencies to latest an...
(QB_NEW_EN_OTHER_ERROR_IDS_000007)
[style] ~5-~5: ‘with respect to’ might be wordy. Consider a shorter alternative.
Context: ...GED Dependencies to latest and greatest with respect to TFMs Version 9.0.6 Availability: .NET...
(EN_WORDINESS_PREMIUM_WITH_RESPECT_TO)
.nuget/Cuemon.Extensions.DependencyInjection/PackageReleaseNotes.txt
[grammar] ~2-~2: Correctly pair commas and coordinating conjunctions.
Context: ...ersion 9.0.7 Availability: .NET 9, .NET 8 and .NET Standard 2.0 # ALM - CHANGED...
(QB_NEW_EN_OTHER_ERROR_IDS_000073)
[grammar] ~2-~2: Use proper spacing conventions.
Context: ...ty: .NET 9, .NET 8 and .NET Standard 2.0 # ALM - CHANGED Dependencies to latest an...
(QB_NEW_EN_OTHER_ERROR_IDS_000007)
[style] ~5-~5: ‘with respect to’ might be wordy. Consider a shorter alternative.
Context: ...GED Dependencies to latest and greatest with respect to TFMs Version 9.0.6 Availability: .NET...
(EN_WORDINESS_PREMIUM_WITH_RESPECT_TO)
.nuget/Cuemon.Security.Cryptography/PackageReleaseNotes.txt
[grammar] ~2-~2: Correctly pair commas and coordinating conjunctions.
Context: ...ersion 9.0.7 Availability: .NET 9, .NET 8 and .NET Standard 2.0 # ALM - CHANGED...
(QB_NEW_EN_OTHER_ERROR_IDS_000073)
[grammar] ~2-~2: Use proper spacing conventions.
Context: ...ty: .NET 9, .NET 8 and .NET Standard 2.0 # ALM - CHANGED Dependencies to latest an...
(QB_NEW_EN_OTHER_ERROR_IDS_000007)
[style] ~5-~5: ‘with respect to’ might be wordy. Consider a shorter alternative.
Context: ...GED Dependencies to latest and greatest with respect to TFMs Version 9.0.6 Availability: .NET...
(EN_WORDINESS_PREMIUM_WITH_RESPECT_TO)
.nuget/Cuemon.Extensions.AspNetCore.Mvc.Formatters.Text.Json/PackageReleaseNotes.txt
[grammar] ~2-~2: Use proper spacing conventions.
Context: ...on 9.0.7 Availability: .NET 9 and .NET 8 # ALM - CHANGED Dependencies to latest an...
(QB_NEW_EN_OTHER_ERROR_IDS_000007)
[style] ~5-~5: ‘with respect to’ might be wordy. Consider a shorter alternative.
Context: ...GED Dependencies to latest and greatest with respect to TFMs Version 9.0.6 Availability: .NET...
(EN_WORDINESS_PREMIUM_WITH_RESPECT_TO)
.nuget/Cuemon.Extensions.AspNetCore.Xml/PackageReleaseNotes.txt
[grammar] ~2-~2: Use proper spacing conventions.
Context: ...on 9.0.7 Availability: .NET 9 and .NET 8 # ALM - CHANGED Dependencies to latest an...
(QB_NEW_EN_OTHER_ERROR_IDS_000007)
[style] ~5-~5: ‘with respect to’ might be wordy. Consider a shorter alternative.
Context: ...GED Dependencies to latest and greatest with respect to TFMs Version 9.0.6 Availability: .NET...
(EN_WORDINESS_PREMIUM_WITH_RESPECT_TO)
.nuget/Cuemon.Extensions.Threading/PackageReleaseNotes.txt
[grammar] ~2-~2: Correctly pair commas and coordinating conjunctions.
Context: ...ersion 9.0.7 Availability: .NET 9, .NET 8 and .NET Standard 2.0 # ALM - CHANGED...
(QB_NEW_EN_OTHER_ERROR_IDS_000073)
[grammar] ~2-~2: Use proper spacing conventions.
Context: ...ty: .NET 9, .NET 8 and .NET Standard 2.0 # ALM - CHANGED Dependencies to latest an...
(QB_NEW_EN_OTHER_ERROR_IDS_000007)
[style] ~5-~5: ‘with respect to’ might be wordy. Consider a shorter alternative.
Context: ...GED Dependencies to latest and greatest with respect to TFMs Version 9.0.6 Availability: .NET...
(EN_WORDINESS_PREMIUM_WITH_RESPECT_TO)
.nuget/Cuemon.Core/PackageReleaseNotes.txt
[grammar] ~2-~2: Correctly pair commas and coordinating conjunctions.
Context: ...ersion 9.0.7 Availability: .NET 9, .NET 8 and .NET Standard 2.0 # ALM - CHANGED...
(QB_NEW_EN_OTHER_ERROR_IDS_000073)
[grammar] ~2-~2: Use proper spacing conventions.
Context: ...ty: .NET 9, .NET 8 and .NET Standard 2.0 # ALM - CHANGED Dependencies to latest an...
(QB_NEW_EN_OTHER_ERROR_IDS_000007)
[style] ~5-~5: ‘with respect to’ might be wordy. Consider a shorter alternative.
Context: ...GED Dependencies to latest and greatest with respect to TFMs Version 9.0.6 Availability: .NET...
(EN_WORDINESS_PREMIUM_WITH_RESPECT_TO)
.nuget/Cuemon.AspNetCore.Authentication/PackageReleaseNotes.txt
[grammar] ~2-~2: Use proper spacing conventions.
Context: ...on 9.0.7 Availability: .NET 9 and .NET 8 # ALM - CHANGED Dependencies to latest an...
(QB_NEW_EN_OTHER_ERROR_IDS_000007)
[style] ~5-~5: ‘with respect to’ might be wordy. Consider a shorter alternative.
Context: ...GED Dependencies to latest and greatest with respect to TFMs Version 9.0.6 Availability: .NET...
(EN_WORDINESS_PREMIUM_WITH_RESPECT_TO)
.nuget/Cuemon.Data.SqlClient/PackageReleaseNotes.txt
[grammar] ~2-~2: Correctly pair commas and coordinating conjunctions.
Context: ...ersion 9.0.7 Availability: .NET 9, .NET 8 and .NET Standard 2.0 # ALM - CHANGED...
(QB_NEW_EN_OTHER_ERROR_IDS_000073)
[grammar] ~2-~2: Use proper spacing conventions.
Context: ...ty: .NET 9, .NET 8 and .NET Standard 2.0 # ALM - CHANGED Dependencies to latest an...
(QB_NEW_EN_OTHER_ERROR_IDS_000007)
[style] ~5-~5: ‘with respect to’ might be wordy. Consider a shorter alternative.
Context: ...GED Dependencies to latest and greatest with respect to TFMs Version 9.0.6 Availability: .NET...
(EN_WORDINESS_PREMIUM_WITH_RESPECT_TO)
.nuget/Cuemon.IO/PackageReleaseNotes.txt
[grammar] ~2-~2: Correctly pair commas and coordinating conjunctions.
Context: ...lability: .NET 9, .NET 8, .NET Standard 2.1 and .NET Standard 2.0 # ALM - CHANGED...
(QB_NEW_EN_OTHER_ERROR_IDS_000073)
[grammar] ~2-~2: Use proper spacing conventions.
Context: ... .NET Standard 2.1 and .NET Standard 2.0 # ALM - CHANGED Dependencies to latest an...
(QB_NEW_EN_OTHER_ERROR_IDS_000007)
[style] ~5-~5: ‘with respect to’ might be wordy. Consider a shorter alternative.
Context: ...GED Dependencies to latest and greatest with respect to TFMs Version 9.0.6 Availability: .NET...
(EN_WORDINESS_PREMIUM_WITH_RESPECT_TO)
.nuget/Cuemon.Extensions.Net/PackageReleaseNotes.txt
[grammar] ~2-~2: Correctly pair commas and coordinating conjunctions.
Context: ...ersion 9.0.7 Availability: .NET 9, .NET 8 and .NET Standard 2.0 # ALM - CHANGED...
(QB_NEW_EN_OTHER_ERROR_IDS_000073)
[grammar] ~2-~2: Use proper spacing conventions.
Context: ...ty: .NET 9, .NET 8 and .NET Standard 2.0 # ALM - CHANGED Dependencies to latest an...
(QB_NEW_EN_OTHER_ERROR_IDS_000007)
[style] ~5-~5: ‘with respect to’ might be wordy. Consider a shorter alternative.
Context: ...GED Dependencies to latest and greatest with respect to TFMs Version 9.0.6 Availability: .NET...
(EN_WORDINESS_PREMIUM_WITH_RESPECT_TO)
.nuget/Cuemon.Extensions.IO/PackageReleaseNotes.txt
[grammar] ~2-~2: Correctly pair commas and coordinating conjunctions.
Context: ...lability: .NET 9, .NET 8, .NET Standard 2.1 and .NET Standard 2.0 # ALM - CHANGED...
(QB_NEW_EN_OTHER_ERROR_IDS_000073)
[grammar] ~2-~2: Use proper spacing conventions.
Context: ... .NET Standard 2.1 and .NET Standard 2.0 # ALM - CHANGED Dependencies to latest an...
(QB_NEW_EN_OTHER_ERROR_IDS_000007)
[style] ~5-~5: ‘with respect to’ might be wordy. Consider a shorter alternative.
Context: ...GED Dependencies to latest and greatest with respect to TFMs Version 9.0.6 Availability: .NET...
(EN_WORDINESS_PREMIUM_WITH_RESPECT_TO)
.nuget/Cuemon.Extensions.Xml/PackageReleaseNotes.txt
[grammar] ~2-~2: Correctly pair commas and coordinating conjunctions.
Context: ...ersion 9.0.7 Availability: .NET 9, .NET 8 and .NET Standard 2.0 # ALM - CHANGED...
(QB_NEW_EN_OTHER_ERROR_IDS_000073)
[grammar] ~2-~2: Use proper spacing conventions.
Context: ...ty: .NET 9, .NET 8 and .NET Standard 2.0 # ALM - CHANGED Dependencies to latest an...
(QB_NEW_EN_OTHER_ERROR_IDS_000007)
[style] ~5-~5: ‘with respect to’ might be wordy. Consider a shorter alternative.
Context: ...GED Dependencies to latest and greatest with respect to TFMs Version 9.0.6 Availability: .NET...
(EN_WORDINESS_PREMIUM_WITH_RESPECT_TO)
.nuget/Cuemon.Data/PackageReleaseNotes.txt
[grammar] ~2-~2: Correctly pair commas and coordinating conjunctions.
Context: ...ersion 9.0.7 Availability: .NET 9, .NET 8 and .NET Standard 2.0 # ALM - CHANGED...
(QB_NEW_EN_OTHER_ERROR_IDS_000073)
[grammar] ~2-~2: Use proper spacing conventions.
Context: ...ty: .NET 9, .NET 8 and .NET Standard 2.0 # ALM - CHANGED Dependencies to latest an...
(QB_NEW_EN_OTHER_ERROR_IDS_000007)
[style] ~5-~5: ‘with respect to’ might be wordy. Consider a shorter alternative.
Context: ...GED Dependencies to latest and greatest with respect to TFMs - CHANGED System.Data.SqlClient to...
(EN_WORDINESS_PREMIUM_WITH_RESPECT_TO)
.nuget/Cuemon.Extensions.Text.Json/PackageReleaseNotes.txt
[grammar] ~2-~2: Correctly pair commas and coordinating conjunctions.
Context: ...ersion 9.0.7 Availability: .NET 9, .NET 8 and .NET Standard 2.0 # ALM - CHANGED...
(QB_NEW_EN_OTHER_ERROR_IDS_000073)
[grammar] ~2-~2: Use proper spacing conventions.
Context: ...ty: .NET 9, .NET 8 and .NET Standard 2.0 # ALM - CHANGED Dependencies to latest an...
(QB_NEW_EN_OTHER_ERROR_IDS_000007)
[style] ~5-~5: ‘with respect to’ might be wordy. Consider a shorter alternative.
Context: ...GED Dependencies to latest and greatest with respect to TFMs Version 9.0.6 Availability: .NET...
(EN_WORDINESS_PREMIUM_WITH_RESPECT_TO)
.nuget/Cuemon.Data.Integrity/PackageReleaseNotes.txt
[grammar] ~2-~2: Correctly pair commas and coordinating conjunctions.
Context: ...ersion 9.0.7 Availability: .NET 9, .NET 8 and .NET Standard 2.0 # ALM - CHANGED...
(QB_NEW_EN_OTHER_ERROR_IDS_000073)
[grammar] ~2-~2: Use proper spacing conventions.
Context: ...ty: .NET 9, .NET 8 and .NET Standard 2.0 # ALM - CHANGED Dependencies to latest an...
(QB_NEW_EN_OTHER_ERROR_IDS_000007)
[style] ~5-~5: ‘with respect to’ might be wordy. Consider a shorter alternative.
Context: ...GED Dependencies to latest and greatest with respect to TFMs Version 9.0.6 Availability: .NET...
(EN_WORDINESS_PREMIUM_WITH_RESPECT_TO)
.nuget/Cuemon.Extensions.AspNetCore/PackageReleaseNotes.txt
[grammar] ~2-~2: Use proper spacing conventions.
Context: ...on 9.0.7 Availability: .NET 9 and .NET 8 # ALM - CHANGED Dependencies to latest an...
(QB_NEW_EN_OTHER_ERROR_IDS_000007)
[style] ~5-~5: ‘with respect to’ might be wordy. Consider a shorter alternative.
Context: ...GED Dependencies to latest and greatest with respect to TFMs Version 9.0.6 Availability: .NET...
(EN_WORDINESS_PREMIUM_WITH_RESPECT_TO)
.nuget/Cuemon.Extensions.Reflection/PackageReleaseNotes.txt
[grammar] ~2-~2: Correctly pair commas and coordinating conjunctions.
Context: ...ersion 9.0.7 Availability: .NET 9, .NET 8 and .NET Standard 2.0 # ALM - CHANGED...
(QB_NEW_EN_OTHER_ERROR_IDS_000073)
[grammar] ~2-~2: Use proper spacing conventions.
Context: ...ty: .NET 9, .NET 8 and .NET Standard 2.0 # ALM - CHANGED Dependencies to latest an...
(QB_NEW_EN_OTHER_ERROR_IDS_000007)
[style] ~5-~5: ‘with respect to’ might be wordy. Consider a shorter alternative.
Context: ...GED Dependencies to latest and greatest with respect to TFMs Version 9.0.6 Availability: .NET...
(EN_WORDINESS_PREMIUM_WITH_RESPECT_TO)
.nuget/Cuemon.Extensions.Text/PackageReleaseNotes.txt
[grammar] ~2-~2: Correctly pair commas and coordinating conjunctions.
Context: ...ersion 9.0.7 Availability: .NET 9, .NET 8 and .NET Standard 2.0 # ALM - CHANGED...
(QB_NEW_EN_OTHER_ERROR_IDS_000073)
[grammar] ~2-~2: Use proper spacing conventions.
Context: ...ty: .NET 9, .NET 8 and .NET Standard 2.0 # ALM - CHANGED Dependencies to latest an...
(QB_NEW_EN_OTHER_ERROR_IDS_000007)
[style] ~5-~5: ‘with respect to’ might be wordy. Consider a shorter alternative.
Context: ...GED Dependencies to latest and greatest with respect to TFMs Version 9.0.6 Availability: .NET...
(EN_WORDINESS_PREMIUM_WITH_RESPECT_TO)
.nuget/Cuemon.Extensions.Data/PackageReleaseNotes.txt
[grammar] ~2-~2: Correctly pair commas and coordinating conjunctions.
Context: ...ersion 9.0.7 Availability: .NET 9, .NET 8 and .NET Standard 2.0 # ALM - CHANGED...
(QB_NEW_EN_OTHER_ERROR_IDS_000073)
[grammar] ~2-~2: Use proper spacing conventions.
Context: ...ty: .NET 9, .NET 8 and .NET Standard 2.0 # ALM - CHANGED Dependencies to latest an...
(QB_NEW_EN_OTHER_ERROR_IDS_000007)
[style] ~5-~5: ‘with respect to’ might be wordy. Consider a shorter alternative.
Context: ...GED Dependencies to latest and greatest with respect to TFMs Version 9.0.6 Availability: .NET...
(EN_WORDINESS_PREMIUM_WITH_RESPECT_TO)
.nuget/Cuemon.Extensions.AspNetCore.Mvc.Formatters.Xml/PackageReleaseNotes.txt
[grammar] ~2-~2: Use proper spacing conventions.
Context: ...on 9.0.7 Availability: .NET 9 and .NET 8 # ALM - CHANGED Dependencies to latest an...
(QB_NEW_EN_OTHER_ERROR_IDS_000007)
[style] ~5-~5: ‘with respect to’ might be wordy. Consider a shorter alternative.
Context: ...GED Dependencies to latest and greatest with respect to TFMs Version 9.0.6 Availability: .NET...
(EN_WORDINESS_PREMIUM_WITH_RESPECT_TO)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: call-build (Release) / 🛠️ Build
- GitHub Check: call-build (Debug) / 🛠️ Build
🔇 Additional comments (12)
test/Cuemon.Core.Tests/Threading/AwaiterTest.cs (2)
102-105: LGTM: List initialization formatting is consistent.The list initialization formatting is clean and readable.
109-115: Improved test determinism and efficiency.The modified logic is a good improvement that makes the test more deterministic:
- Throws exactly the expected number of exceptions (2) based on the list size
- Returns unsuccessful result after throwing all exceptions instead of continuing to throw indefinitely
- Ensures predictable test behavior while still validating aggregate exception collection
This change aligns well with the test's purpose of verifying that multiple exceptions are properly aggregated.
src/Cuemon.Data.SqlClient/SqlInOperator.cs (1)
3-3: Updated import is correct; good move
Switching toMicrosoft.Data.SqlClientaligns the library with the supported driver and removes the deprecated dependency. No further action required.test/Cuemon.Data.SqlClient.Tests/SqlDatabaseDependencyTest.cs (1)
4-4: Consistent driver update in tests
The test suite now referencesMicrosoft.Data.SqlClient, matching the production code and avoiding package mismatches. Looks good..github/workflows/pipelines.yml (3)
87-87: Job name improvement enhances clarity.The rename from generic
call-testto specificcall-test-linuximproves workflow readability and makes it easier to distinguish between different test environments.
102-102: Job name improvement enhances clarity.The rename from generic
call-testto specificcall-test-windowsimproves workflow readability and makes it easier to distinguish between different test environments.
201-203: Confirm CodeQL v2 compatibility and timeout configurationI ran a search through our local markdown files for “breaking”, “deprecated” or “removed” in relation to CodeQL v2 and found no references. However, please manually verify:
- That a 30-minute timeout is sufficient for your codebase’s analysis runtime.
- That the official CodeQL Action v2 changelog (e.g. https://github.com/github/codeql-action/releases) does not list any breaking changes affecting your workflow.
File to check:
• .github/workflows/pipelines.yml (lines 201–203)Directory.Packages.props (5)
8-10: Package version updates look consistent.The Codebelt.Extensions.Xunit packages have been updated to version 10.0.3 consistently across all three related packages, which maintains compatibility.
38-38: Microsoft.Data.Sqlite version update looks appropriate.The update to version 8.0.18 aligns with the .NET 8 target framework and maintains consistency with other Microsoft.Data packages.
45-50: Microsoft.Extensions packages updated to .NET 9 versions.All Microsoft.Extensions packages have been consistently updated to version 9.0.7 for the
net9target framework, which aligns with the PR objective of supporting .NET 9.
51-52: Confirmed: Microsoft.Data.SqlClient version strategy is correct
- Version 6.0.2 is the latest stable release (published Apr 25 2025) and targets .NET 8.0+ (and .NET Framework 4.6.2+).
- It no longer supports .NET Standard 2.0, so retaining v5.2.3 for
netstandard2*frameworks is intentional.No changes required.
34-34: Confirm MS.Data.SqlClient 5.2.3 for .NET Standard 2.0
Version 5.2.3 (Apr 28, 2025) includeslib/netstandard2.0/*and is the latest stable release that supports .NET Standard 2.0. Version 6.0.x dropped that target, so pinning 5.2.3 for your netstandard2 builds is intentional and correct. If you prefer a single version across all TFM’s, you can evaluate the 6.1 preview (restores netstandard2.0 support for libraries), but it is not yet a stable release.• Directory.Packages.props line 34:
<PackageVersion Include="Microsoft.Data.SqlClient" Version="5.2.3" />
• Directory.Packages.props lines 51–52:
<PackageVersion Include="Microsoft.Data.SqlClient" Version="6.0.2" />
| FROM --platform=$BUILDPLATFORM nginx:${NGINX_VERSION} AS base | ||
| RUN rm -rf /usr/share/nginx/html/* | ||
|
|
There was a problem hiding this comment.
🛠️ Refactor suggestion
Avoid pulling the same NGINX image twice – reuse the base stage
The base stage already fetches nginx:${NGINX_VERSION} and strips the default html directory. The final stage re-pulls the identical image, duplicating layers and network I/O. You can reuse the cleaned image by deriving final directly from base:
-FROM nginx:${NGINX_VERSION} AS final
+FROM base AS finalThis keeps the layer cache tight and speeds up builds, especially in CI.
Also applies to: 13-14
🤖 Prompt for AI Agents
In .docfx/Dockerfile.docfx around lines 3 to 5 and also lines 13 to 14, the
Dockerfile pulls the same nginx image twice for the base and final stages,
causing redundant layers and network usage. To fix this, modify the final stage
to use the previously defined base stage as its starting point instead of
pulling the nginx image again. This will reuse the cleaned image from the base
stage, improving build efficiency and caching.
| "name": "Docker-Ubuntu", | ||
| "type": "docker", | ||
| "dockerImage": "gimlichael/ubuntu-testrunner:mono-net8.0.411-9.0.301" | ||
| "dockerImage": "gimlichael/ubuntu-testrunner:mono-net8.0.412-9.0.302" |
There was a problem hiding this comment.
💡 Verification agent
❓ Verification inconclusive
Confirm the tag is published before merging
The build will fail if gimlichael/ubuntu-testrunner:mono-net8.0.412-9.0.302 hasn’t been pushed to the registry yet.
Please verify the tag exists:
🏁 Script executed:
#!/bin/bash
# Query Docker Hub for the specific tag
curl -s "https://registry.hub.docker.com/v2/repositories/gimlichael/ubuntu-testrunner/tags/?page_size=1000" \
| jq -r '.results[].name' \
| grep -Fx "mono-net8.0.412-9.0.302" || {
echo "Tag mono-net8.0.412-9.0.302 not found in gimlichael/ubuntu-testrunner" >&2
exit 1
}Length of output: 328
🏁 Script executed:
#!/bin/bash
# Directly check if the specific Docker tag exists
http_code=$(curl -s -o /dev/null -w "%{http_code}" "https://registry.hub.docker.com/v2/repositories/gimlichael/ubuntu-testrunner/tags/mono-net8.0.412-9.0.302")
if [ "$http_code" -eq 200 ]; then
echo "Tag mono-net8.0.412-9.0.302 exists."
exit 0
else
echo "Tag mono-net8.0.412-9.0.302 not found (HTTP $http_code)." >&2
exit 1
fiLength of output: 303
Publish Docker tag before merging
The Docker image tag gimlichael/ubuntu-testrunner:mono-net8.0.412-9.0.302 was not found on Docker Hub (HTTP 404), so the CI build will fail until it’s available. Please take one of the following actions:
- Push the
mono-net8.0.412-9.0.302tag to thegimlichael/ubuntu-testrunnerrepository, or - Update
testenvironments.json(line 12) to reference an existing, published tag.
File: testenvironments.json
Lines: 12
🤖 Prompt for AI Agents
In testenvironments.json at line 12, the Docker image tag
"gimlichael/ubuntu-testrunner:mono-net8.0.412-9.0.302" does not exist on Docker
Hub, causing CI failures. Fix this by either pushing the missing Docker tag to
the repository or updating the "dockerImage" field to use a valid, existing tag
that is already published.
| using System; | ||
| using System.Data; | ||
| using System.Data.SqlClient; | ||
| using Microsoft.Data.SqlClient; | ||
| using System.Linq; |
There was a problem hiding this comment.
💡 Verification agent
🧩 Analysis chain
Trim potentially unused System.Data import
System.Data does not appear to be referenced in this file after migrating to Microsoft.Data.SqlClient.
If confirmed unused, drop the directive to reduce compile warnings.
-using System.Data;Run:
If the output is empty, the import can safely be removed.
🏁 Script executed:
#!/bin/bash
# List references to System.Data types in the test file
rg --line-number --no-heading '\b(DataSet|DataTable|DbType|IData)' test/Cuemon.Data.SqlClient.Tests/SqlDataManagerTest.csLength of output: 123
🏁 Script executed:
#!/bin/bash
# Search for any direct references to System.Data types or namespace
rg --line-number --no-heading '\b(IDbConnection|IDbTransaction|IDbCommand|IDataParameter|IDbDataParameter|CommandType|IsolationLevel|ParameterDirection|DataSet|DataTable|DataRow|DataColumn)\b' test/Cuemon.Data.SqlClient.Tests/SqlDataManagerTest.cs
rg --line-number --no-heading 'System\.Data' test/Cuemon.Data.SqlClient.Tests/SqlDataManagerTest.csLength of output: 372
Remove unused System.Data import
The System.Data namespace isn’t referenced anywhere else in
test/Cuemon.Data.SqlClient.Tests/SqlDataManagerTest.cs and can be safely removed:
--- a/test/Cuemon.Data.SqlClient.Tests/SqlDataManagerTest.cs
+++ b/test/Cuemon.Data.SqlClient.Tests/SqlDataManagerTest.cs
@@ 1,4c1,3
- using System.Data;
using Microsoft.Data.SqlClient;📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| using System; | |
| using System.Data; | |
| using System.Data.SqlClient; | |
| using Microsoft.Data.SqlClient; | |
| using System.Linq; | |
| using System; | |
| using Microsoft.Data.SqlClient; | |
| using System.Linq; |
🤖 Prompt for AI Agents
In test/Cuemon.Data.SqlClient.Tests/SqlDataManagerTest.cs at the top of the file
(lines 1 to 4), the System.Data namespace is imported but not used anywhere in
the code. Remove the line "using System.Data;" to clean up unused imports and
improve code clarity.
| <ItemGroup Condition="$(TargetFramework.StartsWith('netstandard2'))"> | ||
| <PackageReference Include="System.Text.Json" /> | ||
| </ItemGroup> |
There was a problem hiding this comment.
Condition syntax will not evaluate – build will skip the reference
$(TargetFramework.StartsWith('netstandard2')) is not valid MSBuild syntax; the StartsWith call must be done via a property-function expression or you can match the exact TFM.
- <ItemGroup Condition="$(TargetFramework.StartsWith('netstandard2'))">
- <PackageReference Include="System.Text.Json" />
- </ItemGroup>
+ <!-- Add package only when building for any netstandard2.* TFM -->
+ <ItemGroup Condition="$([System.String]::Copy('$(TargetFramework)').StartsWith('netstandard2'))">
+ <PackageReference Include="System.Text.Json" />
+ </ItemGroup>If you only need it for netstandard2.0 exactly, an even simpler condition is:
<ItemGroup Condition="'$(TargetFramework)' == 'netstandard2.0'">Please adjust; otherwise the reference will be ignored and System.Text.Json types will be missing when compiling for netstandard targets.
🤖 Prompt for AI Agents
In src/Cuemon.Extensions.Text.Json/Cuemon.Extensions.Text.Json.csproj around
lines 12 to 14, the Condition attribute uses invalid MSBuild syntax with
StartsWith, causing the package reference to be skipped. Replace the Condition
with a valid expression such as Condition="'$(TargetFramework)' ==
'netstandard2.0'" to ensure the System.Text.Json package is correctly referenced
when targeting netstandard2.0.
| name: call-sonarcloud | ||
| needs: [build, test_linux, test_windows, integration_test] | ||
| uses: codebeltnet/jobs-sonarcloud/.github/workflows/default.yml@v1 | ||
| uses: codebeltnet/jobs-sonarcloud/.github/workflows/default.yml@v2 |
There was a problem hiding this comment.
💡 Verification agent
🧩 Analysis chain
Workflow version upgrade may introduce breaking changes.
The upgrade from @v1 to @v2 for the SonarCloud workflow should be verified to ensure compatibility with existing configuration and that no breaking changes affect the current setup.
🏁 Script executed:
#!/bin/bash
# Description: Check for any breaking changes or new requirements in the SonarCloud workflow v2
# Search for any documentation or changelog references to v2 breaking changes
rg -i "breaking|deprecated|removed" --type md -A 5 -B 5 | grep -i "sonar\|v2"Length of output: 221
🏁 Script executed:
#!/bin/bash
# Clone the SonarCloud jobs repository and diff the v1 vs v2 default workflows
set -e
# Clean up any previous runs
rm -rf sonar-jobs default_v1.yml default_v2.yml
# Clone the repo
git clone https://github.com/codebeltnet/jobs-sonarcloud.git sonar-jobs
cd sonar-jobs
# Fetch tags and capture v1 workflow
git fetch --tags
git checkout v1
cp .github/workflows/default.yml ../default_v1.yml
# Capture v2 workflow
git checkout v2
cp .github/workflows/default.yml ../default_v2.yml
cd ..
# Show the diff (exit code 0 or 1 is okay)
diff -u default_v1.yml default_v2.yml || trueLength of output: 3527
Validate and Adapt SonarCloud Workflow Upgrade to v2
Several inputs and defaults have changed in the v2 workflow—please update your pipeline invocation accordingly:
-
New Inputs
•include-preview(boolean, defaultfalse) replaces the hard-coded preview flag.
• Ensure you passinclude-preview: trueif you relied on previews before. -
Removed Defaults
• The defaults for-d:sonar.sourcesand-d:sonar.testsare no longer included.
• Add these to yourparametersinput if you need them. -
Updated Action Versions
• install-dotnet →@v2
• dotnet-tool-install-sonarscanner →@v2
• dotnet-restore →@v3
• sonarcloud-scan →@v2
• dotnet-build →@v4 -
Renamed Inputs
•includePreview→include-preview
•buildSwitches→build-switches -
New Required Inputs for
sonarcloud-scan@v2
•host(defaults to your previous host)
•parameters(now only defaults to exclusions)
Locations to update in .github/workflows/pipelines.yml (around line 181):
uses: codebeltnet/jobs-sonarcloud/.github/workflows/default.yml@v2
with:
# add or rename inputs here:
include-preview: true # if needed
host: ${{ inputs.host }} # optional override
parameters: ${{ inputs.parameters }} # include your sources/tests flagsPlease review these changes and test your workflow to confirm nothing breaks.
🤖 Prompt for AI Agents
In .github/workflows/pipelines.yml at line 181, update the SonarCloud workflow
usage to the v2 version by adding or renaming inputs as required: replace
includePreview with include-preview and set it to true if previews were used
before; add the host input with the appropriate value; add the parameters input
including sonar.sources and sonar.tests if needed; also ensure that any action
versions used in the workflow are updated to the specified newer versions.
Adjust the pipeline invocation accordingly to match the new v2 workflow input
requirements and test the workflow to confirm it functions correctly.
| <PackageVersion Include="Microsoft.Extensions.Configuration.Json" Version="8.0.1" /> | ||
| <PackageVersion Include="System.Threading.Tasks.Extensions" Version="4.6.3" /> | ||
| <PackageVersion Include="Microsoft.Data.SqlClient" Version="5.2.3" /> | ||
| <PackageVersion Include="System.Text.Json" Version="8.0.6" /> |
There was a problem hiding this comment.
💡 Verification agent
🧩 Analysis chain
System.Text.Json version appears outdated.
The System.Text.Json package is set to version 8.0.6 for netstandard2, but this version might not be the latest available. Consider updating to the latest compatible version for better performance and security.
🌐 Web query:
What is the latest version of System.Text.Json that supports .NET Standard 2.0?
💡 Result:
The latest version of System.Text.Json that supports .NET Standard 2.0 is version 9.0.6. This version is compatible with .NET Standard 2.0 and later versions, as well as .NET Framework 4.6.2 and later versions. (nuget.org)
To install this version, you can use the following command:
dotnet add package System.Text.Json --version 9.0.6Alternatively, if you're using the Package Manager Console in Visual Studio, you can run:
NuGet\Install-Package System.Text.Json -Version 9.0.6For projects that support PackageReference, add the following line to your project file:
<PackageReference Include="System.Text.Json" Version="9.0.6" />This will ensure that your project uses the latest version of System.Text.Json compatible with .NET Standard 2.0.
Citations:
Update System.Text.Json to 9.0.6 for .NET Standard 2.0 compatibility
The System.Text.Json package is currently at 8.0.6 but the latest version supporting .NET Standard 2.0 is 9.0.6. Please bump the version to benefit from performance improvements and security fixes.
• File: Directory.Packages.props
• Line: 35
Replace:
<PackageVersion Include="System.Text.Json" Version="8.0.6" />With:
<PackageVersion Include="System.Text.Json" Version="9.0.6" />🤖 Prompt for AI Agents
In Directory.Packages.props at line 35, update the System.Text.Json package
version from 8.0.6 to 9.0.6 by changing the Version attribute in the
PackageVersion element to "9.0.6" to ensure compatibility with .NET Standard 2.0
and gain performance and security improvements.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #124 +/- ##
=======================================
Coverage 79.86% 79.86%
=======================================
Files 595 595
Lines 18317 18317
Branches 1870 1870
=======================================
Hits 14629 14629
Misses 3618 3618
Partials 70 70 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (4)
.nuget/Cuemon.Data.SqlClient/PackageReleaseNotes.txt (3)
1-1: Remove BOM / invisible character at file startLine 1 starts with a Unicode BOM (the
glyph). This often sneaks in when editing text files and can cause noisy diffs or tooling hiccups on Unix environments.-Version 9.0.7 +Version 9.0.7
2-2: Add serial comma for consistencyThroughout the project’s release notes the serial (Oxford) comma is used (
.NET 9, .NET 8, and …). Keeping the style consistent improves readability.-Availability: .NET 9, .NET 8 and .NET Standard 2.0 +Availability: .NET 9, .NET 8, and .NET Standard 2.0
5-5: Tighten wording“Latest and greatest with respect to TFMs” is informal and a bit wordy. A concise alternative keeps the professional tone of the changelog.
-- CHANGED Dependencies to latest and greatest with respect to TFMs +- CHANGED Updated dependencies to the latest supported versions for each TFM.nuget/Cuemon.Data/PackageReleaseNotes.txt (1)
2-5: Polish language & remove non-breaking-space artifacts for crisper release notesMinor wording/format tweaks improve professionalism and avoid LanguageTool flags.
Proposed diff:-Availability: .NET 9, .NET 8 and .NET Standard 2.0 +Availability: .NET 9, .NET 8, and .NET Standard 2.0 -# ALM -- CHANGED Dependencies to latest and greatest with respect to TFMs +# ALM +- CHANGED Dependencies to the latest stable versions across supported TFMsAlso consider deleting the invisible NBSP (U+00A0) on the blank line above
# ALM; it can cause diff noise in future edits.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (4)
.nuget/Cuemon.Data.SqlClient/PackageReleaseNotes.txt(1 hunks).nuget/Cuemon.Data/PackageReleaseNotes.txt(1 hunks)CHANGELOG.md(1 hunks)src/Cuemon.Data.SqlClient/Cuemon.Data.SqlClient.csproj(2 hunks)
🚧 Files skipped from review as they are similar to previous changes (2)
- src/Cuemon.Data.SqlClient/Cuemon.Data.SqlClient.csproj
- CHANGELOG.md
🧰 Additional context used
🪛 LanguageTool
.nuget/Cuemon.Data.SqlClient/PackageReleaseNotes.txt
[grammar] ~2-~2: Correctly pair commas and coordinating conjunctions.
Context: ...ersion 9.0.7 Availability: .NET 9, .NET 8 and .NET Standard 2.0 # ALM - CHANGED...
(QB_NEW_EN_OTHER_ERROR_IDS_000073)
[grammar] ~2-~2: Use proper spacing conventions.
Context: ...ty: .NET 9, .NET 8 and .NET Standard 2.0 # ALM - CHANGED Dependencies to latest an...
(QB_NEW_EN_OTHER_ERROR_IDS_000007)
[style] ~5-~5: ‘with respect to’ might be wordy. Consider a shorter alternative.
Context: ...GED Dependencies to latest and greatest with respect to TFMs - CHANGED System.Data.SqlClient to...
(EN_WORDINESS_PREMIUM_WITH_RESPECT_TO)
.nuget/Cuemon.Data/PackageReleaseNotes.txt
[grammar] ~2-~2: Correctly pair commas and coordinating conjunctions.
Context: ...ersion 9.0.7 Availability: .NET 9, .NET 8 and .NET Standard 2.0 # ALM - CHANGED...
(QB_NEW_EN_OTHER_ERROR_IDS_000073)
[grammar] ~2-~2: Use proper spacing conventions.
Context: ...ty: .NET 9, .NET 8 and .NET Standard 2.0 # ALM - CHANGED Dependencies to latest an...
(QB_NEW_EN_OTHER_ERROR_IDS_000007)
[style] ~5-~5: ‘with respect to’ might be wordy. Consider a shorter alternative.
Context: ...GED Dependencies to latest and greatest with respect to TFMs Version 9.0.6 Availability: .NET...
(EN_WORDINESS_PREMIUM_WITH_RESPECT_TO)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: call-build (Release) / 🛠️ Build
- GitHub Check: call-build (Debug) / 🛠️ Build
|
This pull request includes updates across multiple areas, focusing on dependency updates, workflow improvements, and Dockerfile enhancements. The most significant changes involve upgrading dependencies for various NuGet packages, improving CI/CD workflows, and introducing flexibility in the Dockerfile configuration.
Dependency Updates:
9.0.7, with changes to dependencies to support the latest Target Framework Monikers (TFMs). This ensures compatibility with .NET 9 and .NET 8, and in some cases, .NET Standard 2.0. (.nuget/*/PackageReleaseNotes.txtreferences: [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14] [15] [16] [17]System.Data.SqlClientreplaced withMicrosoft.Data.SqlClientin theCuemon.Datapackage.Workflow Improvements:
.github/workflows/pipelines.ymlto clarify platform-specific tests (call-test-linuxandcall-test-windows). [1] [2]SonarCloudandCodeQLworkflow versions fromv1tov2, with additional configuration forCodeQLto include a timeout of 30 minutes. [1] [2]Dockerfile Enhancements:
NGINX_VERSION) in.docfx/Dockerfile.docfxto allow flexibility in specifying the NGINX version. Updated the base and final stages to use this argument. [1] [2]This pull request includes updates to Dockerfile configurations, CI/CD workflows, and package release notes to improve maintainability and compatibility. Key changes include parameterizing the NGINX version in Dockerfiles, updating workflow configurations to use newer versions of actions, and updating package dependencies to align with the latest .NET versions.Dockerfile Updates:
.docfx/Dockerfile.docfxusing theNGINX_VERSIONargument for better flexibility and maintainability. [1] [2]CI/CD Workflow Updates:
.github/workflows/pipelines.ymlfor clarity (call-testrenamed tocall-test-linuxandcall-test-windows). [1] [2]SonarCloudandCodeQLaction versions tov2in.github/workflows/pipelines.yml. Added a timeout of 30 minutes for theCodeQLjob. [1] [2]Package Release Notes Updates:
.nugetfiles to reflect the new version9.0.7, indicating compatibility with .NET 9 and .NET 8. Dependencies were updated to the latest versions, and deprecatedSystem.Data.SqlClientwas replaced withMicrosoft.Data.SqlClientin.nuget/Cuemon.Data/PackageReleaseNotes.txt. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14] [15] [16] [17] [18]Summary by CodeRabbit
Bug Fixes
Chores
Documentation