-
Notifications
You must be signed in to change notification settings - Fork 362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix compatibility problem with arm64 architecture #1009
base: dev
Are you sure you want to change the base?
Fix compatibility problem with arm64 architecture #1009
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for proposing some changes to add ARM support. I believe some of these though will make the extension unable to compile for VS2019 since it needs to target the older SDK versions. This has been a challenge with having a code base that spans multiple Visual Studio versions, we always have to target the oldest supported version.
@@ -340,12 +340,13 @@ | |||
<Version>1.0.2</Version> | |||
</PackageReference> | |||
<PackageReference Include="Microsoft.VisualStudio.SDK"> | |||
<Version>16.10.31321.278</Version> | |||
<Version>17.6.36389</Version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe these major package updates will make the extension incompatible with VS2019.
Hi @codecadwallader, I understand your point. |
This also works on the new Microsoft Surface devices that use the Snapdragon ARM64 architecture. I think this requirement might become more requested over the next 12 months as more manufacturers roll out Copilot+ devices. |
You can load different packages using condition statements in your project files. For example in one of my projects I have the following to hide BuildHost-{framework} folders that get created if some libraries are multitargeted.
I am sure that you can use this same syntax to probably use the correct libraries based on the builds by a condition whatever that may be. Since I have no idea what that condition is I cannot provide any more details or even know if this will work. But this is how I take care of issues with multitargeted libraries in a project and this was provided to my by Microsoft support after upgrading to .NET 9.0 and I started getting the BuildHost folders in my web project. Here is a link to the MS Learn site on using the Condition filter within the ItemGroup element. According to Copilot AI you can use the following to build based on Visual Studio version:
This should allow you to add only packages by specific versions per Visual Studio Versions so you can I would assume is multiple versions of the files based on VS Version so everyone can get what they need and you only have one set of code. |
Hello,
I propose a few changes to make the extension compatible with VS 2022 installation on ARM64 architecture.
I have made the update of the NuGet packages and added the target "arm64" to the .vsixmanifest file.
The compilation is successful and I installed the extension to my VS 2022 running on Windows 11 virtualized with parallels desktop on a Macbook Pro (M2 Max chip) computer.