Skip to content

Fix compatibility problem with arm64 architecture #1009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Fix compatibility problem with arm64 architecture #1009

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions CodeMaid.UnitTests/CodeMaid.UnitTests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,25 +81,25 @@
</ItemGroup>
<ItemGroup>
<PackageReference Include="Microsoft.VisualStudio.SDK">
<Version>16.10.31321.278</Version>
<Version>17.6.36389</Version>
</PackageReference>
<PackageReference Include="Microsoft.NET.Test.Sdk">
<Version>17.0.0</Version>
<Version>17.6.2</Version>
</PackageReference>
<PackageReference Include="MSTest.TestAdapter">
<Version>2.2.7</Version>
<Version>3.0.4</Version>
</PackageReference>
<PackageReference Include="MSTest.TestFramework">
<Version>2.2.7</Version>
<Version>3.0.4</Version>
</PackageReference>
<PackageReference Include="NSubstitute">
<Version>4.2.2</Version>
<Version>5.0.0</Version>
</PackageReference>
<PackageReference Include="NUnit">
<Version>3.13.2</Version>
<Version>3.13.3</Version>
</PackageReference>
<PackageReference Include="NUnit3TestAdapter">
<Version>4.0.0</Version>
<Version>4.5.0</Version>
</PackageReference>
</ItemGroup>
<Choose>
Expand Down
5 changes: 3 additions & 2 deletions CodeMaid.VS2022/CodeMaid.VS2022.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -722,12 +722,13 @@
<Version>1.0.2</Version>
</PackageReference>
<PackageReference Include="Microsoft.VisualStudio.SDK">
<Version>17.0.0-previews-2-31512-422</Version>
<Version>17.6.36389</Version>
<ExcludeAssets>runtime</ExcludeAssets>
<PrivateAssets>all</PrivateAssets>
<IncludeAssets>compile; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
</PackageReference>
<PackageReference Include="Microsoft.VSSDK.BuildTools">
<Version>17.0.3177-preview3</Version>
<Version>17.6.2164</Version>
<IncludeAssets>runtime; build; native; contentfiles; analyzers</IncludeAssets>
<PrivateAssets>all</PrivateAssets>
</PackageReference>
Expand Down
3 changes: 3 additions & 0 deletions CodeMaid.VS2022/source.extension.vsixmanifest
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,9 @@
<InstallationTarget Id="Microsoft.VisualStudio.Community" Version="[17.0, 18.0)">
<ProductArchitecture>amd64</ProductArchitecture>
</InstallationTarget>
<InstallationTarget Version="[17.0,18.0)" Id="Microsoft.VisualStudio.Community">
<ProductArchitecture>arm64</ProductArchitecture>
</InstallationTarget>
</Installation>
<Dependencies>
<Dependency Id="Microsoft.Framework.NDP" DisplayName="Microsoft .NET Framework" d:Source="Manual" Version="[4.7.2,)" />
Expand Down
5 changes: 3 additions & 2 deletions CodeMaid/CodeMaid.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -340,12 +340,13 @@
<Version>1.0.2</Version>
</PackageReference>
<PackageReference Include="Microsoft.VisualStudio.SDK">
<Version>16.10.31321.278</Version>
<Version>17.6.36389</Version>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe these major package updates will make the extension incompatible with VS2019.

<ExcludeAssets>runtime</ExcludeAssets>
<PrivateAssets>all</PrivateAssets>
<IncludeAssets>compile; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
</PackageReference>
<PackageReference Include="Microsoft.VSSDK.BuildTools">
<Version>16.11.35</Version>
<Version>17.6.2164</Version>
<IncludeAssets>runtime; build; native; contentfiles; analyzers</IncludeAssets>
<PrivateAssets>all</PrivateAssets>
</PackageReference>
Expand Down