Cy/non pat appless #3667
Merged
Cy/non pat appless #3667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
@@ Coverage Diff @@
## main #3667 +/- ##
==========================================
- Coverage 98.81% 98.78% -0.04%
==========================================
Files 825 824 -1
Lines 14892 14805 -87
Branches 4241 4202 -39
==========================================
- Hits 14716 14625 -91
- Misses 167 171 +4
Partials 9 9
... and 1 file with indirect coverage changes
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
@@ Coverage Diff @@
## main #3667 +/- ##
==========================================
- Coverage 98.81% 98.78% -0.04%
==========================================
Files 825 824 -1
Lines 14892 14805 -87
Branches 4241 4202 -39
==========================================
- Hits 14716 14625 -91
- Misses 167 171 +4
Partials 9 9
... and 1 file with indirect coverage changes
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
@@ Coverage Diff @@
## main #3667 +/- ##
==========================================
- Coverage 98.81% 98.78% -0.04%
==========================================
Files 825 824 -1
Lines 14892 14805 -87
Branches 4233 4202 -31
==========================================
- Hits 14716 14625 -91
- Misses 167 171 +4
Partials 9 9
... and 1 file with indirect coverage changes
Continue to review full report in Codecov by Sentry.
|
Bundle ReportChanges will increase total bundle size by 64.86kB (0.52%) ⬆️. This is within the configured threshold ✅ Detailed changes
|
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## main #3667 +/- ##
==========================================
- Coverage 98.81% 98.78% -0.04%
==========================================
Files 825 824 -1
Lines 14892 14805 -87
Branches 4233 4202 -31
==========================================
- Hits 14716 14625 -91
- Misses 167 171 +4
Partials 9 9
... and 1 file with indirect coverage changes
Continue to review full report in Codecov by Sentry.
|
✅ Deploy preview for gazebo ready!Previews expire after 1 month automatically.
|
calvin-codecov
force-pushed
the
cy/non_pat_appless
branch
from
4a1350e to
2e32017
Compare
New onboarding container and install codecov modal
Bundle ReportChanges will increase total bundle size by 64.86kB (0.52%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: gazebo-staging-esmAssets Changed:
Files in
Files in
Files in
view changes for bundle: gazebo-staging-systemAssets Changed:
Files in
Files in
Files in
|
calvin-codecov
commented
Jan 23, 2025
| @@ -40,7 +40,7 @@ const BaseModal: React.FC<BaseModalProps> = ({ | |||
| </header> | |||
| {subtitle && <p className="px-4 text-lg">{subtitle}</p>} | |||
| {body && ( | |||
| <div className="max-h-96 w-full overflow-y-auto border-t border-ds-sub-background bg-ds-container p-4 text-sm text-ds-gray-octonary"> | |||
| <div className="w-full overflow-y-auto border-t border-ds-sub-background bg-ds-container p-4 text-sm text-ds-gray-octonary"> | |||
There was a problem hiding this comment.
Removing the arbitrary max-height of 384px here in favor for line 26 where the total height of the modal is set to maximum 90%vh. As the header and footer expand with content, they vertically lengthen the modal. When the modal reaches the height limit, the header and footer overlap more of the body while the body will start having a scrollbar to accommodate the overflowing content.
calvin-codecov
commented
Jan 23, 2025
Comment on lines
+63
to
+68
| eventTracker().track({ | ||
| type: 'Button Clicked', | ||
| properties: { | ||
| buttonName: 'Install GitHub App', | ||
| buttonLocation: 'Install modal', | ||
| }, |
There was a problem hiding this comment.
is this fine, @spalmurray-codecov? I copied from the instance you added in another place while changing the buttonLocation.
There was a problem hiding this comment.
Yes this looks good! I'm thinking we may want to track the button click that opens the modal as well - thoughts? Would let us track the mini-funnel that is that banner -> modal -> GH.
calvin-codecov
force-pushed
the
cy/non_pat_appless
branch
2 times, most recently
from
8b56e12 to
92aef64
Compare
calvin-codecov
force-pushed
the
cy/non_pat_appless
branch
from
92aef64 to
3ba69cc
Compare
| @@ -66,6 +66,14 @@ function OwnerPage() { | |||
| } | |||
| }, [userStartedTrial]) | |||
|
|
|||
| // TODO: refactor this to add a gql field for the integration id used to determine if the org has a GH app | |||
There was a problem hiding this comment.
This comment looks out of date no? There seems to be integrationId in the GQL response
| @@ -18,8 +20,11 @@ const TokenlessBanner: React.FC = () => { | |||
| }) | |||
| const { provider, owner } = useParams<UseParams>() | |||
| const { data } = useUploadTokenRequired({ provider, owner, enabled: !!owner }) | |||
| const { params } = useLocationParams() | |||
| // @ts-expect-error useLocationParams needs to be typed | |||
| const cameFromOnboarding = params['source'] === ONBOARDING_SOURCE | |||
There was a problem hiding this comment.
Glad this was so easy hell yea
spalmurray-codecov
approved these changes
Jan 24, 2025
calvin-codecov
added a commit
that referenced
this pull request
Jan 24, 2025
This reverts commit 53ce439.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Combination of codecov/engineering-team#2828, codecov/engineering-team#2734, and #3629, which were all previously approved, with a couple final UI tweaks.
These 3 PRs together encapsulate the entire Non-PAT Appless feature (aka p1).
Code Example
Notable Changes
Screenshots
Link to Sample Entry
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.