Pytest: add forked marker to PC tests #31335
Conversation
| @@ -144,6 +144,7 @@ pyprof2calltree = "*" | |||
| pytest = "*" | |||
| pytest-cov = "*" | |||
| pytest-cpp = "*" | |||
| pytest-forked = "*" | |||
There was a problem hiding this comment.
i'm building a new agnos. want to get this in?
There was a problem hiding this comment.
we probably won't use it for any of the tici tests, but it will be nice to have it in case
There was a problem hiding this comment.
and pytest-randomly for test randomization?
There was a problem hiding this comment.
| @@ -45,6 +46,7 @@ def get_fuzzy_car_interface_args(draw: DrawType) -> dict: | |||
| return params | |||
|
|
|||
|
|
|||
| @pytest.mark.forked | |||
There was a problem hiding this comment.
| @pytest.mark.forked |
this isn't needed after commaai/opendbc#1007
There was a problem hiding this comment.
We should also be conservative using it as it would have masked this
also found this, relevant? pytest-dev/pytest-forked#87
There was a problem hiding this comment.
We should also be conservative using it
I feel like we want it everywhere so we don't get segfaults in the unittests without any idea of which test they came from
|
This PR has had no activity for 30 days. It will be automatically closed in 7 days if there is no activity. |
|
This PR has been automatically closed due to inactivity. Feel free to re-open once activity resumes. |
we had random segfaults in CI that kills the whole pytest run without giving the output, forking will allow the run to continue and output the tests where the segfault occurs