Skip to content

ui: avoid unnecessary text cache invalidation in UnifiedLabel #36676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+9 −7
Open

ui: avoid unnecessary text cache invalidation in UnifiedLabel #36676

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 9 additions & 7 deletions system/ui/widgets/label.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -446,7 +446,7 @@ def __init__(self,
def set_text(self, text: str | Callable[[], str]):
"""Update the text content."""
self._text = text
self._cached_text = None # Invalidate cache
# No need to update cache here, will be done on next render if needed

@property
def text(self) -> str:
Expand All @@ -463,15 +463,17 @@ def set_color(self, color: rl.Color):

def set_font_size(self, size: int):
"""Update the font size."""
self._font_size = size
self._spacing_pixels = size * self._letter_spacing # Recalculate spacing
self._cached_text = None # Invalidate cache
if self._font_size != size:
self._font_size = size
self._spacing_pixels = size * self._letter_spacing # Recalculate spacing
self._cached_text = None # Invalidate cache

def set_letter_spacing(self, letter_spacing: float):
"""Update letter spacing (as percentage, e.g., 0.1 = 10%)."""
self._letter_spacing = letter_spacing
self._spacing_pixels = self._font_size * letter_spacing
self._cached_text = None # Invalidate cache
if self._letter_spacing != letter_spacing:
self._letter_spacing = letter_spacing
self._spacing_pixels = self._font_size * letter_spacing
self._cached_text = None # Invalidate cache

def set_font_weight(self, font_weight: FontWeight):
"""Update the font weight."""
Expand Down