Add tests for proposal description restriction feature#21
Open
Emmyt24 wants to merge 1 commit intocompound-finance:mainfrom
Open
Add tests for proposal description restriction feature#21Emmyt24 wants to merge 1 commit intocompound-finance:mainfrom
Emmyt24 wants to merge 1 commit intocompound-finance:mainfrom
Conversation
- Add testFuzz_RevertIf_DescriptionRestrictsProposer to test that proposals with restricted descriptions revert for unauthorized proposers - Add testFuzz_ProposeSucceedsIfDescriptionRestrictsCorrectProposer to test that proposals succeed when the description restricts to the correct proposer - Add _toHexString helper function for address formatting in tests This covers the previously uncovered _isValidDescriptionForProposer check in the propose function, ensuring frontrunning protection is tested.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This covers the previously uncovered _isValidDescriptionForProposer check in the propose function, ensuring frontrunning protection is tested.