Skip to content

Add tests for proposal description restriction feature #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Emmyt24 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add tests for proposal description restriction feature #21

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 32 additions & 0 deletions contracts/test/CompoundGovernor.t.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,6 +177,38 @@ contract Propose is CompoundGovernorTest {
);
_submitProposal(_proposer, _proposal);
}

function testFuzz_RevertIf_DescriptionRestrictsProposer(address _proposer, address _wrongProposer) public {
vm.assume(_proposer != _wrongProposer);
vm.assume(_wrongProposer != address(0));
Proposal memory _proposal = _buildAnEmptyProposal();
_proposal.description = string(abi.encodePacked(_proposal.description, "#proposer=0x", _toHexString(_proposer)));
vm.prank(_wrongProposer);
vm.expectRevert(abi.encodeWithSelector(IGovernor.GovernorRestrictedProposer.selector, _wrongProposer));
governor.propose(_proposal.targets, _proposal.values, _proposal.calldatas, _proposal.description);
}

function testFuzz_ProposeSucceedsIfDescriptionRestrictsCorrectProposer(address _proposer) public {
vm.assume(_proposer != address(0));
Proposal memory _proposal = _buildAnEmptyProposal();
_proposal.description = string(abi.encodePacked(_proposal.description, "#proposer=0x", _toHexString(_proposer)));
_setWhitelistedProposer(_proposer);
vm.prank(_proposer);
uint256 _proposalId = governor.propose(_proposal.targets, _proposal.values, _proposal.calldatas, _proposal.description);
vm.roll(vm.getBlockNumber() + INITIAL_VOTING_DELAY + 1);
vm.assertEq(uint8(governor.state(_proposalId)), uint8(IGovernor.ProposalState.Active));
}

function _toHexString(address addr) internal pure returns (string memory) {
bytes memory alphabet = "0123456789abcdef";
bytes memory data = abi.encodePacked(addr);
bytes memory str = new bytes(40);
for (uint256 i = 0; i < 20; i++) {
str[i*2] = alphabet[uint8(data[i] >> 4)];
str[i*2+1] = alphabet[uint8(data[i] & 0x0f)];
}
return string(str);
}
}

abstract contract Queue is CompoundGovernorTest {
Expand Down