Add workspace resolver support and update create-gen-app tests for new boilerplates #22

sdqede · 2025-12-16T02:23:48Z

Add missing workspace resolvers (workspace.name, workspace.organization.name, workspace.license) and tests; prefer repo slug fallback, document in README.
Update create-gen-app-test to use constructive-io/pgpm-boilerplates on main with default/ base path; refresh integration helpers, CLI/dev defaults, and snapshots for the new template layout.

files/lines that address #380 (workspace resolvers + setFrom defaults): in the packages/inquirerer

add workspace.name, workspace.organization.name, and workspace.license resolvers using repo URL/pkg license fallback ensure workspace name prefers repo slug with package name fallback expand resolver and setFrom tests to cover new workspace keys document workspace resolver list in README

point tests, CLI defaults, and dev script to constructive-io/pgpm-boilerplates on main with default/ base path adjust integration helpers to use the new template path and branch; update snapshots for new boilerplate contents refresh docs to reflect the new repo URL and template directory defaults

pyramation · 2025-12-16T04:33:59Z

packages/create-gen-app-test/dev/README.md

+- `--repo` (`-r`): repository URL to clone (default: `https://github.com/constructive-io/pgpm-boilerplates/`)
 - `--branch` (`-b`): branch or tag to checkout
- `--path` (`-p`): directory within the repo to scan for templates (default: `.`)
+- `--path` (`-p`): directory within the repo to scan for templates (default: `default`)


shouldn't default be ., and in our repo, we're setting it to default because we have the folder there?

We originally hardcoded default to stop CI failures after the boilerplate repo moved templates under default/ and the dev harness didn’t read .boilerplates.json. Now the CLI auto-detects the base dir from that file (fallback .), so CI stays green without the hardcoded path

pyramation · 2025-12-16T04:34:22Z

packages/create-gen-app-test/dev/index.ts

-const DEFAULT_REPO = "https://github.com/launchql/pgpm-boilerplates/";
-const DEFAULT_DIRECTORY = ".";
+const DEFAULT_REPO = "https://github.com/constructive-io/pgpm-boilerplates/";
+const DEFAULT_DIRECTORY = "default";


I don't think this is the default, . makes more sense.

the same as above reply

pyramation · 2025-12-16T04:35:16Z

packages/create-gen-app-test/src/cli.ts

-const DEFAULT_REPO = "https://github.com/launchql/pgpm-boilerplates.git";
-const DEFAULT_PATH = ".";
+const DEFAULT_REPO = "https://github.com/constructive-io/pgpm-boilerplates.git";
+const DEFAULT_PATH = "default";


again this should be .

the same as above reply

pyramation · 2025-12-16T04:36:20Z

packages/create-gen-app-test/src/cli.ts

 // Import package.json for version
 import * as createGenPackageJson from "create-gen-app/package.json";
-const PACKAGE_NAME = createGenPackageJson.name ?? "@launchql/cli";
+const PACKAGE_NAME = createGenPackageJson.name ?? "@constructive/cli";


this cli doesn't exist, we currenlty have pgpm or @launchql/cli

pyramation · 2025-12-16T04:36:30Z

packages/create-gen-app-test/src/test-utils/integration-helpers.ts

-  process.env.CREATE_GEN_TEST_BRANCH ?? "license";
+  process.env.CREATE_GEN_TEST_BRANCH ?? "main";
+export const TEST_TEMPLATE_DIR =
+  process.env.CREATE_GEN_TEST_BASE_PATH ?? "default";


I removed the hardcoded default here as well. The test helper now mirrors the CLI behavior: it prefers CREATE_GEN_TEST_BASE_PATH, otherwise reads .boilerplates.json to determine the base dir and falls back to .. The earlier default was to keep tests working after templates moved under that folder without reading the config file; auto-detection makes this robust without assumptions.

pyramation · 2025-12-16T04:37:05Z

packages/inquirerer/README.md

+| `workspace.license` | License field from `package.json` | `"MIT"` |
+| `workspace.author` | Author name from `package.json` | `"Constructive"` |
+| `workspace.author.name` | Author name from `package.json` | `"Constructive"` |
+| `workspace.author.email` | Author email from `package.json` | `"[email protected]"` |


please use this as an example:
([email protected])

Body read .boilerplates.json to pick the default template path (fallback to .) instead of hardcoding default update dev CLI/help text and docs to reflect auto-detected template directory keep repo default pointing at constructive-io/pgpm-boilerplates; tests verified passing after changes

pyramation · 2025-12-16T10:09:00Z

packages/create-gen-app-test/src/cli.ts

    console.warn(
      `⚠️  Cached template expired (last updated: ${new Date(expiredMetadata.lastUpdated).toLocaleString()})`
    );
-    console.log('Updating cache...');


@sdqede please use ' not " — you're changing things that make PRs hard to read, and also it's not our preferred style, please use '' (single quotes)

and @sdqede while you're working on this repo, can you also fix all the [email protected] and please change it to [email protected] thanks

…honors CREATE_GEN_TEST_BASE_PATH first, otherwise reads .boilerplates.json for dir, falling back to .

…pp tests add helper to clone/cached repos and read .boilerplates.json for the template base dir, with env override and fallback update CLI and cached-template integration tests to compute fromPath from the resolved base dir instead of hardcoded defaults keeps tests aligned with repo layout changes and avoids path assumptions

sdqede added 2 commits December 16, 2025 09:33

sdqede self-assigned this Dec 16, 2025

pyramation reviewed Dec 16, 2025

View reviewed changes

sdqede added 2 commits December 16, 2025 13:12

Update PACKAGE_NAME

093284b

pyramation reviewed Dec 16, 2025

View reviewed changes

sdqede added 6 commits December 17, 2025 09:01

Updated the test helper to auto-detect the template base dir: it now …

a87c903

…honors CREATE_GEN_TEST_BASE_PATH first, otherwise reads .boilerplates.json for dir, falling back to .

Update author email in README to a placeholder address

904986c

install eslint-plugin-prettier

964a13c

use lint to change all " into '

e22132a

replace [email protected] with [email protected]

0f42eb3

pyramation merged commit 0084b61 into main Dec 17, 2025
34 checks passed

Add workspace resolver support and update create-gen-app tests for new boilerplates #22

Add workspace resolver support and update create-gen-app tests for new boilerplates #22

Uh oh!

Conversation

sdqede commented Dec 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sdqede Dec 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pyramation Dec 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

sdqede commented Dec 16, 2025 •

edited

Loading

sdqede Dec 16, 2025 •

edited

Loading

pyramation Dec 16, 2025 •

edited

Loading