Skip to content

Add workspace resolver support and update create-gen-app tests for new boilerplates #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pyramation merged 10 commits into from
Dec 17, 2025
Merged

Add workspace resolver support and update create-gen-app tests for new boilerplates #22

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
f5109d7
Title: Add workspace resolvers for boilerplate defaults
sdqede Dec 16, 2025
a163592
Update create-gen-app-test for new pgpm-boilerplates repo/layout
sdqede Dec 16, 2025
093284b
Update PACKAGE_NAME
sdqede Dec 16, 2025
9be6fd0
Auto-detect boilerplate base path in create-gen-app test harness
sdqede Dec 16, 2025
a87c903
Updated the test helper to auto-detect the template base dir: it now …
sdqede Dec 17, 2025
904986c
Update author email in README to a placeholder address
sdqede Dec 17, 2025
964a13c
install eslint-plugin-prettier
sdqede Dec 17, 2025
e22132a
use lint to change all " into '
sdqede Dec 17, 2025
0f42eb3
replace [email protected] with [email protected]
sdqede Dec 17, 2025
5f482a7
Resolve boilerplate base path from .boilerplates.json in create-gen-a…
sdqede Dec 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 9 additions & 7 deletions packages/create-gen-app-test/src/cli.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import { Inquirerer, ListQuestion } from "inquirerer";
import minimist, { ParsedArgs } from "minimist";

import { CacheManager, GitCloner, checkNpmVersion } from "create-gen-app";
import { createFromTemplate } from './index';
import { createFromTemplate } from "./index";

const DEFAULT_REPO = "https://github.com/constructive-io/pgpm-boilerplates.git";
const DEFAULT_PATH = "default";
Copy link
Contributor

@pyramation pyramation Dec 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

again this should be .

Copy link
Contributor Author

@sdqede sdqede Dec 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the same as above reply

Expand All @@ -18,7 +18,7 @@ const DEFAULT_TTL_DAYS = DEFAULT_TTL / (24 * 60 * 60 * 1000);

// Import package.json for version
import * as createGenPackageJson from "create-gen-app/package.json";
const PACKAGE_NAME = createGenPackageJson.name ?? "@constructive/cli";
const PACKAGE_NAME = createGenPackageJson.name ?? "@launchql/cli";
const PACKAGE_VERSION = createGenPackageJson.version ?? "0.0.0";

const RESERVED_ARG_KEYS = new Set([
Expand Down Expand Up @@ -134,7 +134,7 @@ export async function runCli(
console.warn(
`⚠️ Cached template expired (last updated: ${new Date(expiredMetadata.lastUpdated).toLocaleString()})`
);
console.log('Updating cache...');
Copy link
Contributor

@pyramation pyramation Dec 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sdqede please use ' not " — you're changing things that make PRs hard to read, and also it's not our preferred style, please use '' (single quotes)

Copy link
Contributor

@pyramation pyramation Dec 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and @sdqede while you're working on this repo, can you also fix all the [email protected] and please change it to [email protected] thanks

console.log("Updating cache...");
cacheManager.clear(cacheKey);
}

Expand All @@ -150,7 +150,7 @@ export async function runCli(
gitCloner.clone(normalizedUrl, tempDest, { branch: args.branch, depth: 1 });
cacheManager.set(cacheKey, tempDest);
templateDir = tempDest;
console.log('Template cached for future runs');
console.log("Template cached for future runs");
}

try {
Expand Down Expand Up @@ -209,8 +209,8 @@ export async function runCli(
const answerOverrides = extractAnswerOverrides(args);
const noTty = Boolean(
args["no-tty"] ??
(args as Record<string, unknown>).noTty ??
(args as Record<string, unknown>).tty === false
(args as Record<string, unknown>).noTty ??
(args as Record<string, unknown>).tty === false
);

// Use the createFromTemplate function which will use the same cache
Expand Down Expand Up @@ -330,7 +330,9 @@ if (require.main === module) {
}

function resolveTtlOption(args: ParsedArgs): number | undefined {
const disableTtl = Boolean(args["no-ttl"] ?? (args as Record<string, unknown>).noTtl);
const disableTtl = Boolean(
args["no-ttl"] ?? (args as Record<string, unknown>).noTtl
);
if (disableTtl) {
return undefined;
}
Expand Down