-
Notifications
You must be signed in to change notification settings - Fork 650
[Fix]: image delete in convert (#3510) #4121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
One count for #4068 |
One count for #4119 |
Ignoring ubuntu broken servers. |
One count for #3556 |
Signed-off-by: apostasie <[email protected]>
One count for #4046 |
@AkihiroSuda this is ready for review. I am still going to run the CI a few more times to increase confidence that the bug is gone, but so far I see only the other flakies and no longer this %^&*$ |
One count for #4046 - damn we need to fix this one. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
Hopefully, this should be the last one of these (fingers crossed).
This part of
convert
has the same code pattern as seen incontainerd.Convert
.My understanding is this:
newI.Name
content digest not found
error)I believe this understanding of how containerd API works is (at least partly) valid, as the prior series of patch have significantly reduced the symptoms.
As far as I can tell, the last place where we see this is #3510 - which does presumably hit this code path.
I will run the CI a few times to confirm, and then that should fix #3510.
Note: obviously, containerd image store API is wildly confusing and hard to reason about (and possibly has bugs - at least
converter.Convert
seems broken). This has clearly tripped the most savvy people here. Suggesting we isolate it behind a simpler, tested,nerdctl.ImageStore
, and prevent casual code from using the containerd store directly.