Install arm64 kolet #30
Conversation
Signed-off-by: Geoff Levand <[email protected]>
Signed-off-by: Geoff Levand <[email protected]>
|
It doesn't look to me like copr even supports aarch64? That said, I'd like to deprecate it, see this issue. Short term, we could potentially just rebuild it here? I forget even why it's archful. |
|
Also, thanks a ton for working on this! |
|
@cgwalters I could build rpmdistro-gitoverlay on my arm64 test machine. Were you thinking to add its build to |
That - it's Python so it doesn't really have a build anyways. |
|
Really glad to see arm64 support for CoreOS! |
We want the ability to make breaking changes to how we build RPMs; having it as a submodule will allow us to break things. Further, today COPR doesn't support e.g. aarch64, which imposes an artificial limitation on building this container. (Today we're using the Ignition from COPR, but actually for validating configs we could probably just use the main repo) Obsoletes: coreos#30
|
Thanks for submitting this btw! OK, at the time - we probably should have merged this PR and continued on top. But anyways, a whole lot has changed since then. I believe it's just the last hunk in your patch here for the kolet that still applies. How about doing that upstream? Although a tricky thing is that today coreos-assembler follows Fedora in not doing cross-compilation; there's no real point to installing all kolet architectures. (Though I can imagine changing to support cross build/testing here like CL does, but there's immense complexity there) |
|
sorry, I've not been paying attention to this, but currently the build.sh file needs updates. Can you resolve them, and I'll integrate this |
|
Ah...wait, are you reading github notifications for coreos-assembler and thinking it's coreos-installer or something? |
Yeah I'm a bit confused.. In case you are looking for |
This gets the coreos-assembler docker image to (almost) build on arm64 machines. It also adds an install of the arm64 mantle kolet for all architectures.
@cgwalters I only saw x86_64 builds of rpmdistro-gitoverlay. build.sh would fail on that. Commenting out that install would get a successful build.