Fix BasicAuth header not getting sent when SG GUEST is enabled

Sent the Basic Auth header without wating for challenge. #2216
couchbase · Oct 22, 2018 · d174519 · d174519
1 parent 0e4aaf2
commit d174519
Showing 1 changed file with 1 addition and 11 deletions.
diff --git a/Objective-C/Internal/Replicator/CBLHTTPLogic.m b/Objective-C/Internal/Replicator/CBLHTTPLogic.m
@@ -206,7 +206,7 @@ - (CFHTTPMessageRef) newHTTPRequest {
     }
 
     // Add authentication:
-    if (_responseMsg && _credential.user && !(_proxyType == kCBLHTTPProxy && _useProxyCONNECT)) {
+    if (_credential.user && !(_proxyType == kCBLHTTPProxy && _useProxyCONNECT)) {
         if (![self addAuthentication: _credential toRequest: httpMsg forProxy: false])
             _credential = nil;
     }
@@ -288,16 +288,6 @@ - (void) receivedResponse: (CFHTTPMessageRef)response {
 
         case 401: {
             NSString* authResponse = getHeader(_responseMsg, @"WWW-Authenticate");
-            if (!_authorizationHeader) {
-                if (!_credential)
-                    _credential = [self credentialForAuthHeader: authResponse];
-                CBLLog(WebSocket, @"%@: Auth challenge; credential = %@", self, _credential);
-                if (_credential) {
-                    // Recoverable auth failure -- try again with new _credential:
-                    _shouldRetry = YES;
-                    break;
-                }
-            }
             CBLLog(WebSocket, @"%@: HTTP auth failed; sent Authorization: %@  ;  got WWW-Authenticate: %@",
                 self, _authorizationHeader, authResponse);
             NSDictionary* challengeInfo = [[self class] parseAuthHeader: authResponse];