Open
Conversation
Contributor
WalkthroughUpdated Russian and Spanish frontend locale PO files: many translation msgstrs were added, updated, or removed; PO revision dates adjusted. Changes are limited to translation data only. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 1 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Important Action Needed: IP Allowlist UpdateIf your organization protects your Git platform with IP whitelisting, please add the new CodeRabbit IP address to your allowlist:
Reviews will stop working after February 8, 2026 if the new IP is not added to your allowlist. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Fix all issues with AI agents
In `@apps/cowswap-frontend/src/locales/ru-RU.po`:
- Around line 6597-6600: Update the Russian translation for the msgid in
LoadMoreOrdersSection (OrdersTableContainer) to fix grammar and spacing: replace
the current msgstr with a grammatically correct string using the plural form
"открытых ордеров" and remove the extra space after "Найдено" (e.g. "Найдено
{totalOpenOrders} открытых ордеров в списке {limit} последних.").
- Around line 5366-5368: The Russian translation for the protocol fee banner
(msgid in
apps/cowswap-frontend/src/modules/limitOrders/pure/ProtocolFeeInfoBanner/index.tsx)
omits the crucial clause about orders "executed after this time, even if they
were created earlier"; update msgstr to mirror the source by adding a literal
equivalent of "исполненные после этого времени, даже если они были созданы
ранее" while preserving the existing placeholders
{PROTOCOL_FEE_START_DATETIME_UTC} and the HTML tags <0> and <1> so the final
string reads logically and matches the source meaning.
Comment on lines
6597
to
6600
| #: apps/cowswap-frontend/src/modules/ordersTable/pure/OrdersTableContainer/LoadMoreOrdersSection.tsx | ||
| msgid "Found {totalOpenOrders} open orders in the {limit} most recent ones." | ||
| msgstr "" | ||
| msgstr "Найдено {totalOpenOrders} открытый ордеров в списке {limit} последних." | ||
|
|
Contributor
There was a problem hiding this comment.
Fix Russian grammar for open-order count.
“открытый ордеров” is ungrammatical; should be “открытых ордеров.”
✏️ Suggested fix
-msgstr "Найдено {totalOpenOrders} открытый ордеров в списке {limit} последних."
+msgstr "Найдено {totalOpenOrders} открытых ордеров в списке {limit} последних."🤖 Prompt for AI Agents
In `@apps/cowswap-frontend/src/locales/ru-RU.po` around lines 6597 - 6600, Update
the Russian translation for the msgid in LoadMoreOrdersSection
(OrdersTableContainer) to fix grammar and spacing: replace the current msgstr
with a grammatically correct string using the plural form "открытых ордеров" and
remove the extra space after "Найдено" (e.g. "Найдено {totalOpenOrders} открытых
ордеров в списке {limit} последних.").
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@apps/cowswap-frontend/src/locales/es-ES.po`:
- Around line 5558-5561: The Spanish translation for msgid "Cross-chain swaps
are here" in the translation entry used by the CrossChainUnlockScreen component
is incorrect; update the msgstr (currently "Los swaps de cadena media están
aquí") to use a correct rendering like "Los swaps entre cadenas están aquí" (or
"Los swaps multicadena están aquí") so the msgid -> msgstr mapping conveys
"cross‑chain" properly.
Comment on lines
5558
to
5561
| #: apps/cowswap-frontend/src/modules/swap/pure/CrossChainUnlockScreen/index.tsx | ||
| msgid "Cross-chain swaps are here" | ||
| msgstr "Los swaps entre cadenas están aquí" | ||
| msgstr "Los swaps de cadena media están aquí" | ||
|
|
Contributor
There was a problem hiding this comment.
Translation for “Cross-chain” is inaccurate.
“cadena media” doesn’t convey “cross‑chain.” Prefer “entre cadenas” or “multicadena.”
🔧 Suggested fix
-msgstr "Los swaps de cadena media están aquí"
+msgstr "Los swaps entre cadenas ya están aquí"📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| #: apps/cowswap-frontend/src/modules/swap/pure/CrossChainUnlockScreen/index.tsx | |
| msgid "Cross-chain swaps are here" | |
| msgstr "Los swaps entre cadenas están aquí" | |
| msgstr "Los swaps de cadena media están aquí" | |
| #: apps/cowswap-frontend/src/modules/swap/pure/CrossChainUnlockScreen/index.tsx | |
| msgid "Cross-chain swaps are here" | |
| msgstr "Los swaps entre cadenas ya están aquí" | |
🤖 Prompt for AI Agents
In `@apps/cowswap-frontend/src/locales/es-ES.po` around lines 5558 - 5561, The
Spanish translation for msgid "Cross-chain swaps are here" in the translation
entry used by the CrossChainUnlockScreen component is incorrect; update the
msgstr (currently "Los swaps de cadena media están aquí") to use a correct
rendering like "Los swaps entre cadenas están aquí" (or "Los swaps multicadena
están aquí") so the msgid -> msgstr mapping conveys "cross‑chain" properly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit