Skip to content

[feat][trace] support logid in trace tree search - #668

Merged
fankuo merged 1 commit into
mainfrom
feat/search-trace-tree-logid
Sep 17, 2026
Merged

fankuo merged 1 commit into
mainfrom
feat/search-trace-tree-logid

Conversation

@fankuo

@fankuo fankuo commented Sep 16, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • add optional logid to SearchTraceTreeOApiRequest
  • resolve trace time range from log ID and forward it to trace search
  • keep existing trace ID behavior and pagination unchanged

Testing

  • focused observability application tests
  • PPE smoke: 1,000 unique span IDs, fetched as 10 concurrent batches of 100; exact set match

@CLAassistant

CLAassistant commented Sep 16, 2026 •

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@codecov

codecov Bot commented Sep 16, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #668   +/-   ##
=======================================
  Coverage   78.82%   78.83%           
=======================================
  Files         707      707           
  Lines       87823    87824    +1     
=======================================
+ Hits        69227    69233    +6     
+ Misses      14607    14603    -4     
+ Partials     3989     3988    -1     
Flag Coverage Δ
unittests 78.83% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ckend/modules/observability/application/openapi.go 86.22% <100.00%> (+0.59%) ⬆️

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b699d63...d83b781. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@fankuo
fankuo merged commit 31b32b1 into main Sep 17, 2026
19 checks passed
@fankuo
fankuo deleted the feat/search-trace-tree-logid branch September 17, 2026 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants