Skip to content

[feat][trace] support logid in trace tree search #668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fankuo merged 1 commit into from
Sep 17, 2026
Merged

[feat][trace] support logid in trace tree search #668

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
77 changes: 77 additions & 0 deletions backend/kitex_gen/coze/loop/observability/openapi/coze.loop.observability.openapi.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

56 changes: 56 additions & 0 deletions backend/kitex_gen/coze/loop/observability/openapi/k-coze.loop.observability.openapi.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 3 additions & 2 deletions backend/modules/observability/application/openapi.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -709,7 +709,7 @@ func (o *OpenAPIApplication) SearchTraceTreeOApi(ctx context.Context, req *opena
}()

if req != nil && req.GetStartTime() == 0 && req.GetEndTime() == 0 && o.timeRange != nil {
st, et := o.timeRange.GetTimeRange(ctx, strconv.FormatInt(req.GetWorkspaceID(), 10), "", req.GetTraceID(), 1000*60*60*24)
st, et := o.timeRange.GetTimeRange(ctx, strconv.FormatInt(req.GetWorkspaceID(), 10), req.GetLogid(), req.GetTraceID(), 1000*60*60*24)
if st != nil && et != nil {
req.StartTime = st
req.EndTime = et
Expand Down Expand Up @@ -769,7 +769,7 @@ func (o *OpenAPIApplication) SearchTraceTreeOApi(ctx context.Context, req *opena
func (o *OpenAPIApplication) validateSearchTraceTreeOApiReq(ctx context.Context, req *openapi.SearchTraceTreeOApiRequest) error {
if req == nil {
return errorx.NewByCode(obErrorx.CommercialCommonInvalidParamCodeCode, errorx.WithExtraMsg("no request provided"))
} else if req.GetTraceID() == "" {
} else if req.GetTraceID() == "" && req.GetLogid() == "" {
return errorx.NewByCode(obErrorx.CommercialCommonInvalidParamCodeCode, errorx.WithExtraMsg("at least need trace_id or log_id"))
} else if req.Limit > MaxTraceTreeLength || req.Limit < 0 {
return errorx.NewByCode(obErrorx.CommercialCommonInvalidParamCodeCode, errorx.WithExtraMsg("invalid limit"))
Expand Down Expand Up @@ -801,6 +801,7 @@ func (o *OpenAPIApplication) buildSearchTraceTreeOApiReq(ctx context.Context, re
ThirdPartyWorkspaceID: o.workspace.GetThirdPartyQueryWorkSpaceID(ctx, req.GetWorkspaceID()),
Tenants: o.tenant.GetOAPIQueryTenants(ctx, platformType),
TraceID: req.GetTraceID(),
LogID: req.GetLogid(),
StartTime: req.GetStartTime(),
EndTime: req.GetEndTime(),
Limit: req.GetLimit(),
Expand Down
Loading
Loading