Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix question marks #439

Merged
merged 14 commits into from
Jan 18, 2024
Merged

Fix question marks #439

merged 14 commits into from
Jan 18, 2024

Conversation

W95Psp
Copy link
Collaborator

@W95Psp W95Psp commented Jan 17, 2024

This PR fixes #399 and adds some more tests.

W95Psp added 13 commits January 17, 2024 21:16
@W95Psp
feat(backends/fstar): different let operators for different monads
af83324
@W95Psp
feat(engine/ast-utils): call/call: add optional impl arguemnt
f90142d
@W95Psp
feat(engine/phase/cf-into-monads): do not attempt to rewrite ?
9e90f46 
Prevously I was adding some `from_residual` to take into account implicit `Result::Err(..)` coercions. Now, we move this to the phase resugaring question marks, that's much easier.
@W95Psp
refactor(engine/ast): rename converted_typ into return_typ
a1b6f27
@W95Psp
fix(build): track hax-engine-names as a dependency of `hax-engine-n…
6ad4791 
…ame-extract`

Otherwise, cargo won't recompile the binary `hax-engine-name-extract`
whenever the `hax-engine-names` crate changes.

Recompiling is *very* useful when developing on the engine: one adds a
rust name to `hax-engine-names`, and want `rebuild` to immediately
make that name availaible in the OCaml `Concrete_ident.name` variant.
@W95Psp
feat(engine/utils): add let*? that acts as a monadic guard
6bf6f22
@W95Psp
feat(engine/names): add ?-related names
0c3b226
@W95Psp
feat(prooflib/fstar): add u8::wrapping_sub
896fb6e
@W95Psp
feat(prooflib/fstar): add Result::map_err
f9b7edf
@W95Psp
feat(prooflib/fstar): add let| and let?
06e88e1
@W95Psp
feat(engine/phase/question-marks): rework, fix #399
9369adb
@W95Psp
feat(tests/side-effects): enable snapshots
902d844
@W95Psp
feat(prooflib/fstar): add monadic operators and runners
ed38a3e
@W95Psp W95Psp force-pushed the fix-question-marks branch from 2828612 to ed38a3e Compare January 17, 2024 20:17
franziskuskiefer
franziskuskiefer requested changes Jan 18, 2024
View reviewed changes
Copy link
Member

@franziskuskiefer franziskuskiefer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, generally looks good to me.
But lets start documenting things. Please comment all the code you're touching.

tests/side-effects/src/lib.rs Show resolved Hide resolved
franziskuskiefer
franziskuskiefer approved these changes Jan 18, 2024
View reviewed changes
Copy link
Member

@franziskuskiefer franziskuskiefer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@W95Psp W95Psp force-pushed the fix-question-marks branch from fa3cbcb to 65c8f5b Compare January 18, 2024 14:41
@W95Psp W95Psp enabled auto-merge January 18, 2024 14:41
@W95Psp W95Psp force-pushed the fix-question-marks branch from 65c8f5b to a226114 Compare January 18, 2024 14:56
@W95Psp W95Psp added this pull request to the merge queue Jan 18, 2024
Merged via the queue into main with commit 070431c Jan 18, 2024
9 checks passed
@W95Psp W95Psp deleted the fix-question-marks branch January 18, 2024 15:35
@W95Psp W95Psp mentioned this pull request Jan 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@franziskuskiefer franziskuskiefer franziskuskiefer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix monadic transform for ?s
2 participants
@W95Psp @franziskuskiefer