Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port the project to C++11 - Part 2 #72

Merged
merged 12 commits into from
Sep 26, 2022
Merged

Port the project to C++11 - Part 2 #72

merged 12 commits into from
Sep 26, 2022

Conversation

lzaoral
Copy link
Member

@lzaoral lzaoral commented Aug 3, 2022

See commit messages.

@lzaoral lzaoral requested a review from kdudka August 3, 2022 15:27
@lzaoral lzaoral self-assigned this Aug 3, 2022
kdudka
kdudka requested changes Aug 4, 2022
View reviewed changes
Copy link
Member

@kdudka kdudka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Overall it looks good. Two minor comments inline...

@lzaoral
abstract-parser: drop dynamic_cast in favour of AbstractParser::input…
5cc2dbd 
…Format
@lzaoral
color: mark constant methods const
2fe057f
@lzaoral
csdiff: use using instead of typedef
1e7db3c
@lzaoral
csdiff: fix typos
3953d31
@lzaoral
csfilter: use using instead of typedef
7964574
@lzaoral
instream: use == instead of !s1.compare(s2)
b39d716
@lzaoral
instream: use std::ifstream instead of more generic std::fstream
87082d1 
* The constructor call is more succinct.
@lzaoral
instream: use defaulted default destructor
cd9e94b 
There is no point in closing std::ifstream in a destructor manually since
that will be done either way in its own destructor.
@lzaoral
instream: change type of line in handleError to unsigned long
80ea97f 
... because negative line number does not make any sense and
boost::file_parser_error::line also returns unsigned long.and pass msg by
a const reference.
@lzaoral
instream: pass std::string by value and then move it in constructors
4c1ec90 
... to avoid excessively copies of std::string rvalues.
@lzaoral
instream: use default member initializers for literals
7472caf
@lzaoral
instream: make argument identifiers of InStreamLookAhead consistent
d939290 
... between declaration and definition.
@lzaoral lzaoral requested a review from kdudka September 26, 2022 12:16
kdudka
kdudka approved these changes Sep 26, 2022
View reviewed changes
Copy link
Member

@kdudka kdudka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

@lzaoral
Copy link
Member Author

lzaoral commented Sep 26, 2022

Thanks for the review, @kdudka!

@lzaoral lzaoral merged commit d939290 into csutils:main Sep 26, 2022
@lzaoral lzaoral deleted the c++11-part2 branch September 26, 2022 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kdudka kdudka kdudka approved these changes

Assignees

@lzaoral lzaoral

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lzaoral @kdudka