Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port the project to C++11 - Part 2 #72

Merged
merged 12 commits into from
Sep 26, 2022
+48 −52
Merged

Port the project to C++11 - Part 2 #72

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
5cc2dbd
abstract-parser: drop dynamic_cast in favour of AbstractParser::input…
lzaoral Apr 19, 2022
2fe057f
color: mark constant methods const
lzaoral May 26, 2022
1e7db3c
csdiff: use using instead of typedef
lzaoral Aug 3, 2022
3953d31
csdiff: fix typos
lzaoral Aug 3, 2022
7964574
csfilter: use using instead of typedef
lzaoral Aug 3, 2022
b39d716
instream: use == instead of !s1.compare(s2)
lzaoral Aug 3, 2022
87082d1
instream: use std::ifstream instead of more generic std::fstream
lzaoral Aug 3, 2022
cd9e94b
instream: use defaulted default destructor
lzaoral Aug 3, 2022
80ea97f
instream: change type of line in handleError to unsigned long
lzaoral Aug 3, 2022
4c1ec90
instream: pass std::string by value and then move it in constructors
lzaoral Aug 3, 2022
7472caf
instream: use default member initializers for literals
lzaoral Aug 3, 2022
d939290
instream: make argument identifiers of InStreamLookAhead consistent
lzaoral Aug 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
csfilter: use using instead of typedef
@lzaoral
lzaoral committed Sep 26, 2022
commit 796457479bda2c926391665e26d75b58cca8929f
2 changes: 1 addition & 1 deletion src/csfilter.cc
View file
Original file line number Diff line number Diff line change
@@ -58,7 +58,7 @@ struct MsgReplace {
}
};

typedef std::vector<MsgReplace> TMsgReplaceList;
using TMsgReplaceList = std::vector<MsgReplace>;

struct MsgFilter::Private {
bool ignorePath = false;
6 changes: 3 additions & 3 deletions src/csfilter.hh
View file
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright (C) 2011 Red Hat, Inc.
* Copyright (C) 2011-2022 Red Hat, Inc.
*
* This file is part of csdiff.
*
@@ -26,8 +26,8 @@
#include <string>
#include <vector>

typedef std::vector<std::string> TStringList;
typedef std::map<std::string, std::string> TSubstMap;
using TStringList = std::vector<std::string>;
using TSubstMap = std::map<std::string, std::string>;

class MsgFilter {
public: