refactor: collateral zustand to tanstack #1423
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
0xAlunara
changed the title
0xAlunara
changed the base branch from
main
to
refactor/remove-dead-loan-code
| chartExpanded={chartExpanded} | ||
| page="create" | ||
| /> | ||
| {market && ( |
There was a problem hiding this comment.
Why is this added? It results in the page jumping during load
There was a problem hiding this comment.
For some reason the old code type asserted that llamma couldn't be undefined. But I'm not sure if that assertion is valid. How can it be asserted to not be null when stuff is being loaded? Either the assertion is somehow true and this won't jump, or stuff was being shown prematurely in the old verison. I'd rather keep this check to make sure there's no errors. If people never complained about the page jumping it's probably a safe assumption?
There was a problem hiding this comment.
People dont complain because it works, it just looks unprofessional
DanielSchiavini
dismissed stale reviews from 0xtutti and pilotvietnam
The base branch was changed.
0xAlunara
force-pushed
the
refactor/collateral-zustand-to-tanstack
branch
from
fc7f25d to
975d5ed
Compare
0xAlunara
force-pushed
the
refactor/collateral-zustand-to-tanstack
branch
from
975d5ed to
ebf681d
Compare
0xAlunara
force-pushed
the
refactor/collateral-zustand-to-tanstack
branch
from
ebf681d to
2804725
Compare
| return useMemo(() => { | ||
| if (!api) return undefined | ||
|
|
||
| // If markets aren't found they throw an error, but we want to return undefined instead |
There was a problem hiding this comment.
no please, ignoring errors is asking for tricky bugs.
If you want to catch invalid market IDs please check the exact exception and return a proper error state, not undefined
Depends on #1422
Focus is on removing stores in favor of tanstack queries & hooks, not whether legacy component make sense. In a few cases I've renamed
llamaorllammatomarketfor simplicity.