fix(inbox): NotificationInboxView renders nothing when inbox is hidden#1144
Draft
mahmoud-elmorabea wants to merge 1 commit into
Draft
fix(inbox): NotificationInboxView renders nothing when inbox is hidden#1144mahmoud-elmorabea wants to merge 1 commit into
mahmoud-elmorabea wants to merge 1 commit into
Conversation
…idden The standalone NotificationInboxView's content only handled visible/empty/list; it did not gate on the .hidden load state. So when the inbox is hidden (disabled workspace, or missing templates/branding): - empty + hidden fell into the "no messages" branch and showed a ProgressView, so a standalone embedding (e.g. the APN-UIKit "View Inbox" screen) could spin indefinitely; and - messages + hidden rendered the list, showing rows when policy is to hide. Add a leading `.hidden` branch that renders nothing, matching NotificationInboxOverlay which hides its chrome entirely in this state. Addresses Cursor Bugbot's "Hidden inbox shows spinner" and "List ignores hidden state". Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Sample app builds 📱Below you will find the list of the latest versions of the sample apps. |
SDK binary size reports 📊SDK binary size of this PRSDK binary size diff report vs. main branch |
Contributor
Author
|
bugbot run |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit ffdafeb. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses two Cursor Bugbot findings on the standalone
NotificationInboxView(the view behind the sample "View Inbox" screen).Problem
NotificationInboxView.contenthandled only visible/empty/list and never gated on the.hiddenload state:ProgressView, so a standalone embedding could spin indefinitely when the inbox is disabled or branding/templates are missing. (Bugbot: "Hidden inbox shows spinner")Fix
Add a leading
if case .hiddenbranch that rendersEmptyView()— matchingNotificationInboxOverlay, which hides its chrome entirely in this state (andVisualInboxModel.showsChrome, which is alreadyfalsefor.hidden). One file:NotificationInboxView.swift.Verified it compiles (Customer.io-Package, iOS simulator). Draft, targeting
feat/overlay-inbox.🤖 Generated with Claude Code
Note
Low Risk
Single SwiftUI branch in presentation logic; no auth, data, or API changes.
Overview
Standalone
NotificationInboxViewnow treatsmodel.state == .hiddenas a first-class UI state: it rendersEmptyView()instead of falling through to loading or list branches.That aligns embedded inbox screens with
NotificationInboxOverlay/showsChromebehavior when the inbox is not renderable (disabled workspace, missing templates/branding). Empty + hidden no longer shows an endless spinner; messages + hidden no longer shows stale rows.Reviewed by Cursor Bugbot for commit ffdafeb. Bugbot is set up for automated code reviews on this repo. Configure here.