Skip to content

fix(inbox): NotificationInboxView renders nothing when inbox is hidden #1144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
mahmoud-elmorabea wants to merge 1 commit into
base: feat/overlay-inbox
Choose a base branch
from
Draft

fix(inbox): NotificationInboxView renders nothing when inbox is hidden #1144

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions Sources/MessagingInbox/NotificationInboxView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,11 +58,16 @@ public struct NotificationInboxView: View {
.onAppear { if marksOpenedOnAppear { model.markVisibleMessagesOpened() } }
}

/// Panel body driven by load state: spinner while loading, empty placeholder when visible-but-empty,
/// otherwise the Jist-rendered list.
/// Panel body driven by load state: nothing when the inbox is hidden, spinner while loading,
/// empty placeholder when visible-but-empty, otherwise the Jist-rendered list.
@ViewBuilder
private var content: some View {
if model.messages.isEmpty, case .visible = model.state {
if case .hidden = model.state {
// Inbox is not renderable (disabled workspace, missing templates/branding). Render
// nothing — matching the overlay, which hides its chrome entirely in this state —
// rather than a perpetual spinner (empty + hidden) or a stale list (messages + hidden).
EmptyView()
} else if model.messages.isEmpty, case .visible = model.state {
// Genuinely caught up: visible with NO messages at all. Keyed off the full message list
// (not `renderableMessages`) so messages that merely lack a template don't read as
// "caught up". (When embedded standalone; the overlay hides chrome entirely in that case.)
Expand Down
Loading