LoginFragment: route non-auth URLs out of the WebView#221
Open
jim-daf wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #220.
LoginFragment.setupWebBrowseronly overrodeonPageStarted/onPageFinished, so any link the auth pages or Common Voice landing page rendered (privacy/terms/contact,mailto:, off-host stuff) loaded inside the login WebView. That breaks the cookie pickup inonPageFinishedand traps the user on a side page.Change
Add
shouldOverrideUrlLoading. Keep the WebView pinned to the hosts the OAuth flow actually uses (commonvoice.mozilla.org,auth.mozilla.auth0.com, plus*.mozilla.org/*.auth0.comfor redirect hops). Hand any other URL toIntent.ACTION_VIEWvia the system, wrapped intry/catch(ActivityNotFoundException)so an unhandled scheme cannot crash the fragment.The success path (Common Voice -> Auth0 -> Common Voice with
connect.sid) is unchanged. Imports forActivityNotFoundExceptionandWebResourceRequestare added.