Skip to content

LoginFragment: route non-auth URLs out of the WebView #221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jim-daf wants to merge 1 commit into
base: master
Choose a base branch
from
Open

LoginFragment: route non-auth URLs out of the WebView #221

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions app/src/main/java/org/commonvoice/saverio/ui/login/LoginFragment.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
package org.commonvoice.saverio.ui.login

import android.content.ActivityNotFoundException
import android.content.Intent
import android.graphics.Bitmap
import android.os.Bundle
Expand All @@ -8,6 +9,7 @@ import android.view.LayoutInflater
import android.view.View
import android.view.ViewGroup
import android.webkit.CookieManager
import android.webkit.WebResourceRequest
import android.webkit.WebView
import android.webkit.WebViewClient
import android.widget.Toast
Expand Down Expand Up @@ -147,6 +149,27 @@ class LoginFragment : ViewBoundFragment<FragmentLoginBinding>() {

webViewClient = object : WebViewClient() {

override fun shouldOverrideUrlLoading(
view: WebView?,
request: WebResourceRequest?
): Boolean {
val uri = request?.url ?: return false
val host = uri.host
val isAuthHost = host == "commonvoice.mozilla.org"
|| host == "auth.mozilla.auth0.com"
|| host?.endsWith(".mozilla.org") == true
|| host?.endsWith(".auth0.com") == true
if (isAuthHost && (uri.scheme == "https" || uri.scheme == "http")) {
return false
}
try {
startActivity(Intent(Intent.ACTION_VIEW, uri))
} catch (e: ActivityNotFoundException) {
Timber.w(e, "No activity to handle %s", uri)
}
return true
}

override fun onPageStarted(view: WebView?, url: String?, favicon: Bitmap?) {
showLoading()
}
Expand Down